Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22bee745-7753-a35a-afc0-e81e6c192248@intel.com>
Date:   Tue, 1 Mar 2022 09:08:29 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.6.1
Subject: Re: [PATCH 13/25] x86/sgx: Support adding of pages to initialized
 enclave
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <dave.hansen@linux.intel.com>, <tglx@linutronix.de>,
        <bp@alien8.de>, <luto@kernel.org>, <mingo@redhat.com>,
        <linux-sgx@vger.kernel.org>, <x86@kernel.org>, <seanjc@google.com>,
        <kai.huang@intel.com>, <cathy.zhang@intel.com>,
        <cedric.xing@intel.com>, <haitao.huang@intel.com>,
        <mark.shanahan@intel.com>, <hpa@zytor.com>,
        <linux-kernel@vger.kernel.org>
References: <cover.1638381245.git.reinette.chatre@intel.com>
 <9ab661a845d242cb10a90ade997f8ebda33cc7c9.1638381245.git.reinette.chatre@intel.com>
 <Yh44CahjtgAarDad@iki.fi>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Yh44CahjtgAarDad@iki.fi>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eVpBY0I5UEhNejRGbHgwY1d3anJXbHRvYTBXTlYvbEZpSk9ZMFFBME1JOTh5?=
 =?utf-8?B?RkFkNElFdnNjUXMzK3R2dEoveEdnYTBQamdOL3dnaGJnMEpzLzN2VnRvZzdp?=
 =?utf-8?B?TWJEOFBqc05YbWd2cTk4ejhrcFY1b1BkQ1IwNlhrZTNseG1mMnFKTC94Ukow?=
 =?utf-8?B?c09VdFVQZXVmbUpjS1dRb0dWdnF6TDRhczBpNkNWSlZqSFNLdnB0RkJzSnQx?=
 =?utf-8?B?bmdqSis0MDJuZmR2VmZoTXJULzdwcTFtQUcxOGhTU3RDUmlFN2Y0eXhRU1Nh?=
 =?utf-8?B?bnNwWWNwcGN2RW45TWRPc1FZblRibEYydVBaY1JvWVpQclFhaThJOWZLTjg2?=
 =?utf-8?B?YXRDdmFqd3ZSNmNqM3VWTXUrNVJtclVVcHlWWjdTa2g5eUFzbitRNGZFbm9X?=
 =?utf-8?B?Smw1aHY2VDdEMEFTaGZ4Yys0Slk4UXVoZnczeG1yaktUQkRDeS9uR1dYTW1L?=
 =?utf-8?B?RnJ3amhFUS9xRFdPZU1hc3NOOXY0MHhWZitKbE4zTUc0MVdiYWdWQndXOEZL?=
 =?utf-8?B?VjRibVc3enNNRlAwVTgvVUx6NGorWGRNN2FDanhDN2hrMG9BZjJyK2s1V0My?=
 =?utf-8?B?YVk0dUxRUElPSi9nT1QxeGdacTNXZU5OQi95MkQzUUNLdnQ0dE9Oek9KUDBv?=
 =?utf-8?B?M1VJZjhzdkdNUTA2MU9IcmZVSXZySzlod1B2Z2xqQVFSdzBQYjJhL3VOTy9N?=
 =?utf-8?B?ODYrUjVMaCt6K0xqc2JaaDc5b2hmNEVNMlAwc1k1UFJYUDJxMXdUdjNZUTlZ?=
 =?utf-8?B?dDNlSjBxMTgzeGhzZzM2ZUxXM1lsT2paUUJ5RnpDSngxUkZNc2U1aEYrY0Ry?=
 =?utf-8?B?ckEvSXlrRzNkY214S1lqMWo1QXd3eXNOcFppVFdJOS9mRWJPbGRtbjRIK21Q?=
 =?utf-8?B?SmdFaEk0dkQ4ekhzTTQ2amdmWVZMaXgzeXM4N3VueERPNXZrUURXazhFRWNZ?=
 =?utf-8?B?Q1YwVEowM2xySFNrTWVvQ0g2YUZDdW9VQmZmQUZyQUZwSXhJMExJOWJySGRn?=
 =?utf-8?B?RnNBWEFPeVJocXVrSGdnZHBlaExSVkFFVFRDVFhRRUhKbDhQLzNlKzB4NVJG?=
 =?utf-8?B?a1FoZnppWUJ0SWxSM3I5b3hKb2RGRncwRkZkQVBxdXRNWHFOcHpxM3RGakl5?=
 =?utf-8?B?VEh6VGpKRE9xSmk0cTFVQTRGaVhpUmszd0NlN015OEZScDNQUE1senVNSU80?=
 =?utf-8?B?YTQxalFLNHhmSDZaalFKV1ZoRWVIRUlpSFJuQW9ROS9seDg3eDFiaHBHcDJ0?=
 =?utf-8?B?aG1QMHRKZkZJTzBCZnF1ZUJ6RVVaRFJwZE5IMWw4M3FwTHUramVoY2RnN2Nu?=
 =?utf-8?B?eU9Rc0tROW9PUWNQMUVWZW41VnQzVlpuYk5ONHMvQTlmcTQ4blZ4c1dtVkRa?=
 =?utf-8?B?b0wzeTZpdnkzTVI1ZFk1QUJPT3lFblp6VmpYSGlXRnZ6MWcvZGNLejZVLyti?=
 =?utf-8?B?aVZyNi9pRHJOYlNsbmdtcVhsVGJvQUdqbjVlbUE4VjVscUhQNUE1MmU3ayt2?=
 =?utf-8?B?UWpFVkVEQTZMS2pVZlhVQmgzTW9hNUE3djRWc2V2b0VyRmZzMXhzMGg1OURx?=
 =?utf-8?B?dXRaQnJ4UHZrS0ZrS2dkeHE5WmNsS2gzTnAybDhSUXh3ZW9IM2xEdWVJWHdF?=
 =?utf-8?B?eVVhWllzL2pYWFBUSkNHVEFyV3Q3dGxzWitEaDVIejgvbUVnd0tUSk40STlj?=
 =?utf-8?B?bFl5TlBHeUVSMDBwWnd5Z05PQ0RRcUNZSEZDRFlPVWFzc1pMSW1PTjlTUUIr?=
 =?utf-8?B?Slp3NmdONmdJVHZJOFNlYllHNWsrdzBsY0p6UFVuRzcxUkhkQldETHN1Ty84?=
 =?utf-8?B?MmU0Zjl3cXZZVlZ4QndzanhXOExQSk94bTQzYzE2VGN1S3BTVTBwWkowZVZv?=
 =?utf-8?B?ekxXTUFRZm1DQThuSmRHeVZOV0pDU2ovZSsvT3NyK2hEK2h3VjFaQ0JvSUdU?=
 =?utf-8?B?RURkcEw5MEo1YmlhUEZPZ3lrNHdXUU8wOTUvQWJHOGlQMnh1U3lmbkVUbGxx?=
 =?utf-8?B?Rnd5bU9ERE1Ob3Y1aHh4L21ScDhpeHVJdy9JMFBkWG9wVmpMRTl4QXB4YWRD?=
 =?utf-8?B?eC9zT2VnZ1BUTDZPVDF0Wjl4eEZTYmJCdkFkMVZTMXVuR1NEcVZ1TWg1N0x3?=
 =?utf-8?B?SGdleENvNFZIMnNjUnBBTC83bkVKUWtMTTFSQzJuQlcrN08zTTFuOWVENXV0?=
 =?utf-8?B?bXJRRlZYaXIwaXUrL2kyNk00Ly91aWljVWhtUTFPT1FJUk5KdjhWU1pKN0hp?=
 =?utf-8?B?RHpoVnRIYTBwWFNDZGtEN2s1emhnPT0=?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 844ae36d-d2c1-4266-99cf-08d9fba61f3a
X-MS-Exchange-CrossTenant-AuthSource: BN0PR11MB5744.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 17:08:35.9837
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: obRN02wgLX5FUFE4HuPFktyjJDwCQJRZcfa5kUNXL9wmcNRjhYHvWaLIR58Nn7u4ZIlI1EPr/jnO3Nr6rdljv5gCpyNkDCXsQco5yVBU2mo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5624
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 3/1/2022 7:13 AM, Jarkko Sakkinen wrote:
> On Wed, Dec 01, 2021 at 11:23:11AM -0800, Reinette Chatre wrote:
>> diff --git a/arch/x86/kernel/cpu/sgx/encl.h b/arch/x86/kernel/cpu/sgx/encl.h
>> index 848a28d28d3d..1b6ce1da7c92 100644
>> --- a/arch/x86/kernel/cpu/sgx/encl.h
>> +++ b/arch/x86/kernel/cpu/sgx/encl.h
>> @@ -123,4 +123,6 @@ void sgx_encl_free_epc_page(struct sgx_epc_page *page);
>>  struct sgx_encl_page *sgx_encl_load_page(struct sgx_encl *encl,
>>  					 unsigned long addr);
>>  
>> +struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl);
>> +void sgx_encl_shrink(struct sgx_encl *encl, struct sgx_va_page *va_page);
>>  #endif /* _X86_ENCL_H */
>> diff --git a/arch/x86/kernel/cpu/sgx/ioctl.c b/arch/x86/kernel/cpu/sgx/ioctl.c
>> index 5dddb3c9f742..de0bf68ee842 100644
>> --- a/arch/x86/kernel/cpu/sgx/ioctl.c
>> +++ b/arch/x86/kernel/cpu/sgx/ioctl.c
>> @@ -17,7 +17,7 @@
>>  #include "encl.h"
>>  #include "encls.h"
>>  
>> -static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)
>> +struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)
>>  {
>>  	struct sgx_va_page *va_page = NULL;
>>  	void *err;
>> @@ -43,7 +43,7 @@ static struct sgx_va_page *sgx_encl_grow(struct sgx_encl *encl)
>>  	return va_page;
>>  }
>>  
>> -static void sgx_encl_shrink(struct sgx_encl *encl, struct sgx_va_page *va_page)
>> +void sgx_encl_shrink(struct sgx_encl *encl, struct sgx_va_page *va_page)
>>  {
>>  	encl->page_cnt--;
> 
> Nit: this should be a separate patch, e.g.
> 
>   x86/sgx: Export sgx_encl_{grow,shrink}()
> 
>   In order to use sgx_encl_{grow,shrink}() in the page augementation code
>   located in encl.c, export these functions.
> 

Sure, will do.

Reinette