Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp770209pxm; Wed, 2 Mar 2022 08:07:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJxl7RZPwsqBMoDHOtaMnQUgvCWE386cTaEQ8yJdafphyOye+b2jDh/MurDxiifmhFncMvBL X-Received: by 2002:a05:6402:349:b0:410:a0bd:35ad with SMTP id r9-20020a056402034900b00410a0bd35admr30275279edw.12.1646237277661; Wed, 02 Mar 2022 08:07:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646237277; cv=none; d=google.com; s=arc-20160816; b=sd/Db5EhIWCMO8vSlfDtgNyid/5+dYmzkNzd/I/k5NEu9b1j395Bewx2J0PVECG6za /hN+LWUAbGMf2yalPQXgGFzSsDyeScZx6cS1rnxG5EOZ+uKxx68qzSuQFO1U9WPSPwP4 MDge4Z8lf7acau21I744UoJI/7prIbaj9Nu2k//yEIRj4bwLKeteEi4mV9rrxoM3SsQQ bqjheVZPcSrcWoPithTDO5xIILPe8X/Et/ZsBj7FWiBWkO06dKbzFYRZxLf1qxZqD+sC +tUy1Hpf9F9EiHI6zxKtlIXHGQs2iRDYYh6tdlrT2Lln+ClsSV0vnsUpjd9kvZFbiT1H tWuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oML3ez974BnbaSNU8joG2IBCF5wjUDKJWW5nCOKYUYI=; b=O/XekLeSCn4o5HkY+Y4398VXg/b/8OcQWmGO4IGRv1Nus2sJRzBqRF+xYHtNJxfYvY xlUfGf2Ub0arTRLM3kvMFwqElOVQrA7rTolzYw+CxZnFomAIIjr+IC2GJ7b0YpGxkBF2 ZWIiWLGwvpCRzFpDiHTMVX31kKIbZHKtaQSfljhGnJGAqzixdKStZH+OfRrrDBlNn23r EK3Ux3qN7MHRjWqP8Jn+7zDGgoCMjXhP7CxOGH5VnpBptAs+T36AB/Hb8FM28E4grGJO YmwRRO3UXyZL1/TR4A/SEqnpaZPHKG/IUNA9cy/KXZDPPXGI3SRVbQLWc6jzWY+o9gA4 Qflg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CkEi6j+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w11-20020a170906384b00b006cf56ce1673si11781240ejc.552.2022.03.02.08.07.33; Wed, 02 Mar 2022 08:07:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="CkEi6j+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237984AbiCBPxX (ORCPT + 99 others); Wed, 2 Mar 2022 10:53:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242409AbiCBPwx (ORCPT ); Wed, 2 Mar 2022 10:52:53 -0500 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047147030F; Wed, 2 Mar 2022 07:51:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646236317; x=1677772317; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Cjd4bFeVZvdpt/iarKU9NQ+uoIe9qw+z067MGTrAvA8=; b=CkEi6j+/0POB625YZF9/qgaxjkpGfa03farPQtECm2FvbxU3VK2Foofx t9mkvUnJmqnVyn1cGTZ3XO4RwH6pK11Y1DvBkAU4MIaF43h1uuc0n+K/E C2KZOdRsAXOCtNyS7nVpMi29bEcHuTrjWo55i01vgXmnaKm49VspvgIIg 9sg7NSY1PE0QrF75fN7VwT0oq1hJgrD92okXOZmDGEp3GeHsIUdeyj4gt uxPNHnlNE33/KXNGnJh/ndKTCbZNw04abcNsxFVggoD61J9UOHjHtkjno 6fvnrL2orKM6tzHZAEn3KDTMHVfrNe2oSVkbS+7sON6zjJNGV6qXJqKec g==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="233397397" X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="233397397" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 07:51:15 -0800 X-IronPort-AV: E=Sophos;i="5.90,149,1643702400"; d="scan'208";a="493579099" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 07:51:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nPRFC-00AMqj-Gw; Wed, 02 Mar 2022 17:50:26 +0200 Date: Wed, 2 Mar 2022 17:50:26 +0200 From: Andy Shevchenko To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nuno =?iso-8859-1?Q?S=E1?= , Lars-Peter Clausen Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Message-ID: References: <20220210135522.26562-1-andriy.shevchenko@linux.intel.com> <20220213175559.46e8dee2@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220213175559.46e8dee2@jic23-huawei> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote: > On Thu, 10 Feb 2022 15:55:20 +0200 > Andy Shevchenko wrote: > > > In a couple of messages the constants, which have their definitions, > > are hard coded into the message text. Unhardcode them. > > > > While at it, add a trailing \n where it's currently missing. > > > > Signed-off-by: Andy Shevchenko > > Reviewed-by: Nuno S? > > Mostly so I can remember what is going on with this patch, > Nuno is OoO and planning to test this series when he returns. > > Given that I'll wait on Nuno's testing. Any news? -- With Best Regards, Andy Shevchenko