Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Message-ID: <trinity-80a229fb-42dd-4705-9c55-fe6f3a381a40-1646217098213@3c-app-gmx-bap21>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc:     Frank Wunderlich <linux@fw-web.de>, devicetree@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Rob Herring <robh+dt@kernel.org>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, Heiko Stuebner <heiko@sntech.de>,
        Peter Geis <pgwipeout@gmail.com>,
        Michael Riesch <michael.riesch@wolfvision.net>,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com
Subject: Aw: Re: [PATCH v4 1/5] dt-bindings: Convert ahci-platform DT
 bindings to yaml
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 2 Mar 2022 11:31:38 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <6dae47c3-6083-782e-ecab-7be3f0bca0e1@canonical.com>
References: <20220301152421.57281-1-linux@fw-web.de>
 <20220301152421.57281-2-linux@fw-web.de>
 <6dae47c3-6083-782e-ecab-7be3f0bca0e1@canonical.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Mittwoch, 02=2E M=C3=A4rz 2022 um 10:46 Uhr
> Von: "Krzysztof Kozlowski" <krzysztof=2Ekozlowski@canonical=2Ecom>

> On 01/03/2022 16:24, Frank Wunderlich wrote:
> > From: Frank Wunderlich <frank-w@public-files=2Ede>

> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +        - enum:
> > +          - brcm,iproc-ahci
> > +          - marvell,armada-8k-ahci
> > +          - marvell,berlin2q-ahci
> > +        - const: generic-ahci
> > +      - enum:
> > +        - brcm,iproc-ahci
>=20
> This one is already earlier in generic-ahci, so you can skip him here=2E

OK, i drop it

> > +        - cavium,octeon-7130-ahci
> > +        - hisilicon,hisi-ahci
> > +        - ibm,476gtr-ahci
> > +        - marvell,armada-3700-ahci
> > +        - marvell,armada-380-ahci
> > +        - snps,dwc-ahci
> > +        - snps,spear-ahci
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    description:
> > +      Clock IDs array as required by the controller=2E
> > +    minItems: 1
> > +    maxItems: 3
> > +
> > +  interrupts:
> > +    description:
> > +      specifies the interrupt number for the controller=2E
>=20
> Skip description, it's obvious=2E

OK

> > +    maxItems: 1
> > +
> > +  ahci-supply:
> > +    description:
> > +      regulator for AHCI controller
> > +
> > +  clock-names:
> > +    description:
> > +      Names of clocks corresponding to IDs in the clock property=2E
> > +    minItems: 1
> > +    maxItems: 3
>=20
> Put the clock-names next to clocks=2E

had moved them down as they are optional, but ok, i move up

> > +
> > +  dma-coherent:
> > +    true
>=20
> New line not needed=2E "dma-coherent: true"

OK

> > +  ports-implemented:
> > +    $ref: '/schemas/types=2Eyaml#/definitions/uint32'
> > +    description:
> > +      Mask that indicates which ports that the HBA supports
> > +      are available for software to use=2E Useful if PORTS_IMPL
> > +      is not programmed by the BIOS, which is true with
> > +      some embedded SoCs=2E
> > +    maxItems: 1
>=20
> maxItems are incorrect here, this is not an array=2E

right, i'll change it

> > +patternProperties:
> > +  "^sata-port@[0-9a-f]+$":
> > +    type: object
> > +    description:
> > +      Subnode with configuration of the Ports=2E
> > +
> > +    properties:
> > +      reg:
> > +        maxItems: 1
> > +
> > +      phys:
> > +        minItems: 1
>=20
> maxItems: 1

oh, missed that

> > +    #include <dt-bindings/interrupt-controller/arm-gic=2Eh>
> > +    #include <dt-bindings/clock/berlin2q=2Eh>
> > +    sata@f7e90000 {
> > +            compatible =3D "marvell,berlin2q-ahci", "generic-ahci";
> > +            reg =3D <0xe90000 0x1000>;
>=20
> You still have wrong address=2E

only took the example from the txt, but i guess reg should be <0xf7e90000 =
0x1000>; ?

will also fix all subjects to

"dt-bindings: ata: ahci-platform: =2E=2E=2E"

Thanks