Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Christoph Hellwig <hch@lst.de>
Cc:     Jens Axboe <axboe@kernel.dk>, Coly Li <colyli@suse.de>,
        Mike Snitzer <snitzer@redhat.com>, Song Liu <song@kernel.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>,
        Phillip Lougher <phillip@squashfs.org.uk>,
        linux-block@vger.kernel.org, dm-devel@redhat.com,
        linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
        linux-raid@vger.kernel.org, target-devel@vger.kernel.org,
        linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/5] target/pscsi: remove pscsi_get_bio
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wnhd12ox.fsf@ca-mkp.ca.oracle.com>
References: <20220301084552.880256-1-hch@lst.de>
        <20220301084552.880256-4-hch@lst.de>
Date:   Tue, 01 Mar 2022 21:57:51 -0500
In-Reply-To: <20220301084552.880256-4-hch@lst.de> (Christoph Hellwig's message
        of "Tue, 1 Mar 2022 10:45:50 +0200")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?875h7fhyQxrq4QED1uFBLMMDGKT1znnf6ly6RGjoTeW4XFTPP3sHjQGU0GzX?=
 =?us-ascii?Q?Fh/YpEqrkYmh1RQF7CdIPdXCgW232fIaRlcGgX8cbeDNnZEIs/xbMTUgr9Fl?=
 =?us-ascii?Q?1r4MXfFjMBG/L/DzfxO25Ff1ZNfh4UmG0Yxft8eI0Q8+mLeqrUxLnWT7mUp7?=
 =?us-ascii?Q?FPcMRy+e0JIRDl+nqZnxOFWaJOkjH1W71Mt6sdDt3JK3ATWATkx8mxyEPHbp?=
 =?us-ascii?Q?RSU5YH79xPTBVi0vnQCNqo7ToF96zTcfQBpmq+CX9F6Xa/O5XRaEnqa7V8A+?=
 =?us-ascii?Q?AVklpS/wk7wHBqSKWOPWfxkfzWHuayXDYJtZ+Q1rN54IRQgxIxNnj1J3Eifc?=
 =?us-ascii?Q?30H7aIKuv+IjRsgCqrk8PjWDdpG8hA5sBCR9Ps99JyvAsqHkBnHiXdt5UF6L?=
 =?us-ascii?Q?okrUA3LGNgfERjAQ43aL2KsvPwsxECfCppJJ8cZ0wdNKbEIfZ7ubv9L138st?=
 =?us-ascii?Q?Ba+g7k3bIcgzqTKNTb2bbM08olgNfmM0y4G/3+3lg+PlT0Gof/H1wZugHl5+?=
 =?us-ascii?Q?HXLApGsrZ3lFYw8s+xXrYQxUsiq+qLa0xTtJYzaPBosZU683gnJfLfba6fho?=
 =?us-ascii?Q?TFQH770GCWWxktlp8ppueWO+aea+vCjhxetpnnS5T3pJzzvMHbjkzqY09o8E?=
 =?us-ascii?Q?8dhH9RV0Wf6EfnLq4jkBcFaIHobPUQVJRWuMcKxtbC20lLaNdROY/PLP87mC?=
 =?us-ascii?Q?O7sau45BqHvfDCtKzm9JT2Og9NWMhujmbriTR1UzDY5JhAFgx9IsE1bOk6uO?=
 =?us-ascii?Q?zrPZDlSket039vIElDfmzW4TUpbSfneo/EDPP3lDw+mASoJFf0Bwyramwwad?=
 =?us-ascii?Q?6J1mYNXxA3ByV3J3IAhgTJH2SMx0U3M1McirQo6n6DVA3Fk/RSLBvPXJsTNl?=
 =?us-ascii?Q?LtPiwztAAXvm2+cNkMVH6Y7K+Bj+dgQODVagBSclrcMGhVgxmj6Y9uThe313?=
 =?us-ascii?Q?ZSvAoDImk5ENiKMK4IbK3nnkuKYJ8o/nnOUSDg8e5NoZ+kqQuHsRP0GojtBy?=
 =?us-ascii?Q?mjZf920aFIvkPBXWD3llTCMi9Bpk0x6Dk/M980CMMLjDjR48SV3vuxkZy6Rw?=
 =?us-ascii?Q?2TDIuamB3vdmHQ4Tbi0Zl2NiqZBF3ygyEAiFdO5JrIOi8AkYJ3xtFsyDBGDO?=
 =?us-ascii?Q?jrAS0aWwvfpXTUCr1hiA2EJzfwAZJtDj0H4BUmznJ6p4069AcPLky64uv/uI?=
 =?us-ascii?Q?sBnNGt5ByLd7yxfox05x1mzKB8UwMdqpP6G220pFlUOfBwshbhSizOTFip8N?=
 =?us-ascii?Q?MHtQOz7BwUQyKZ9Td6X4UTSVpsURm8kiLmhuubOQ39V2F1s7W++mKxMPpOMl?=
 =?us-ascii?Q?sxNRRV8TigxNiabpVKMzqkikeBcVIsENIHMjPTyriFwGQB5G5LGXZZOM+vK/?=
 =?us-ascii?Q?CW2/4RK7gq7E+JBb5qN37BEpGnuRIBSb9sfoZe/ZDviyrmn/FebjdOSl3j72?=
 =?us-ascii?Q?KZ2FuYwLQfMp7D9qBXY1h54aU/ajujEhHh3mdQgM45j4PFymbs2B+w26VTkr?=
 =?us-ascii?Q?bnzTX4fJC0AKPMVf7rAt29ibUcaDMwQh+J/H+3xoIOmCUD5XGqZJ3aqP7dwW?=
 =?us-ascii?Q?ot5Apwobi+R79pnwxsc4/IkadfsROFZO4YdBNQ89Hzlq8J0YKjGrDq5A+fEO?=
 =?us-ascii?Q?soTmnNSdWzDgZQlTJvDt7LJdjeGQjhYIPi6dUdH+xVI38mHjI9TTCysPo4B4?=
 =?us-ascii?Q?Uh6w4Q=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c26137fb-a0d9-437c-10d5-08d9fbf87331
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 02:57:55.3630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xUXJBOrh/Xs+6jY20VhfkPwTqrGXpkrTYce3D3j8AmV8JcY7dRzHXT87DOszRMNxA34lzcwJF0Bz4IgQo02CwzexeK83JE7hOnIZJraWSAI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4715
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2203020011
X-Proofpoint-ORIG-GUID: 8uz4cpshiBD04SVd12ec8rjv8t0GC1iY
X-Proofpoint-GUID: 8uz4cpshiBD04SVd12ec8rjv8t0GC1iY
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Christoph,

> Remove pscsi_get_bio and simplify the code flow in the only caller.

Looks good to me.

Acked-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering