Received: by 2002:ac2:5a04:0:0:0:0:0 with SMTP id q4csp364766lfn; Wed, 2 Mar 2022 08:50:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJw0nDvuTAoFTz96NT5zmAorQ5Mn/pM5eMD9Db4lZBXbZq6I1CD54M6+35aZOFsGEEmOiMt3 X-Received: by 2002:a63:4c8:0:b0:374:3423:64fb with SMTP id 191-20020a6304c8000000b00374342364fbmr26348410pge.474.1646239824070; Wed, 02 Mar 2022 08:50:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646239824; cv=none; d=google.com; s=arc-20160816; b=KXpmwFe0os8Q7g71SdXW9HDtGXHwl07l7whAqZqvdSLB45HhEnE4xK8UCf76bWQ4us 6ni7ZwGTVyXJaTmfSteJh2RAHQ0+RPchrwFah+Sv+kRf/Jv8ZYdI5inJBFxiWsOfTpw7 73S5Q9mHNpvdsYp0nC6wCvDvl1MULN2WdGt4vejvyfhC3VP/8Q8Xt6yYy+OuHwJYCaPd pvKrw12X0XGniaMyfHadi7GZz7CFcEz5iqd2cnsiFC737mEkfZyQukybQcK96qMC98oM a/Ra0FJEY5PzPIKkS31DTQ/GcahL0mHlvrQnyf28zGoVAXnPg8xAMp3U9/w3I6r1lo0u YOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ymAiqH7FrFQT4kALiSCU8D+YjYYsG1H9OJ7iD9GzacQ=; b=wi/RQoPdaro3TqMnSeIJem6zcNug9BvhUJiK93kGOY8reztYpuqA68cYWV/tciAQ3w HmhQAoesszUVY07mBDvrrm7GjU9qJzO9za+pukdN5EoIZef8Pmu6o3BxLm1I/8/6ewNJ jKGH+mD4mVMumr98a/DQmzfZjReM50eIRtDp8FuMHYBDctT+RLpBktluBUs1NqSSDjkr s/t7ol8S7bM3G28mxZ6zjKJ1W+sojuT/KjjjjWYcwGG3aKrRmv5vMrUu/o1ewBkUKcrx DJa/jZk7er3zXwVXa4hDZocWnW3qfa2E1lNGWKCtX66/ytTZnzpsShgYReypiImdNXua Cv+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pc16-20020a17090b3b9000b001bd43c50f99si6162368pjb.21.2022.03.02.08.49.24; Wed, 02 Mar 2022 08:50:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242784AbiCBOya (ORCPT + 99 others); Wed, 2 Mar 2022 09:54:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233504AbiCBOy0 (ORCPT ); Wed, 2 Mar 2022 09:54:26 -0500 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E21722DD66; Wed, 2 Mar 2022 06:53:42 -0800 (PST) Received: by mail-wr1-f46.google.com with SMTP id r10so3218046wrp.3; Wed, 02 Mar 2022 06:53:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ymAiqH7FrFQT4kALiSCU8D+YjYYsG1H9OJ7iD9GzacQ=; b=F5qx+QEZefC0cP/nJbw/3/C5Y0U2ef4IPOf1oD/kcf5cGpBIHd4oPR51HhZ7QzTMf4 MV2yzcAyzWXT28DLYZgBcFARXnTlQwtrz0QLzZ1OHfZuHiEIBs1yrcjrgDCubRXbTq/u m/J8tY3z3ulgtnzS96cKnnM0iLZ4ZVla3QTsENa7fujWZpYloCyU4onoj1zjX3Oz60+e 2uV1oQWedY2MAEf7Ft9ODgMV2FFpUohx6yG2QRZuB+useyFexXhCy4JSFUrGphWjRedl M3tVN7yu2a5hU5eT/Q2q7kCqPa2d4JZUfbw95FVPc4TNocdu/ewVMCTkHt8pSHy21jzU EdNQ== X-Gm-Message-State: AOAM530zbT2WuC2FVUzkHr5w72cXjc2sgMM0VOOtKwrUAT4Rh3k3Y6JY W0+oLlTrqFDd5XQ1cchE7es= X-Received: by 2002:a05:6000:156a:b0:1ed:ab7e:b69b with SMTP id 10-20020a056000156a00b001edab7eb69bmr23447319wrz.305.1646232821500; Wed, 02 Mar 2022 06:53:41 -0800 (PST) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id n5-20020a05600c3b8500b00380fc02ff76sm6686255wms.15.2022.03.02.06.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 06:53:41 -0800 (PST) Date: Wed, 2 Mar 2022 14:53:39 +0000 From: Wei Liu To: Iouri Tarassov Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, spronovo@microsoft.com, spronovo@linux.microsoft.com, gregkh@linuxfoundation.org Subject: Re: [PATCH v3 00/30] Driver for Hyper-v virtual compute device Message-ID: <20220302145339.2s2bt252sxj3lsn6@liuwe-devbox-debian-v2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Iouri I've gone through the whole series. A large portion of the series is about graphics stuff which is out of my wheelhouse. I have two general comments here. There seems to be an excessive amount pr_debug / pr_err in code. Please try to reduce their number a bit. For memory allocation you always use vzalloc, however large or small the allocation may be. Why not use kzalloc for smaller allocations? Thanks, Wei.