Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 15:16:53 +0200
From:   Boris Kolpackov <boris@codesynthesis.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: change .config format to use =n instead of "is
 not set"
Message-ID: <boris.20220302145825@codesynthesis.com>
References: <20220226123755.85213-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220226123755.85213-1-masahiroy@kernel.org>
Organization: Code Synthesis
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Masahiro Yamada <masahiroy@kernel.org> writes:

> With this commit, Kconfig will output disable options in a more natural
> form, "CONFIG_FOO=n".

While I agree with the overall direction, I was wondering how this
relates to string and int/hex options. It appears that they either
have a value or are not written to the .config at all, for example,
if the option is disabled via the `depends on` attribute. At first
I thought this would be inconsistent (i.e., =n for bool and omitted
for string), but it appears a disabled bool option is also omitted.
Hopefully the fact that sometimes a false bool option is =n and
sometimes it's omitted won't surprise anyone.

Reviewed-by: Boris Kolpackov <boris@codesynthesis.com>