Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 10:27:05 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Chun-Tse Shao <ctshao@google.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Michal Marek <michal.lkml@markovi.net>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Frank Rowand <frowand.list@gmail.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        devicetree@vger.kernel.org
Subject: Re: [PATCH] config: Using HOSTPKG_CONFIG prefix for pkg-config
Message-ID: <20220302102705.15c32822@gandalf.local.home>
In-Reply-To: <CAL_JsqK59GGhYQSEWvb=HtHTwMh=LXomu2zX4dEQeo4s3A0VtQ@mail.gmail.com>
References: <20220301230629.1892828-1-ctshao@google.com>
        <CAL_JsqK59GGhYQSEWvb=HtHTwMh=LXomu2zX4dEQeo4s3A0VtQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 2 Mar 2022 08:18:15 -0600
Rob Herring <robh+dt@kernel.org> wrote:

> On Tue, Mar 1, 2022 at 5:07 PM Chun-Tse Shao <ctshao@google.com> wrote:
> >
> > In some parts, pkg-config does not use appropriate $BUILDROOT prefix.  
> 
> The kernel tree knows nothing about buildroot. Please reword this in a
> more generic way that you need to override the host pkg-config.

I don't even know what $BUILDROOT is ;-)

But I do know that it's good practice to allow pkg-config to be overridden.
I have several user space tools that needed it done to allow distros to
install them properly.

Would you be OK with a description like:

    Allow kernel installation packaging to override pkg-config.

?

> 
> > The patch adds HOSTPKG_CONFIG prefix for pkg-config to fix the issue.

A couple of things. It is consider poor form to reference "the patch".
Another thing is that this is not a prefix for pkg-config, it is overriding
what pkg-config is used during the build process.

    Add HOSTPKG_CONFIG to allow tooling that builds the kernel to override
    what pkg-config and parameters are used.

Something like that.

-- Steve


> >
> > Signed-off-by: Chun-Tse Shao <ctshao@google.com>