Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932279AbXBSOaA (ORCPT ); Mon, 19 Feb 2007 09:30:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932283AbXBSOaA (ORCPT ); Mon, 19 Feb 2007 09:30:00 -0500 Received: from nf-out-0910.google.com ([64.233.182.188]:19010 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932279AbXBSO37 (ORCPT ); Mon, 19 Feb 2007 09:29:59 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender; b=mDIjWa12uWLJZIwg8kRXxnsAa1NPJnxm/U/b2ou4bua6MJhYwQ1i+tSuYAWjBCqPrYa8vpk2L/9mbvNcbqU+ZhadzhOZdL6vXrvZ0bYeCAEK/EYCiI11eiwNt4cJZXEaHbpNCD9sCGv98VCNa02RYJ6fuPxOuM/dfuzwLHmn6H4= Date: Tue, 20 Feb 2007 14:29:05 +0000 From: Frederik Deweerdt To: Jens Axboe Cc: Michal Piotrowski , Andrew Morton , Mattia Dongili , Laurent Riffard , linux-kernel@vger.kernel.org Subject: Re: [-mm patch] fix locking in __make_request (was Re: 2.6.20-mm2: Oops in generic_make_request) Message-ID: <20070220142905.GG566@slug> References: <20070217215146.30e7ffa3.akpm@linux-foundation.org> <45D84F73.8060904@free.fr> <20070218175805.GB5567@inferi.kami.home> <20070218114903.a8160301.akpm@linux-foundation.org> <6bffcb0e0702181205v5755fc0es284c5be32f85d304@mail.gmail.com> <20070220130408.GB566@slug> <20070219133453.GL17728@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070219133453.GL17728@kernel.dk> User-Agent: mutt-ng/devel-r804 (Linux) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1989 Lines: 55 On Mon, Feb 19, 2007 at 02:34:53PM +0100, Jens Axboe wrote: > On Tue, Feb 20 2007, Frederik Deweerdt wrote: > > On Sun, Feb 18, 2007 at 09:05:33PM +0100, Michal Piotrowski wrote: > > > On 18/02/07, Andrew Morton wrote: > > > >On Sun, 18 Feb 2007 18:58:05 +0100 Mattia Dongili wrote: > > > > > > > >> On Sun, Feb 18, 2007 at 02:06:59PM +0100, Laurent Riffard wrote: > > > >> > Le 18.02.2007 06:51, Andrew Morton a ?crit : > > > >> > >Temporarily at > > > >> > > > > > >> > > http://userweb.kernel.org/~akpm/2.6.20-mm2/ > > > >> > > > > > >> > >Will appear later at > > > >> > > > > > >> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.20/2.6.20-mm2/ > > > >> > > > > >> > Hello, I've got a fully reproducible Oops. I just have to boot to > > > >> > runlevel 2 and wait less than one minute. > > > >> > > > >> Maybe this oops is related too? > > > > > > > >Looks that way. > > > > > > Hi Michal, > > > > This seems to be a locking problem in __make_request, check_plug_merge() > > should be called with the q->queue_lock held. > > Could you try the following patch? It silenced the oops for me. > > Just back from travel... That is not correct, why do you think the queue > lock needs to be held there? The unprotected: check_plug_merge -> bio_attempt_back_merge -> ll_back_merge_fn -> q->last_merge = NULL made me think that. I don't know the code enough though. Regards, Frederik > > -- > Jens Axboe > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/