Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Mark Brown <broonie@kernel.org>
To:     lgirdwood@gmail.com, tiwai@suse.com, perex@perex.cz,
        Jiasheng Jiang <jiasheng@iscas.ac.cn>, vkoul@kernel.org
Cc:     linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
In-Reply-To: <1634285633-529368-1-git-send-email-jiasheng@iscas.ac.cn>
References: <1634285633-529368-1-git-send-email-jiasheng@iscas.ac.cn>
Subject: Re: [PATCH v2] ASoC: soc-compress: prevent the potentially use of null pointer
Message-Id: <164624045702.1145067.14385834637074739247.b4-ty@kernel.org>
Date:   Wed, 02 Mar 2022 17:00:57 +0000
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Fri, 15 Oct 2021 08:13:53 +0000, Jiasheng Jiang wrote:
> There is one call trace that snd_soc_register_card()
> ->snd_soc_bind_card()->soc_init_pcm_runtime()
> ->snd_soc_dai_compress_new()->snd_soc_new_compress().
> In the trace the 'codec_dai' transfers from card->dai_link,
> and we can see from the snd_soc_add_pcm_runtime() in
> snd_soc_bind_card() that, if value of card->dai_link->num_codecs
> is 0, then 'codec_dai' could be null pointer caused
> by index out of bound in 'asoc_rtd_to_codec(rtd, 0)'.
> And snd_soc_register_card() is called by various platforms.
> Therefore, it is better to add the check in the case of misusing.
> And because 'cpu_dai' has already checked in soc_init_pcm_runtime(),
> there is no need to check again.
> Adding the check as follow, then if 'codec_dai' is null,
> snd_soc_new_compress() will not pass through the check
> 'if (playback + capture != 1)', avoiding the leftover use of
> 'codec_dai'.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: soc-compress: prevent the potentially use of null pointer
      commit: de2c6f98817fa5decb9b7d3b3a8a3ab864c10588

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark