Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 14:06:00 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Sven Peter <sven@svenpeter.dev>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guido =?iso-8859-1?Q?G=FCnther?= <agx@sigxcpu.org>,
        Hector Martin <marcan@marcan.st>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: tipd: Forward plug orientation to typec
 subsystem
Message-ID: <Yh9dqPh69wcI3har@kuha.fi.intel.com>
References: <20220226125912.59828-1-sven@svenpeter.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220226125912.59828-1-sven@svenpeter.dev>
Precedence: bulk

On Sat, Feb 26, 2022 at 01:59:12PM +0100, Sven Peter wrote:
> In order to bring up the USB3 PHY on the Apple M1 we need to know the
> orientation of the Type-C cable. Extract it from the status register and
> forward it to the typec subsystem.
> 
> Signed-off-by: Sven Peter <sven@svenpeter.dev>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c     | 5 +++++
>  drivers/usb/typec/tipd/tps6598x.h | 1 +
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 7ffcda94d323..16b4560216ba 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -256,6 +256,10 @@ static int tps6598x_connect(struct tps6598x *tps, u32 status)
>  	typec_set_pwr_opmode(tps->port, mode);
>  	typec_set_pwr_role(tps->port, TPS_STATUS_TO_TYPEC_PORTROLE(status));
>  	typec_set_vconn_role(tps->port, TPS_STATUS_TO_TYPEC_VCONN(status));
> +	if (TPS_STATUS_TO_UPSIDE_DOWN(status))
> +		typec_set_orientation(tps->port, TYPEC_ORIENTATION_REVERSE);
> +	else
> +		typec_set_orientation(tps->port, TYPEC_ORIENTATION_NORMAL);
>  	tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), true);
>  
>  	tps->partner = typec_register_partner(tps->port, &desc);
> @@ -278,6 +282,7 @@ static void tps6598x_disconnect(struct tps6598x *tps, u32 status)
>  	typec_set_pwr_opmode(tps->port, TYPEC_PWR_MODE_USB);
>  	typec_set_pwr_role(tps->port, TPS_STATUS_TO_TYPEC_PORTROLE(status));
>  	typec_set_vconn_role(tps->port, TPS_STATUS_TO_TYPEC_VCONN(status));
> +	typec_set_orientation(tps->port, TYPEC_ORIENTATION_NONE);
>  	tps6598x_set_data_role(tps, TPS_STATUS_TO_TYPEC_DATAROLE(status), false);
>  
>  	power_supply_changed(tps->psy);
> diff --git a/drivers/usb/typec/tipd/tps6598x.h b/drivers/usb/typec/tipd/tps6598x.h
> index 3dae84c524fb..527857549d69 100644
> --- a/drivers/usb/typec/tipd/tps6598x.h
> +++ b/drivers/usb/typec/tipd/tps6598x.h
> @@ -17,6 +17,7 @@
>  /* TPS_REG_STATUS bits */
>  #define TPS_STATUS_PLUG_PRESENT		BIT(0)
>  #define TPS_STATUS_PLUG_UPSIDE_DOWN	BIT(4)
> +#define TPS_STATUS_TO_UPSIDE_DOWN(s)	(!!((s) & TPS_STATUS_PLUG_UPSIDE_DOWN))
>  #define TPS_STATUS_PORTROLE		BIT(5)
>  #define TPS_STATUS_TO_TYPEC_PORTROLE(s) (!!((s) & TPS_STATUS_PORTROLE))
>  #define TPS_STATUS_DATAROLE		BIT(6)
> -- 
> 2.25.1

thanks,

-- 
heikki