Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp191167pxm; Wed, 2 Mar 2022 13:11:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJzSgvYWilNjMtPiXBjoNXA3yKtNgm/QTnyavh/5z1YA9z+zRaZiGDIt+LX3Cla6ygaaQsXU X-Received: by 2002:a17:90b:4f8d:b0:1bf:a53:48dd with SMTP id qe13-20020a17090b4f8d00b001bf0a5348ddmr854065pjb.89.1646255509684; Wed, 02 Mar 2022 13:11:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646255509; cv=none; d=google.com; s=arc-20160816; b=YhXtWpAbBkjE9V1L6dpyyDJUsdNQ8vxl3fjaFeNOHTJuGaMliVjt3rnrpRKN0IDFtq u99Vt1vdAi+Q9gS/jnaBsaNCEyeA+IpfpeHrLuUnir2FUA2gqSHzLuxXkwh4veRMIYHu 9/hlT7qUqIWk37cxits8ma3mcU6zYdJpDukFJnwngy4aRloAU2jb6aw+qWO96XhTj2VV 82P4/jIBUqQ9mkvOf0g5gQot66ewzz+4Bmsr1jASSBNH4kd8fMN64DGJVJfUPw15+MsA SlhJ+rZAmXQ2WSTsxA0DdB045/xh10xskgFvqswH64BLwi9heQtabxT7PhwPFQAIaIDF F2Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=7xezorvF5Je4gnmirpI6zBH/ugWSm7nF93sTZv2TuWk=; b=xECh4mnBQ2vQie7G4dqVUOKjuZkpY+zojqpHHW9meHdDHVsocsyEHFaZvZXRBwOYbq 75+NpAqs/2DCgLvfkgylXD6YeavrD6Xq6AZpH47bRNLBDkbIGyzmgHmVuoyEiHdS8Hrm WUJIyaBnC2xYWcfvUCG9Tmed9pJLzs2JMNK6mTH/mGIT7C1iTBCumZ0AzYCd2SVVLLYD QRaNMqgEQH0RHlocV0ign2gkA9zwRampWEDVlLi/Q2K5HJeYK7HGdKe8F4ba6AniZYb1 D7sQUWuqqPLPoGPPI8LjuBEhtq4zwvIh7TEryS+slTDK8GKdWetkx0WvvOzQAEkSQ0j5 vCkg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 85-20020a630058000000b0037c52dd0ea9si129110pga.724.2022.03.02.13.11.32; Wed, 02 Mar 2022 13:11:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237717AbiCBHVk (ORCPT + 99 others); Wed, 2 Mar 2022 02:21:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232279AbiCBHVi (ORCPT ); Wed, 2 Mar 2022 02:21:38 -0500 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 97120396A3; Tue, 1 Mar 2022 23:20:54 -0800 (PST) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id A735D1C0B81; Wed, 2 Mar 2022 08:20:52 +0100 (CET) Date: Wed, 2 Mar 2022 08:20:48 +0100 From: Pavel Machek To: Jiapeng Chong Cc: rafael@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH] block: Fix non-kernel-doc comment Message-ID: <20220302072047.GA32222@amd> References: <20220214091522.100669-1-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20220214091522.100669-1-jiapeng.chong@linux.alibaba.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Fixes the following W=3D1 kernel build warning: >=20 > kernel/power/swap.c:120: warning: This comment starts with '/**', but > isn't a kernel-doc comment. Refer > Documentation/doc-guide/kernel-doc.rst. > +++ b/kernel/power/swap.c > @@ -170,7 +170,7 @@ static int swsusp_extents_insert(unsigned long swap_o= ffset) > return 0; > } > =20 > -/** > +/* > * alloc_swapdev_block - allocate a swap page and register that it has > * been allocated, so that it can be freed in case of an error. > */ The ones before look ok, but this and next one perhaps should be converted to kerneldoc? BR, Pavel --=20 http://www.livejournal.com/~pavelmachek --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfGs8ACgkQMOfwapXb+vIRVQCfYc6BXODZ81bQacVSDH+toteq XskAoJ19XIxZrFIUblSPdzx7s658llkz =3Htv -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--