Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <671a6137-0d45-3a8c-433a-32448019961f@amd.com>
Date:   Wed, 2 Mar 2022 08:25:45 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Cc:     brijesh.singh@amd.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
        linux-coco@lists.linux.dev, linux-mm@kvack.org,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Joerg Roedel <jroedel@suse.de>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>, Ard Biesheuvel <ardb@kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Jim Mattson <jmattson@google.com>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Sergio Lopez <slp@redhat.com>, Peter Gonda <pgonda@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        David Rientjes <rientjes@google.com>,
        Dov Murik <dovmurik@linux.ibm.com>,
        Tobin Feldman-Fitzthum <tobin@ibm.com>,
        Michael Roth <michael.roth@amd.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Andi Kleen <ak@linux.intel.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        brijesh.ksingh@gmail.com, tony.luck@intel.com, marcorr@google.com,
        sathyanarayanan.kuppuswamy@linux.intel.com
Subject: Re: [PATCH v11 29/45] x86/boot: Add Confidential Computing type to
 setup_data
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
References: <20220224165625.2175020-1-brijesh.singh@amd.com>
 <20220224165625.2175020-30-brijesh.singh@amd.com>
 <Yh3r1PSx/fjqoBB3@nazgul.tnic>
From:   Brijesh Singh <brijesh.singh@amd.com>
In-Reply-To: <Yh3r1PSx/fjqoBB3@nazgul.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z1NGeTRLMHRDV29yb1RLTVVzK0JmbjE4UW9kVjNnZjFDVXUxRzBoTXczc0Ji?=
 =?utf-8?B?dDM4OTVsbks1bzhXS2ZGMmEwOVRkbE5LZWpGZGZkUWUrQWNrTlhkaXFNbEpm?=
 =?utf-8?B?YXlST0I4bU8wSkJZbzlLeU9iU2hZa0RoNVlUUzZ3Q2hlRFdmTUREK1hJUlVU?=
 =?utf-8?B?Z1V2eCtzN2hTcnFnQUttVWltQS9IOTFoa3ZiWXoyMXhJd1M5Z21ZSEYvd09I?=
 =?utf-8?B?N0UwdkpaMjdHMkUrWTJhZDkvdVlHaHQvWlBrNlErS3VqRmIxV2tMUERMVDgy?=
 =?utf-8?B?ZTNxZDJtc1hYeDFXWFdYcW9YQ3Nsalh4ZUtPRHN4cm93SnlldWZQY1htNlhM?=
 =?utf-8?B?VG16Ylk4OTlkKzVJcHJBQ3RxMFd2aFFnTnVkeEZlaDRkczd1TW0rbGdPMWdo?=
 =?utf-8?B?UWFaSGkwOHVyMlNCNDlwaCt5SThYd0szcUhkWmM4TUE5RmNCWnh5YWtjUVZD?=
 =?utf-8?B?dlZySnVFdDhQNkRnakF0cXRMUmt5a1VydUZYa05LUFVUQ3RKd2VoWWwvQ0ow?=
 =?utf-8?B?SDFmVnoyQm0rYnZRVENSZ0tidk10bENFZUgyZzY4WDVqRVJoYkg4NVJTOHg2?=
 =?utf-8?B?b0NGaWo4R2RJZ09jZmhmaDRCTnZxVzlHQ1VVTklzRjVJYjBZNVVsTmdsSnJi?=
 =?utf-8?B?QUFwRElFdTNEbEpMUllQS1JKclp3Q0xWRzFxcml1N0lOcmxLYW9pVW8wcVVl?=
 =?utf-8?B?Q0JjNEgyZWJFNHdxUXpjMWl3RWc5WWh1SWZ3WEwyRElqcUMrWEc4OFFRWnZR?=
 =?utf-8?B?L3hjcHZRQklTVStaY0E2QzlLWnMwRitrZEhGVklVdHdPYmVRcGFCczZKbjlv?=
 =?utf-8?B?TEpBeTNsTDA4bHBQUy9Ua3g3cFNoRXlhZWJaNHAvemFJUm83c2RPK1E2NEh5?=
 =?utf-8?B?b3Y4SlRrVVZvMXJlamZqMzQzVXMydXpTUW81SWpwT2RJMjVDR1BwY1VSNVV0?=
 =?utf-8?B?MzlabzRIdTdzTC8xUlQzQ2hVQU1zcFdOOWJFaG1uV1laSnZrRzBHOEM3VFNS?=
 =?utf-8?B?TDVVSU1CcUVGWnFuTU5uMTNpMTZhbEM2M01jSERGTGhiSU0rbDZweDkybFNE?=
 =?utf-8?B?aUVXaDFWQ24vSkhyaUhLL1k5TVY1WkVRNWZoaGlYZ3ZhcmI5OVRkelIvT3I1?=
 =?utf-8?B?Z2dxZXlXZWJPY295N2JtUDBxeDhDcWtFazBMaUNrYUJPSUd0TlVoYlFPOVI2?=
 =?utf-8?B?TmZuSi9QcDRrRjRhZUhnRjFDeVl3MnZTKzNSQ1hEYWFyQ2xGbXhhdDRHWmRq?=
 =?utf-8?B?aW5CNSt6Qy9WemxtRDYwNEhtTjluRG1USVVPWTdyYXQvdkMxdnhmaGRrQnFp?=
 =?utf-8?B?dVJabW1vL3YvdnBmbjhVelJxaXM5d0NTSkdEdTkwRjIyK0JvUmQwWStwcE1n?=
 =?utf-8?B?UFlKQm1MUTEvQTNJam5UTm9PZ1RHQXFuR2JUNCtVY1poa2pEaGp5UHAvUzZY?=
 =?utf-8?B?VjdneEdyN3dSbElURk5mWXh0cEZ6eHNGa2FBeWlOVFFPRk9LR2hEcXYvRFZ6?=
 =?utf-8?B?V25vV2NhRzNSSmdnUGxPQ2tjRi9mZFkxQzFXallpWUtBZHJQZVlnWDFtdGxH?=
 =?utf-8?B?eWFXQk9EQkxIMERBcVM0UFJCS1BpY3Y5bU9PaTBmdmlsNlFzUDJubEhjOVNx?=
 =?utf-8?B?RWdPeHlFWFFzdWNFTTJwKzZvSnRhQkRQWmFJb0xDT2lZKzkrbVExWkJYM3pP?=
 =?utf-8?B?b3FXa05MNE4wRDIvWjk1MThHMnpSMUdJdHpEeTFyS1RQTExFWTMxZFJkeG11?=
 =?utf-8?B?Q080dzNuQjRSSVk4NE9CNk0wMXgrS09keUhCbGg2ak9RcWxYT2IwYkI5VVVY?=
 =?utf-8?B?TW5HVmJKRWhFZzM3MlF1djhJU3dVLzR6Qzc5YnRqeEhRU2NLMkRlbm5xNmc0?=
 =?utf-8?B?R1pwYUM2TVlWVTVic09oeUFZalpLekUybWdSaWNVWktoLzZUYWIvdlBINCtD?=
 =?utf-8?B?K0ZTRlY1V0l0SklKd0IxdmVsMjZxNkdqd3Zha2VENG0zZFNteTlVTXVKdExW?=
 =?utf-8?B?Qk9xWUhRRXIwNXcvKytIT3plV0F2M2g0aENmU1NldnNaYVpMWi9TOXkxTlV0?=
 =?utf-8?B?SFlaUlQ1MjJ4QmF2ZmNPUmxHNFJLVTNxUHpFL25tSVE5UldXdTBqbEMyS1Zr?=
 =?utf-8?B?eGRibmI1WE1vYkxHd29GSXhaam1TeDNFMkhvZUQzeWZsWWlZYkRxbGtxUUJR?=
 =?utf-8?Q?Md9nYpE6BRGimIly4awDLqY=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba290aa7-c338-4baa-5505-08d9fc588d50
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 14:25:51.1090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xCTs8McSHR8txq9SL/OjR0n0PnzM50UrHpX9NtlvBXDCnwETp6emiqtVSYpwWYXMlI7cVWbIjS6iUgzyDkl0mA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5482
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/1/22 03:48, Borislav Petkov wrote:
> On Thu, Feb 24, 2022 at 10:56:09AM -0600, Brijesh Singh wrote:
>> +/*
>> + * AMD SEV Confidential computing blob structure. The structure is
>> + * defined in OVMF UEFI firmware header:
>> + * https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FOvmfPkg%2FInclude%2FGuid%2FConfidentialComputingSevSnpBlob.h&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C72edb78e27f546ef783b08d9fb689fe6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637817249053086231%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=9rP%2FF18D4bR3Cku%2FIcXV0qJvC336y54sqYYkq9RAdAE%3D&amp;reserved=0
>> + */
>> +#define CC_BLOB_SEV_HDR_MAGIC	0x45444d41
>> +struct cc_blob_sev_info {
>> +	u32 magic;
> 	^^^^^^^^^^^^
> 
> You said you wanted to rename this:
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fall%2F12b945a0-b18c-7f2a-52c7-5e22a944d7f5%40amd.com%2F&amp;data=04%7C01%7Cbrijesh.singh%40amd.com%7C72edb78e27f546ef783b08d9fb689fe6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637817249053086231%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=biu1Pdk%2BO%2FIVaF5iE47aInOqGF36uAAVx%2BTSBLBxC9w%3D&amp;reserved=0
> 
> and further code is checking magic so I'm guessing you wanna rename the
> OVMF definition to "Magic" too?
> 

Yep, I am waiting for Linux patches to finalize and then sync OVMF with 
it. I will rename the field to magic in OVMF to keep both of them in sync.

-Brijesh