Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Vasily Gorbik <gor@linux.ibm.com>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Heiko Carstens <hca@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>
Subject: Re: [PATCH v6 08/71] Maple Tree: Add new data structure
Thread-Topic: [PATCH v6 08/71] Maple Tree: Add new data structure
Thread-Index: AQHYInpU/hKtaWQ3X0yDuzeh55NMz6ymqQwAgAJzKICAAL9NAIABOHaAgAAktgCAAQA8AA==
Date:   Wed, 2 Mar 2022 14:08:06 +0000
Message-ID: <20220302140725.4yxcedu35dswxjzu@revolver>
References: <20220215143728.3810954-1-Liam.Howlett@oracle.com>
 <20220215144241.3812052-1-Liam.Howlett@oracle.com>
 <20220215144241.3812052-8-Liam.Howlett@oracle.com>
 <your-ad-here.call-01645924312-ext-0398@work.hours>
 <20220228143633.r4zoemgtmrq4uzvb@revolver>
 <your-ad-here.call-01646100074-ext-8278@work.hours>
 <20220301203935.r74qjc7p6qbno4xw@revolver>
 <your-ad-here.call-01646175058-ext-9349@work.hours>
In-Reply-To: <your-ad-here.call-01646175058-ext-9349@work.hours>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3yFGcfyy1IPLjdpadaPtIKb6IEy4B04QXbakk8BAZjEG1Vq2XYrmKuFTLBZL?=
 =?us-ascii?Q?j8NtnYnt6ZR85O5RUD7clWVvDzsicm+9nlAIE7AaDQla6NXiIKOy7Db8E7Fs?=
 =?us-ascii?Q?Z5VMwBaEqTU+S3cV8j8mZN74pLeYxNRvOuLS5D7iP6giUMySMwuKRLL1bt/A?=
 =?us-ascii?Q?Wo3SNsNqV2Ce7AfmvNTsxhSb8xRk+FCCaHFYb/id9S8xJdw/L18nNEqt/jgX?=
 =?us-ascii?Q?VonW1iq4w9m7KjvOXl23K+B8r5BykKoP1zlD3Epz6KIIyi70UoSYzTqzYDGB?=
 =?us-ascii?Q?vM9aZCbdPDGiHR7JYglVIRaWx0seL+mysc9oQSgUidFGVCbKa4TpfFbrv08w?=
 =?us-ascii?Q?+gyUJBQTLks50AZhTi2PO8o/xGqoGEewtnYZfCu+KLtrzwanaP4oF8R+D//F?=
 =?us-ascii?Q?h+rMcX7HQYWBIH/886HQdHTtxFSzGo3ZecEhtKZEhgXDzWMdMXifIeGDf6fJ?=
 =?us-ascii?Q?/rEw+aGvXrGClvPRbYsM4eM7tiAnCOm8ZXxCwY82UICEC+lA6Q4WlKe+yx30?=
 =?us-ascii?Q?TQm9MBqpoBcFI6RckTlGBZDPdS7wr4Ziibd/Y1FUcU3LE2VI94cBzZPrhmbE?=
 =?us-ascii?Q?xBJzo37kk4nGYbJI2Mx65t6eneRssJnMcKYwYa+5OBPOOFpe0U+TCOQpdgUA?=
 =?us-ascii?Q?Zfu5a7ao5GqNjZbNkqBpi4P+2DyPiegFaWCqu0/TbKqK93GvfFlmzRgptDri?=
 =?us-ascii?Q?ebMNGU0NaOr7RkdekYaJfxh/j36S8dwetwRMmQeROhoBR+y6katLbu/Bxj0P?=
 =?us-ascii?Q?dyKq+W3HdG7oo+YZGDtPdqVGqvBEg2ExrMrVA+Vm2uVeZBTK6hjytKTuN6hN?=
 =?us-ascii?Q?4BKjRLQsGFtq1QU3bBSMykm/EKC4Zpy5bePnjJszeNaRDGf5gpog3gg5l2XP?=
 =?us-ascii?Q?rbdrNbzqydJxtQNqev/woJM1pUQIPdopnpEaEGHzLEVg6AwAeUzthBaktHXF?=
 =?us-ascii?Q?p+Y6PukU7cKyYOCeUkAm8gzMG75xn72PWK33FK6V4Wryt1M4m2nQxTllUde4?=
 =?us-ascii?Q?EqE/yzprMWT1qHR6VRpFscfhYd1YlePnFSaAR3tXHPW6IY5WXP3gIMoE+WXJ?=
 =?us-ascii?Q?oveMW5WDLgXDVRgaZMqW438XT5vNyxr+ZiyMrbXp+SgMSRA43E3f4nFcZL9L?=
 =?us-ascii?Q?QmMx+PYOOVw9yVgDm/TwAh9uUqhQbSxJuZ/xE7HzYP81D8Npoza4L00OeTpj?=
 =?us-ascii?Q?kZ5wgD/ElCQRq/aVIrPKbO/RzKQgw+tzmDeVYR5RWdbfa0vNX0qiR54kTDma?=
 =?us-ascii?Q?ui4HdhmKjysU5axR/iI4vypweHgL44P98J6szKWk6ayCySUGstpXLygDXDOc?=
 =?us-ascii?Q?o93HHz6OpCtPVz3YBD45kmFZFmg5iJdrKD7cFW4SJyG6MX/9x9Idae3MBA2m?=
 =?us-ascii?Q?MgAML7GrdFMBYs/g9b8rHliyyjaNc7fxJs5JMCwsJmMDWFC4LpJw2kydZnbV?=
 =?us-ascii?Q?R3ncIxfpRq3VQl8VLwmozYaLF1t1CusGv6i5MXrvyWF9cG+JuKKDZB5MGWws?=
 =?us-ascii?Q?PXAooyxue8gcgQCAqFd7c2WOZwquD3OhzViXGFyX7ZyLoGCOCT5udShmypO+?=
 =?us-ascii?Q?anTtLywfvV4bRhr8+3EzfpWa5F9kn+lZIDpsWVlpl5mA7tUo9WIlhzcnwWGM?=
 =?us-ascii?Q?cOTCyvwrw2h9k6sliqz+Vmg=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <95B40A9984349E4681D528368CB69D75@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0901b850-5172-4f5e-c266-08d9fc561312
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Mar 2022 14:08:06.6238
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: at7tzbUrqz/cEliTeZPAsnl8bIzrPCiGUa2gwXFmMwfcUqWtS4RFi4KFyBNhbIS2PGWD1esdF2fHQSw9/geO4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4948
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 phishscore=0
 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203020061
X-Proofpoint-GUID: w6isX6pyppS3AQ8bE1inHXW6p3C0nNuq
X-Proofpoint-ORIG-GUID: w6isX6pyppS3AQ8bE1inHXW6p3C0nNuq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Vasily Gorbik <gor@linux.ibm.com> [220301 17:51]:
> On Tue, Mar 01, 2022 at 08:39:44PM +0000, Liam Howlett wrote:
> > * Vasily Gorbik <gor@linux.ibm.com> [220228 21:01]:
> > > This condition is not present in mas_dead_leaves() where we potential=
ly
> > > iterate over all 16 slots, simply checking that we have a "valid" nod=
e pointer
> > > with:
> > >=20
> > > entry & ~MAPLE_NODE_MASK !=3D 0
> >=20
> > I have fixed this and another issue that Hugh pointed out [1].  I have
> > been working on an s390 VM since you reported your issue and have been
> > getting strange behaviour and have been able to detect the bug reported
> > by Hugh with the config KASAN option.  With the fix I described above
> > and fixing the do_mas_align_munmap() splitting order I broken in my
> > linked list removal, I am now able to boot my s390 VM and log in with
> > KASAN, VM debug, maple tree debug, rbtree debug, debug page flags, and
> > Poison pages after freeing all set in the config I use.  I've pushed th=
e
> > fix to a tag on my branch [2] and I'd appreciate it if you could test i=
t
> > on your side.
>=20
> Great, I gave it a spin and it looks much better now! I'll go run some st=
ress
> tests.
>=20
> BTW, since you've made efforts to isolate mapple tests in userspace I
> wonder how much sense it would make to use libfuzzer to give API some goo=
d
> coverage-guided exercise.
>=20
> I've written a minimal libfuzzer test (just a hack) for the "Normal API" =
and got
> couple of flavours of crashes. Just rebased onto your latest branch state
> and still get them. Please have a look if those are valid findings.


Thanks!  Yes, the first one is certainly a valid bug.  I was able to
reproduce it and fix the issue in my tree.  I'll have a look and see
what else it throws out.

Cheers,
Liam=