Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 13:14:01 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     "Dr. David Alan Gilbert" <linux@treblig.org>
Cc:     dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        jeremy.fitzhardinge@citrix.com, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/mm: Use strtobool for noexec parsing
Message-ID: <Yh9ffhD3809qieua@nazgul.tnic>
References: <20220227201356.241452-1-linux@treblig.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20220227201356.241452-1-linux@treblig.org>
Precedence: bulk

On Sun, Feb 27, 2022 at 08:13:56PM +0000, Dr. David Alan Gilbert wrote:
> Use strtobool to parse the 'noexec' parameter rather than open coding
> it.
> 'disable_nx' is changed to a bool and flipped to 'enable_nx'
> so it's meaning follows the command line option.
> 
> There's no change in behaviour for noexec=on/off.
> noexec=junk will now warn
> strtobool allows 0/1 and y/n (etc) as well as the on/off.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  arch/x86/mm/setup_nx.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)

https://lkml.kernel.org/r/20220127115626.14179-6-bp@alien8.de

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette