Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 2 Mar 2022 15:00:36 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     linux-kernel@vger.kernel.org, dietmar.eggemann@arm.com,
        rafael@kernel.org, daniel.lezcano@linaro.org, nm@ti.com,
        sboyd@kernel.org, mka@chromium.org, dianders@chromium.org,
        robh+dt@kernel.org, devicetree@vger.kernel.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 3/4] OPP: Add support of "opp-microwatt" for advanced
 EM registration
Message-ID: <20220302093036.qanm3vxuajinzbwb@vireshk-i7>
References: <20220301093524.8870-1-lukasz.luba@arm.com>
 <20220301093524.8870-4-lukasz.luba@arm.com>
 <20220302074515.dqzoutfiobildiph@vireshk-i7>
 <e02d9113-d1ae-c029-750f-aece1cefab2d@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e02d9113-d1ae-c029-750f-aece1cefab2d@arm.com>
User-Agent: NeoMutt/20180716-391-311a52
Precedence: bulk

On 02-03-22, 08:50, Lukasz Luba wrote:
> If you like, I can introduce new dual-macro implementation
> in energy_modle.h which would sole this issue:
> 
> ifdef EM:
> #define EM_SET_ACTIVE_POWER_CB(em_cb, cb) ((em_cb).active_power = cb)
> 
> ifndef EM:
> #define EM_SET_ACTIVE_POWER_CB(em_cb, cb) do { } while (0)
> 
> 
> Then we would keep the single call to the registration EM and
> we would have:
> 
>         if (_of_has_opp_microwatt_property(dev)) {
>                 EM_SET_ACTIVE_POWER_CB(em_cb, _get_dt_power);
>                 goto register_em;
>         }
> 
> 
> 	
>         EM_SET_ACTIVE_POWER_CB(em_cb, _get_power);
> 
> register_em:
>         ret = em_dev_register_perf_domain(dev, nr_opp, &em_cb, cpus, true);
> 
> 
> I can do that, please let me know.

That will work as well.

-- 
viresh