Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Valentin Schneider <valentin.schneider@arm.com>
To:     cgel.zte@gmail.com, mingo@redhat.com
Cc:     juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org,
        Lv Ruyi <lv.ruyi@zte.com.cn>, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] sched/topology: avoid calling synchronize_rcu()
In-Reply-To: <20220302011433.2054613-1-lv.ruyi@zte.com.cn>
References: <20220302011433.2054613-1-lv.ruyi@zte.com.cn>
Date:   Wed, 02 Mar 2022 14:19:55 +0000
Message-ID: <87mti84et0.mognet@arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 02/03/22 01:14, cgel.zte@gmail.com wrote:
> From: Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
>
> Kfree_rcu() usually results in even simpler code than does
> synchronize_rcu() without synchronize_rcu()'s multi-millisecond
> latency, so replace synchronize_rcu() with kfree_rcu().
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi (CGEL ZTE) <lv.ruyi@zte.com.cn>
> ---
>  kernel/sched/topology.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
> index 974212620fa1..0ce302b4d732 100644
> --- a/kernel/sched/topology.c
> +++ b/kernel/sched/topology.c
> @@ -1970,8 +1970,7 @@ static void sched_reset_numa(void)
>       if (distances || masks) {
>               int i, j;
>
> -		synchronize_rcu();
> -		kfree(distances);
> +		kfree_rcu(distances);

What about the freeing of the cpumasks below? You don't want to free those
before the end of the grace period either. With that in mind, I think the
current synchronize_rcu() + batch of kfree()'s is fine, it's a slow path
anyway (hotplug).


>               for (i = 0; i < nr_levels && masks; i++) {
>                       if (!masks[i])
>                               continue;
> --
> 2.25.1