Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp247923pxm; Wed, 2 Mar 2022 14:32:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJzrMRRVz8HVR3F3ZMIWaH9lJIaxelb3q86wCWJFpu5ftfk68e0+UsNOl59Fs+gtFMzfoSB3 X-Received: by 2002:a05:6a00:230f:b0:4f4:13a9:9a53 with SMTP id h15-20020a056a00230f00b004f413a99a53mr17681164pfh.11.1646260329016; Wed, 02 Mar 2022 14:32:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646260329; cv=none; d=google.com; s=arc-20160816; b=zOAn4VEUfFyHQ+7B+87r/HKOvmlwWuJRmvUXuL19AKyXNhwoOKz8CXZ5J1+tTKHSaN kkPzXHC2MEz6uawlTF4NAmsn8xzyJNerRYTf98cTgix2hWlTV6HZ3PJn2xlRm+lAAwEe B7SEk/MZsmEgLoUymkzU8HhT6N5qCS7n+Uo69D88UuFMxlT9fKkb43/Hm4yp3ZNCS0/z uSestTbHLUu3bRRes47geD2Q0QntR9EgypdaVrbU/ONWeofIBiibFKppVMsEaknNmlkW QI/P2EflH8snF/ArWBqxR15lGfLmYABVORRgFwPIacRV7TTQ7yHVyzofgz/+dlUqklnh nPrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=+SuWPZ2e/7zeEhPWaoi9jelX8WbYRm2ComoX27Rv4U4=; b=MrSn9wlcBF255WETLKWSxJ/gfwP667JwO9TcLaNGn8J6OmnlXhQXQnxu3MpSaejNyV fFYvfSn6OOM35f0BewYLIFI0Lk8mb+rHyNkntYTDS8e+2A0fJX+sHPEo9ashqmyDkfju MRjs6pC0ZrdPbr7sDzjXnMoUQ3Bz5KNeQv7V3FqwUl17n7LmztHabXxYmCXr09jwC0Cr IoNc+SUvN/aSkFq56KZJYOEwMHPqwzUznuX5FefN1W/OnnLa3WXd3MAK6DxAn5m3c2nt 0ijF4G8VUSqEXzDJLvaxji7pcL3rct/SDBxJOQF3p0o4863/0/uEeaw5Pft56K0PoGez /6gw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=UKsy+0FX; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id f12-20020a17090a654c00b001b9a07daa7dsi6437668pjs.61.2022.03.02.14.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 14:32:09 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=UKsy+0FX; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 51B60EB174; Wed, 2 Mar 2022 14:30:56 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245052AbiCBVKN (ORCPT + 99 others); Wed, 2 Mar 2022 16:10:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240887AbiCBVKK (ORCPT ); Wed, 2 Mar 2022 16:10:10 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B5F6EB34 for ; Wed, 2 Mar 2022 13:09:23 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id ay10so4729478wrb.6 for ; Wed, 02 Mar 2022 13:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+SuWPZ2e/7zeEhPWaoi9jelX8WbYRm2ComoX27Rv4U4=; b=UKsy+0FXcuJ8Do65rOR9YbcsdUErJHZHS65EmTolGTe9BMmpHY619TGTyBALKgJSQV /i1o2tyB9QPtreYoRnIMoLZbDG5n0xaQdAS9OuAhsn8YYqeCNQXP7+VjbkJdmFP66N1B z8yQfrvD57bI9vn9nkGNVFzb3IJcIPmS4qZbw4d1GxTNx9FIRRuvvcp/20Bi1hUcPcXq 1hERbZ3B8OhnuXlZidtmDufDMZ/s0ECxo6n3cVUnCFhP16ENoYDKdc0fgbCEviNgkzHa B1gumXaSx6XNweFhIzz6O6zFFm5tpE7+FudcurirFwo8fw6q/vXR8emE33TcuIBitk/1 1u4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+SuWPZ2e/7zeEhPWaoi9jelX8WbYRm2ComoX27Rv4U4=; b=z48KFX3KTX0EF3baqH/XCPyjIPuF8Q5KXBWVbzrImqS8n+eSXWramHUTfHx57yqjri H64j8NnDKGPOK6MlCSqbUtSXxLU7lS8ralXnmpmYluVu9ZbDB4yKfaB+jByjtMru91jo Ft7QMN4zMlW04yy97lpqp0fH1iMdRXv3vcjTB/8iz1XMBeGx0nu6wJszIiXIQzE82jk2 3hK/5OAnYSVOzIodI64ywRUEcPK/b+DPgHiPT9mKl27mWz1ST4z511YL/F5KH7E4gKjI kjB49JrYik1voVJMpe1hJjvuLSYJInPFENR/StAV4Vq03lfHxEWvDf0W9fIPQXDO6j7g ZIYA== X-Gm-Message-State: AOAM532MA/H7ye8j9lnJQTaa1fp/OL/TWz53qBK8kGLxrjpfNM81jezn F+a+ShRPzfJGsTh3BbIkdT3YMw== X-Received: by 2002:a05:6000:50a:b0:1e3:5af:153e with SMTP id a10-20020a056000050a00b001e305af153emr24268852wrf.385.1646255362131; Wed, 02 Mar 2022 13:09:22 -0800 (PST) Received: from Red ([2a01:cb1d:3d5:a100:264b:feff:fe03:2806]) by smtp.googlemail.com with ESMTPSA id j27-20020adfd21b000000b001e519f3e0d0sm118605wrh.7.2022.03.02.13.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 13:09:21 -0800 (PST) Date: Wed, 2 Mar 2022 22:09:19 +0100 From: LABBE Corentin To: John Keeping Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski@canonical.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/16] crypto: rockchip: rework by using crypto_engine Message-ID: References: <20220228194037.1600509-1-clabbe@baylibre.com> <20220228194037.1600509-11-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le Tue, Mar 01, 2022 at 12:57:16PM +0000, John Keeping a ?crit : > On Mon, Feb 28, 2022 at 07:40:31PM +0000, Corentin Labbe wrote: > > Instead of doing manual queue management, let's use the crypto/engine > > for that. > > In the same time, rework the requests handling to be easier to > > understand (and fix all bugs related to them). > > > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > > Signed-off-by: Corentin Labbe > > --- > > In addition to the warnings reported by the kernel test robot, this > needs to add select CRYPTO_ENGINE to Kconfig for the Rockchip driver. > Hello Thanks for the report, I will fix this in v2 Thanks