Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Subject: Re: [PATCH net-next v4 1/4] skbuff: introduce kfree_skb_list_reason()
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     netdev@vger.kernel.org, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org, davem@davemloft.net,
        rostedt@goodmis.org, mingo@redhat.com, ast@kernel.org,
        daniel@iogearbox.net, andrii@kernel.org, imagedong@tencent.com,
        joao.m.martins@oracle.com, joe.jin@oracle.com, dsahern@gmail.com,
        edumazet@google.com
References: <20220226084929.6417-1-dongli.zhang@oracle.com>
 <20220226084929.6417-2-dongli.zhang@oracle.com>
 <20220301183454.4813d022@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
From:   Dongli Zhang <dongli.zhang@oracle.com>
Message-ID: <1bce4d36-8032-d6c9-541c-858a38ba2596@oracle.com>
Date:   Wed, 2 Mar 2022 08:49:39 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
In-Reply-To: <20220301183454.4813d022@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3BqUjFXS2RoUnNHdzFkdFRpVmVjUjk2TzVyWllkOUFhRVpWeDlrUnYzSFhQ?=
 =?utf-8?B?Rnd1MEVDbHI1WFc0VjdPdWIwTXFzazBhaEhoNWVFZXBiSSt0QnFPNWMxR2JK?=
 =?utf-8?B?WWNaRmoxWGZDRVY4SWp2VEQwS1JGWXNNVFcwMU8raVdqc0V0azRHa2lPVHly?=
 =?utf-8?B?ekhhUzArNDJCSkM1VEVsN3ZDbTFHZXJrRlNzTHlLM1drajZHYXkrVjVnZjRR?=
 =?utf-8?B?OEg4eFJrbVJhc1lCeVlaVE13QnkwZzlZOHYzTDVNWk4zNm8zdUMyTGY2S2dr?=
 =?utf-8?B?WlREZ29KemcyUTVJaFdVUkdIOS9GcFk0MTRTSHdaNkRCbHZJcXZxV2c3ZGJ4?=
 =?utf-8?B?ejhraHZSZjZvYW5ZZFBaMlJOcEovY0pRbVl1VXlUKzZLdDZjUnhwTksyT3dC?=
 =?utf-8?B?aVdWRldNcWN6T0hSWk0yOHdDWHVUbm95eHg5RWdmbDIzNHM2OWpCWG0xMFFW?=
 =?utf-8?B?QzNYREtvNEN3L2FUWll3bzZPaGltNUdmSmxtTlp0OXNEYlJQVFUzM3dNOHRy?=
 =?utf-8?B?eEx6RS9JSU0yaDE0eWlBcHZaVGlqZHpkbGFXQ2RVNjQwZnRYMzBBZi9ESXZY?=
 =?utf-8?B?NytTdTRQcUdhMWluSUkvNTFrNnkzRjUwTUpnZXpuTWM3eGJpdkZOWmtrbXV5?=
 =?utf-8?B?cHVDdkd0ejJHNzR0elh5UUlObXdDMHhRNS9abytnL2N3TkxvalJpak1xUU5H?=
 =?utf-8?B?NUpTYnNQamJvUEF4QjRaME1tc0grTE93amt5cXlOakNONHZMYlNYeXJEVEZX?=
 =?utf-8?B?bHQwalVjSkZmVUpMYWMxY1NsdTd0Nkh2bkl1SktUZGt2ZTJRcWRmS0FJVEdR?=
 =?utf-8?B?RXBNOTk3MCsrWXczcUxQRFRZUGJWNFRBeXh4WVVTZVczenpJVEhJOHhMQks3?=
 =?utf-8?B?a1FmNXRlQkcrOElJWlNWRDR5UXhDNlJKeG16WXRSRTFsNmt6bnpSZ1ZlUzFR?=
 =?utf-8?B?N1VSV3lxSTltcmNsbEhmdCthaUpicFpXRVE1V2p0aVNtQm5jSVhiQjFOU2tI?=
 =?utf-8?B?VnEyamprY0l6ay9FSnh6dGZKdW1NaFZKOVBFYXZETi8vSUxpelZwcEYrVG44?=
 =?utf-8?B?bXpEMXNsL0ZLUjdPUmU0ZU45UnRhNFJFNUFDbUUvang5OW4zSG9OdGw1dkR1?=
 =?utf-8?B?aWJLZmJRd1pXaUpwRjdGSzd3Y0pHVHpXUjlZR1BWMXptSmE3eFRGblJpblhj?=
 =?utf-8?B?am1tK2Z1NGdnNkt4aXdBSk1KZHZJVDBQOExTcG8yOG9KWHBQb3ZWMlRWMkV4?=
 =?utf-8?B?ZmtCUGtxbGIvS1Y4V2J0eXZtTTNKdTkyb0FOWW1lejhJSUxId3h3K2txNjRh?=
 =?utf-8?B?SGRSR2lqM1FGNHdKb05DeW1iOG9JZGhoaXBSaXA0eFFFVmVjRktKNnZtN2U3?=
 =?utf-8?B?WFdKaCtjeWRGMEJZSjV3TzVIS1VueUZIcm9nOUhiUlRRbmpjNkNsbTdJUFRV?=
 =?utf-8?B?blZ3ZTZJWUxzdkJuT1lpMW5CdEFtdktsTVhPRGtUNnZ4YkZFUUZxMVBIRVF4?=
 =?utf-8?B?V1NNaFJ5MURkUCtFWTVTMXMxamtZdGtaTXYzS3A4QWV2NEkxWlRiMFhLQWxK?=
 =?utf-8?B?c1ZtRHNOUTAxcFI5Q2Uzc1RqTFQ2VlpDdG5vazh3dFZDeURiZmZaWmNCODJ0?=
 =?utf-8?B?NmhQd2JwaVh1RFlvVE1TVUNiVDB1V29WWU55R01zbjdkam1VL1pFZEtnemth?=
 =?utf-8?B?bjVFM01ZNEVxazVISUJOcEZ4R2tyTmdBNHZCRTNwSVNyWkVIWThrcXAweGM4?=
 =?utf-8?B?cHJCYnJWQ3VXZkROTC9hbnZEWTczM2txeE45eFlackZJOFFRbW5ndkZuTnJO?=
 =?utf-8?B?d0JyV2U0eUlPektUeDJIUzdaUWVtcVdHdVVOVzNmYy90VUpOV2E0cWN3dE5s?=
 =?utf-8?B?NldpSFNIMGRkdisxZnN0QTIya2ZnQ2RlU1J2TjZacHl5c25XOUgrUU9NdGFM?=
 =?utf-8?B?elVsOFBMSDkxZ3hXWHhzUk1IUTJQUUMxekNoT2NFY2xUNmRvZ3hoSjRKdjAy?=
 =?utf-8?B?eXNaV3B5MGVwSTNYLyszZDd1cUxZS00ySDlFc1crbmQyMVAvRDE1anZRNjM5?=
 =?utf-8?B?eXo2NzBPMmlueUxQdlBVR0lWRUtZd29sWnhHUFlmNWZiWGl5Uy9yUTlFYWQ1?=
 =?utf-8?B?ZFVhc0Y0ajE1VGR4aTh2ZGFReTNZbEZrSGt5NUt1ZmEzb0xHbzBTYVRQRWdY?=
 =?utf-8?B?YXpTb1FKdUNBbUFMVjJoMUZ1U3B1NWpuSWxxUzJ3QzJzKzRvcjFNTUI2RFdo?=
 =?utf-8?B?NFJPVzRtMFR4T1VCVXorZFpxdFlnPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 48b5ff91-0310-4818-baf0-08d9fc6ca68e
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 16:49:43.2237
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DHmQiEWo+JIy3sykWB5udJDVoaW0+YME3dRIzgPO1GeHqkwdd7yWbeAmt9lULpxrVxGKW6jtBx1T0sOQXgLhUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1490
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203020074
X-Proofpoint-GUID: vI1SzAyaYZQmjNhUmFJKorPcXis668bn
X-Proofpoint-ORIG-GUID: vI1SzAyaYZQmjNhUmFJKorPcXis668bn
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jakub,

On 3/1/22 6:34 PM, Jakub Kicinski wrote:
> On Sat, 26 Feb 2022 00:49:26 -0800 Dongli Zhang wrote:
>> +void kfree_skb_list(struct sk_buff *segs)
>> +{
>> +	kfree_skb_list_reason(segs, SKB_DROP_REASON_NOT_SPECIFIED);
>> +}
>>  EXPORT_SYMBOL(kfree_skb_list);
> 
> Why not make it a static inline now, like we did with kfree_skb()?
> 

I will move kfree_skb_list() to include/linux/skbuff.h as static inline.

Thank you very much!

Dongli Zhang