Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp257268pxm; Wed, 2 Mar 2022 14:45:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmjasQqvPKNq9+5K5b7AJHKhBqKDuuNTpFoDgEJfn9BiOt2j67YUu447JIADp4fZu0qmKK X-Received: by 2002:a17:902:d509:b0:151:8a0c:a4b7 with SMTP id b9-20020a170902d50900b001518a0ca4b7mr9177407plg.35.1646261155829; Wed, 02 Mar 2022 14:45:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646261155; cv=none; d=google.com; s=arc-20160816; b=mPCQP/HhkPA1xqw25+Dpd9Z4jzGrNPCGXG6KGFYpJMnNP3sVAAX8oNsoXgNCGQPuLY eCBm3QcBkciukw9Hph1GlxHkPrXq2JyQCpkoqnYUDtbYegmpu3vvOf3+jhYkLJSAyi0t 0Uvb/j66TTZN0lXsWwkfpLxIGF5HNyMNc9FpZo1hzY7dbcvUkxihX7OjkgDcL76vsdmu w47LhAGg+gp0F48RKbcO0+S3NQ7riJasbZ/KNGI/h0ljdn112dhtU8A8kYNRwxynPpFZ 7EPzyY+PB2mQPfJc1oAUVhhfs+TXI3S0wQROP8E15rjlKNZWDetXVsVG0JdjVJAijcWR osMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vND+8UfEWFuB/8Wf4RxD9j4E+zzduSos9T+rvekrZP0=; b=H0GIl40soQUwiylq7k/Ko8j6xbx2j8Xjxyho/VXV9qqOOsP2HCxS5I72IIebXp4Uqi R4v9Bv/2FCHkMutnp2Zr4wqWWZx7zX4yHMHQuZK7zcvxyOz57I8GMP7eynN0YUx/6a/v a+z/zOwDxPSp04osaf3hcUsmerN2AuKWQHrM/+lYWMfyZxzPaEG3KkUnqx45L2wRhEkr lqxUzQLQXbAdGEI0B2XNFWlutEe9JgosVyk47bUYFTXM+drIHuKvAlQD4tfXbrBsXipc xFc+TaGutn43HJLMaxhEJVX3SXLCKuCarb+xhpK1Dix0Usgt7R9w5ZW7Dly+AglSdo8A GP2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZZRuRYb4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id hi21-20020a17090b30d500b001bc7dee85e4si6065459pjb.96.2022.03.02.14.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 14:45:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZZRuRYb4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E646E6E346; Wed, 2 Mar 2022 14:38:08 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243338AbiCBPAo (ORCPT + 99 others); Wed, 2 Mar 2022 10:00:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232994AbiCBPAk (ORCPT ); Wed, 2 Mar 2022 10:00:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD815CA0C9; Wed, 2 Mar 2022 06:59:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7A6FBB81FF0; Wed, 2 Mar 2022 14:59:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2209C004E1; Wed, 2 Mar 2022 14:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1646233195; bh=Jhsap+PkSgxDrt7pvTl2cBBZSrc2xf7495eMI/c4pZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZZRuRYb4AQIGNWUjBDgwaf1uy24hGJgFGcQd9sPZuA9SOJ+aVj008dpXBEq8VFOHL VXXfihl8rhy+MXireYBoGEXgR8N681Zuqguu53kLuD7XturTcLA22ZRKLW+nMNe3B9 UjgEssVfMVkj4GdncAQhBbf0hJQ1WtQrI1zDWxJ8= Date: Wed, 2 Mar 2022 15:59:52 +0100 From: Greg KH To: "Starke, Daniel" Cc: "linux-serial@vger.kernel.org" , "jirislaby@kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [RFC 1/1] tty: n_gsm: improve standard compliance and feature completeness Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 02:47:20PM +0000, Starke, Daniel wrote: > Thank you for this quick response. > > > I'm sorry, but there is nothing we can do with such a large patch here at > > all. > > > > Please break this up into "one logical change per patch" and we will be > > glad to review it. > > You are absolutely right but this is still work in progress. The attached > patch was only for reference for all those who would like to look at the > changes in detail or try out the proposed work. This was not a request for > code review yet. Also, it seems that the patch was too large for the > linux-serial mailing list so I have uploaded it here for reference: > https://github.com/siemens/linux/tree/dstarke-siemens/n_gsm_rfc You need to provide a set of patches for people to review. Random code dumps and random github links are impossible to review cleanly, would you want to to so? thanks, greg k-h