Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Thu, 3 Mar 2022 00:35:01 +0530
From:   Kuldeep Singh <singh.kuldeep87k@gmail.com>
To:     Robin Murphy <robin.murphy@arm.com>
Cc:     Mark Brown <broonie@kernel.org>,
        linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property
 in pl022
Message-ID: <20220302190501.GA2168@9a2d8922b8f1>
References: <20220228124345.99474-1-singh.kuldeep87k@gmail.com>
 <20220228124345.99474-4-singh.kuldeep87k@gmail.com>
 <f22e9ddc-3103-2785-5504-fcc95d08cc8b@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f22e9ddc-3103-2785-5504-fcc95d08cc8b@arm.com>
Precedence: bulk

On Mon, Feb 28, 2022 at 02:36:23PM +0000, Robin Murphy wrote:
> On 2022-02-28 12:43, Kuldeep Singh wrote:
> > Fix below dtc warning by making necessary addition of "spiclk" in
> > clock-names property.
> > 
> > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@190000:
> > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
> >      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
> > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@66190000:
> > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
> >      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
> 
> As before, what makes the binding at fault rather than that DT? The PL022's
> actual input is named SSPCLK, not SPICLK, so why should a driver which wants
> to look up that clock by name expect to look for "spiclk"?
 
That's right. It's the DT which is at the fault of defining spiclk
instead of sspclk and need to be fixed in DT itself. I didn't take a
look at pl022 doc and acted on the basis of DT info.

Moreover, DT also uses sspclk and SSPCLK names interchangeably which are
anyway same. This also require updation to follow single convention.

Appreciate your comments and valuable inputs.

-- 
Best Regards
Kuldeep