Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp264512pxm; Wed, 2 Mar 2022 14:57:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJxY3406rTbjIJp/o0aYMBeatBCJ2ur4+X0ZFcakov/YM7owGWCVpK+SV1AwXxYKCUBRXOB/ X-Received: by 2002:a17:903:2c7:b0:14f:fc47:5a2f with SMTP id s7-20020a17090302c700b0014ffc475a2fmr33156761plk.112.1646261829388; Wed, 02 Mar 2022 14:57:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646261829; cv=none; d=google.com; s=arc-20160816; b=T3oPnlb1lj861KQSHBd/U4xwn90Ive88jUJSL9vr/ZwZWrrO0pQJuntcjaJKBuGQL8 +2pQ/u+SigEiHu7jxzOd9aoICQMMMFUn/YtKFWK5F+AJdq4SwH2GqNyjij5CcAoeKh9i lKFML9Z7vCu8IFcl9z0nj2MVtY/MJFGUdZJ6/gzyIbsZB1GPgVu/Ds02U4jNbIJniUOj w+SHT7QRmpMricFQdTGF7wtnyYHSm7huVTLRq0uwn8dqJMxtbEjS99B0hVZBNhIKFFWE 4NFHV2SdTYPBjmrFLNelL2IYQR+fzX3+qLL0OkGa4vw4jac3qJni0NFTh/q/pNc/+dq1 zxNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; b=AyPfpvFMCHytvkoSOxVDBlWZCGmDjtZmIopSaAgZo3oJXimKXvXogqPFgJNsCq28tT 78CVAMrOiTZT5QkO0wspgyVZTVwjE85RuuWe2JlRLH3xbRhXpYaXXJFsgPWJwadMi9cN qOzeYAXP/DeYjnhRWToyLLtb26K9UvGL9gsMH9/7hxoYOVEKMYLr75EYHkzim6YoYxwu YnskHIhMWq3LiEd/ADiVVtkMTtnGnhvTNDGahwy139w4GphQr0DuqJ76OF1R880+5irD MLBAFJFYeNb4fFy9PdgWsRSIoexMvthwLNFtl0Wjm24ZyqJDATQl/jYgpL7Yhg3y+72A RSLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Otl600XW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id f7-20020a170902ce8700b0015134d06714si353935plg.1.2022.03.02.14.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 14:57:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Otl600XW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A06601160EB; Wed, 2 Mar 2022 14:43:57 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241179AbiCBLCT (ORCPT + 99 others); Wed, 2 Mar 2022 06:02:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241177AbiCBLCL (ORCPT ); Wed, 2 Mar 2022 06:02:11 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FACB6E793 for ; Wed, 2 Mar 2022 03:01:28 -0800 (PST) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 8F5533F5F7 for ; Wed, 2 Mar 2022 11:01:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646218883; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Otl600XWsN7VkMsCgZY6G3LVJR59D4DTJ9IdTj7JHfJfF2knbcQD2GVOlGdswAqty 0rJHBIdZNMj4rXg8PeEhwf6YF58puLckZ+qvM0I0YSls8Uv0epO2xr6IcTroEZTq7g PmRRGuHZHOv3rIL3Xy+jH1yqSZcMXCFiD0rOhI/Y/4FTlFhnJSLfYt2cAdCMzetEom y41TlUus1bCL7VJSOOlGqt4PqN4dTpKHGOkq7xcWxYZqEzFINJE4Lzi2pBz1L/64n2 o2sIM8YZo8HnRYKjIiiP90kKfxXHrBbjvIMxZ4MwIiZtZpY/PeeS7Hb5zo6GD8+ZhL fabjnJAUklNEA== Received: by mail-ed1-f70.google.com with SMTP id x22-20020a05640226d600b0041380e16645so796553edd.8 for ; Wed, 02 Mar 2022 03:01:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Si9sQ7yLz6JK6Nen6lACTBVX2ecHMiwS0ByLXYRxjJA=; b=czUphPm+ENYtK0k96WRKL4zBc8H7lT8P63UODyAH8YEqA78EXzX6AIwOPpkOgAVD2T CJG9O/t7/qmVREx/MIsTB4jHyWGwkig1ZUv4QoXinQqAXXmdaK9ahe51/lVxtRq9JxV/ dsfFdDJCqmhcxRuAL5TFQwVISqUwORpmS9AXV3oV2c5lxnYUJFzhN1+lAwfPskQ9sgkI 4wdwPFuNDvcqYikxh1dkiEC/rNy4Q8zaboFZZYFVYE/uqu7KhlSzBbbApVCoDPMksE9/ WPZCFSunXSXpgZmqhplEXBC+wKz8m0p9lbOAcvoS/+q6rBXg4X1FLxRTtE7TZoS+ylIR lG1w== X-Gm-Message-State: AOAM5339UtswdAJrud2x55i8WM3F7Mz9/Yme3pM5FBYqtSYCI7ztfMO3 02n5wAo1+QPqDbcGMV0+odIgApGY5u+h+YJoyWfFj9ENs3JD7pAv6O7ghb0LxxmnOdoJOwDlj7Y 8IKgf2Uy3vlaFevpUyGK9SPoZorgHDmNFcXoxMTeYZw== X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935772edb.163.1646218881645; Wed, 02 Mar 2022 03:01:21 -0800 (PST) X-Received: by 2002:a05:6402:369a:b0:413:81b5:7b64 with SMTP id ej26-20020a056402369a00b0041381b57b64mr22935729edb.163.1646218881424; Wed, 02 Mar 2022 03:01:21 -0800 (PST) Received: from [192.168.0.136] (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id et3-20020a170907294300b006d6534ef273sm5617821ejc.156.2022.03.02.03.01.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Mar 2022 03:01:20 -0800 (PST) Message-ID: <22099da9-fad0-a5fb-f45a-484635ca485f@canonical.com> Date: Wed, 2 Mar 2022 12:01:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 06/11] s390: cio: Use driver_set_override() instead of open-coding Content-Language: en-US To: Vineeth Vijayan , Greg Kroah-Hartman , "Rafael J. Wysocki" , Stuart Yoder , Laurentiu Tudor , Abel Vesa , Shawn Guo , Sascha Hauer , Fabio Estevam , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , Srinivas Kandagatla , Mark Brown , "Michael S. Tsirkin" , Jason Wang , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds Cc: Rasmus Villemoes References: <20220227135214.145599-1-krzysztof.kozlowski@canonical.com> <20220227135214.145599-7-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/2022 17:01, Vineeth Vijayan wrote: > > On 2/27/22 14:52, Krzysztof Kozlowski wrote: >> Use a helper for seting driver_override to reduce amount of duplicated >> code. Make the driver_override field const char, because it is not >> modified by the core and it matches other subsystems. > s/seting/setting/ > > Also could you please change the title to start with "s390/cio:" > instead of "s390 : cio" > Sure, thanks for review! Best regards, Krzysztof