Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp264887pxm; Wed, 2 Mar 2022 14:57:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3gDiE3tQLujD9syGRi51fFMR3RU7NeXPJnT1NvhjdYPhvNskPNq2Ux6S//8Hmy2N9Qqfw X-Received: by 2002:a63:2b05:0:b0:37c:43ce:1cdc with SMTP id r5-20020a632b05000000b0037c43ce1cdcmr2717796pgr.584.1646261863881; Wed, 02 Mar 2022 14:57:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646261863; cv=none; d=google.com; s=arc-20160816; b=BLkdkOBv7zFhqNnqysU82Wgki8BZ9DJ7c7j3dfsPY0LRr/iE/DYre0rLJmTNT4wNs8 wvP3ZZ1AOx7WZ4MjjRYRmEdmLwjFyE044ZUDcgH/GXtaq/ZIZPy8Uyya7c3nplgwBAdp vlgV1bQTDXMmtj6VGLhpRrocQYLWHWWy2lr40em+RxKBhtmGbaBumP5cI2TPWvI9z687 MSF8q+orIQE5kGlb4v79AdGAdSt0bmLHOCIaMB8TNuGYBoAL0KtRYbtrPHOvoU8zWqlu FICWN84LtjBRWc+8DVFCc1+WP2znUCmxAHcR3fv9jfkiLJGzkndOX29zNNtVddM6ZSXq vYrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=yRTE0dXDieeLqipRcJqUM5emUc5L/qHhnbBmseJ0BJU=; b=YB7akhh5eDiQ6aBy/HAEzwtLV6CoNvjhq5f6PKM/hbt6y3sAMhgaJL10zFvf33ePcc uDQ6RhmFt6ucIZjPDw082aqSd8/6fiV6MpI4z7RonryczCgdEhTjcMTYg5nBn1ckk3Xo HoKV1J9r55YLxiVlVYKxShCOv7kIqpSPnONSbZOSyigfEKsI/AWSQAZrnb0Zw/+H5Ku8 g8PjwpLBuZWuTWkIn+5vXZfUQq+ca9IbF4heQHGsChnCwe0Dms+HGCONu9dCLIM0/Mk9 Y1zuwDgSS8U6RABhxSR7M0l9F1jmA+0t+jn+Y+Ls+AdJMwkU3HeBTZ+wJWS/JhuONul2 hPjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Jv2Rtizd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 144-20020a630396000000b00372cb185217si332387pgd.537.2022.03.02.14.57.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 14:57:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=Jv2Rtizd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BEFAE11984A; Wed, 2 Mar 2022 14:44:14 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232549AbiCBT0M (ORCPT + 99 others); Wed, 2 Mar 2022 14:26:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235617AbiCBT0M (ORCPT ); Wed, 2 Mar 2022 14:26:12 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77756C1176 for ; Wed, 2 Mar 2022 11:25:28 -0800 (PST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4FA453F5F2 for ; Wed, 2 Mar 2022 19:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646249127; bh=yRTE0dXDieeLqipRcJqUM5emUc5L/qHhnbBmseJ0BJU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Jv2RtizdGwinP2qfowNk4Ywy1N3i4Q4KpqSWNcUHHCciU02rQOh9NRJcy8qabHJbu qxG2x5iyQ3gMWu/hbhRHljUJihGRtXzGqU5ZAunqmi712EbU+QrAkVL0Oh2PhVwtcK nlEbUkjk1aHXjgzU7rLDsNAVATum8MPAX6jJnfDl410OrIJ0tECM1CF2OvtvA8GGi4 2cgL/nNnH814updnzNUpNqf/bFFMvcoj7gx0ngvb0CbXcY+hVXfwHC8TUtVzFRuSIo uS08M5U2JeamZcKlj7zOtu79Hn+Bbo8fd5KipX7N1g5I3Wn82EViIZMLYFNBeWlrrn PZPsvqiaNOqaQ== Received: by mail-ej1-f72.google.com with SMTP id hc39-20020a17090716a700b006ce88cf89dfso1490834ejc.10 for ; Wed, 02 Mar 2022 11:25:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=yRTE0dXDieeLqipRcJqUM5emUc5L/qHhnbBmseJ0BJU=; b=z0LzWrEFniyuv7T7FojL4MgLERY2xea3tUiE1jlTMqv3FTGM+85GSB+RH1FfUxpWhy 00divoY6KjlRw2sC/vW9P+bF1d0Zh+fREvyiRjZYzbPPpRnMmLZdYiSK0t5W1UMJnG4R kvrbFiFSO6i00l3sSkRdkqnqrN41wq7kbO0qWoCXxEe3SM9IacG3x9RY/HRwCI+NDZ6w 3qK9kfBjq7H3Ul44Ly8H0dK41/mQGrUflQE923DvHSxJJsGpAirTCkfVb3YzYmLF0cgJ 7fq8dM2S1o+N+K3/ueAqC2+keIdWo1HKmQBlaon8a+FdBWzD9ockSKj8b2J0Cu2CTJfY UGfA== X-Gm-Message-State: AOAM530Y0VgE9hKSWVu8UXNDi/anV4VsbCoroUISdzwvOmMsaBDVpIbh wBaVGny+vInTFzTwI4GzyGypQ6NwVEH6vC5SVDCKqV0D/nimeYilhKUUpN9q4KJweXEpw63s229 kPZDaU5N3nB4uTGaYRm6g3Rq9y3+w19ZZ2/LnBgGhiQ== X-Received: by 2002:a17:906:d964:b0:6ca:4019:3928 with SMTP id rp4-20020a170906d96400b006ca40193928mr24495907ejb.762.1646249127009; Wed, 02 Mar 2022 11:25:27 -0800 (PST) X-Received: by 2002:a17:906:d964:b0:6ca:4019:3928 with SMTP id rp4-20020a170906d96400b006ca40193928mr24495893ejb.762.1646249126792; Wed, 02 Mar 2022 11:25:26 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id i14-20020a50cfce000000b00415b0730921sm1482765edk.42.2022.03.02.11.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 11:25:26 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH v2 0/6] nfc: llcp: few cleanups/improvements Date: Wed, 2 Mar 2022 20:25:17 +0100 Message-Id: <20220302192523.57444-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, These are improvements, not fixing any experienced issue, just looking correct to me from the code point of view. Changes since v1 ================ 1. Split from the fix. Testing ======= Under QEMU only. The NFC/LLCP code was not really tested on a device. Best regards, Krzysztof Krzysztof Kozlowski (6): nfc: llcp: nullify llcp_sock->dev on connect() error paths nfc: llcp: simplify llcp_sock_connect() error paths nfc: llcp: use centralized exiting of bind on errors nfc: llcp: use test_bit() nfc: llcp: protect nfc_llcp_sock_unlink() calls nfc: llcp: Revert "NFC: Keep socket alive until the DISC PDU is actually sent" net/nfc/llcp.h | 1 - net/nfc/llcp_core.c | 9 +-------- net/nfc/llcp_sock.c | 49 ++++++++++++++++++++++----------------------- 3 files changed, 25 insertions(+), 34 deletions(-) -- 2.32.0