Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp274659pxm; Wed, 2 Mar 2022 15:10:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtaQLu8P2tN/LV6ffMGZJnibS2YLZfMA0IGascbwlivq61zzeFNlWzG7HUzR9gdbLpwiE6 X-Received: by 2002:a63:445c:0:b0:375:9c0c:c360 with SMTP id t28-20020a63445c000000b003759c0cc360mr26315544pgk.588.1646262602632; Wed, 02 Mar 2022 15:10:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646262602; cv=none; d=google.com; s=arc-20160816; b=kKgS+B7fhqL2UDfxcYC1+yrbegu6sQLTNX+0rxrqw9DBHq4aPf5Al/MYl7tHgsB5i0 BqUXn3EthNuzRROaj6iFXlPz8X5GK7cbjIAJm1sAb4Ar7GPMHOgPgNpfxNp0vF/23KQs jvdI8i5qeErECrcGrqKPa6I5SAMtKL+oDyK3QAlAf+O1wxn6cxp3oNk+YjFXXObXogvK AIO2q7NqEe9LhEMb3dIXZimBoal9RrFwptL4Lkhv1lRB1QTw9c2Sx+cKP8JJOriSVrCZ s04s3s4HcLAciNoJqaSFcivrvh8mtWs5DK0P++m22o73qATYaYuV0GLXwTqgCOVqR+s/ yWbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=DXsL/G5uXnPDFc9uVI+Aqwd0DVzLE/kN3IO6RMfxO8o=; b=PaTeGOiYl5o9Z8Ts4m3nTjp6mcAdSkrpkoCujybrZbpZI7aSzRtM6T6jaFM9HROfSL hJ82gHsSvtj99nXd3EI+3B9MyvQHdA+w6qo+g5uYKIB+hml/ZPa7g2smkl/aY/YEN0Pp BedFHkbqi4dDUA4GxgFFVeKwsEMlIRRuAhg4uJKC/dJNdwO+vrccyaOHBVUGMfQrmAxh /L6RO5qzM25sUkXLwCqqszB5mAxIzLpZT9OiCCbXsLGhy/jLODkO4H9a9qKQv+loguFt K60cIpXuk8aPnNGuZ3nqpS/MWNpPvc2jsybcPbpEflIRh+7n3h06eCr4zLHR4uagtkma RsKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=3Ydj+1cm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=RiBIkiN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id 15-20020a630c4f000000b00373bd8029b8si358769pgm.394.2022.03.02.15.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 15:10:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=3Ydj+1cm; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=RiBIkiN3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9B4E1FFF96; Wed, 2 Mar 2022 14:50:43 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245326AbiCBVgX (ORCPT + 99 others); Wed, 2 Mar 2022 16:36:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245319AbiCBVgV (ORCPT ); Wed, 2 Mar 2022 16:36:21 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3285552E53; Wed, 2 Mar 2022 13:35:38 -0800 (PST) Date: Wed, 02 Mar 2022 21:35:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1646256935; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXsL/G5uXnPDFc9uVI+Aqwd0DVzLE/kN3IO6RMfxO8o=; b=3Ydj+1cm67cQGbRhuYHgT2kmAbXoYbyp5IS/upAT4s8N5xJNQDnVHW+0BEvcsgOn2vYiEY amhvS+DVbyT9VN6/uzxsmJWhrFJn2VIaHtO4fDA8m0c2TB7LIxFFP2XuKUsVZuWlBRcnSY dGN9KRri68t8dfixukURZFNYZmrPMf4MrIC76sWTxc9kEqOPizUTN0v2uqn0LRgfUz+0Ht FiFGr9WNUaYursxPwIJDNDE0oRHdXTN8EKegxulCCp2zsvJ4tfiPcrOVrn7nVuSfa5SPSy q66TtRm9/dxtuZvY8SStrrWyM8pVdUx8OSxLDt/IWya5GLVU+n2tuJOBMLOlTQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1646256935; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DXsL/G5uXnPDFc9uVI+Aqwd0DVzLE/kN3IO6RMfxO8o=; b=RiBIkiN38VbGQ4UApQDMwxS4YGocltJcyfdVtXr+YDmQ+m0vPWO5ZLtpPhyJ84It6lzG2p tmVgGiQfa1BAurBw== From: "tip-bot2 for Sebastian Andrzej Siewior" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-tip-commits@vger.kernel.org Subject: [tip: irq/core] net: usb: lan78xx: Use generic_handle_irq_safe(). Cc: Sebastian Andrzej Siewior , Thomas Gleixner , Woojung Huh , "David S. Miller" , Jakub Kicinski , UNGLinuxDriver@microchip.com, x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org In-Reply-To: <20220211181500.1856198-7-bigeasy@linutronix.de> References: <20220211181500.1856198-7-bigeasy@linutronix.de> MIME-Version: 1.0 Message-ID: <164625693477.16921.927635503299605010.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/core branch of tip: Commit-ID: bfe6b967948c251955bcf175cb2d4e8d169102ca Gitweb: https://git.kernel.org/tip/bfe6b967948c251955bcf175cb2d4e8d169102ca Author: Sebastian Andrzej Siewior AuthorDate: Fri, 11 Feb 2022 19:14:59 +01:00 Committer: Thomas Gleixner CommitterDate: Wed, 02 Mar 2022 22:28:50 +01:00 net: usb: lan78xx: Use generic_handle_irq_safe(). Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Woojung Huh Cc: "David S. Miller" Cc: Jakub Kicinski Cc: UNGLinuxDriver@microchip.com Link: https://lore.kernel.org/r/20220211181500.1856198-7-bigeasy@linutronix.de --- drivers/net/usb/lan78xx.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index b8e20a3..415f166 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -1537,11 +1537,8 @@ static void lan78xx_status(struct lan78xx_net *dev, struct urb *urb) netif_dbg(dev, link, dev->net, "PHY INTR: 0x%08x\n", intdata); lan78xx_defer_kevent(dev, EVENT_LINK_RESET); - if (dev->domain_data.phyirq > 0) { - local_irq_disable(); - generic_handle_irq(dev->domain_data.phyirq); - local_irq_enable(); - } + if (dev->domain_data.phyirq > 0) + generic_handle_irq_safe(dev->domain_data.phyirq); } else { netdev_warn(dev->net, "unexpected interrupt: 0x%08x\n", intdata);