Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp275435pxm; Wed, 2 Mar 2022 15:11:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjiiDyxPeJGUIeyIWajPZ/G3kp1cNWZxcAYiIX8Un6lTDG3ceh/W4EH1Ls/FuNnQg7EYkn X-Received: by 2002:a05:6a00:1a8b:b0:4e1:e24b:88a8 with SMTP id e11-20020a056a001a8b00b004e1e24b88a8mr35105144pfv.80.1646262663581; Wed, 02 Mar 2022 15:11:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646262663; cv=none; d=google.com; s=arc-20160816; b=FiggmdPIinWQQceh9fULPchijS4WLQ8UJjwdrRz60wFWP9kn8sp9p3jcv0+7xiJ8A6 6luZhtHB+QBP4XX/uj08P7fTL80w6o5UqhYC/a3+v+fDnOfXaeBnCvD/mex8MMSs3TyH 0zqFl1wP3btryOCaMHOxoMxSTcXdWlBdWOguegoRH6Y7W8yAFhlud5U1C6FGYEcPl1Lc OK45YOm7qhS9AhCDwdrYSA3t8mUdNMgEyRZw/Qbl5Gipdu2rsrsIrChsNWIvIX6L7vNd 9W++F4+h+0ciZ4yHHry7vVIuoNxfVAIf3mh+ft+oY6vJuZfW2/094OYotpG8zK1Oa0Sk U1Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vBbzqL5wzXDyYewKK9YMLC34hfMZMISsP5DKji4BCmA=; b=EoxSuO9e2B/Ecc8fgbKYwf08ujV8ABd57J1hpOrDbNIxaUy4YyuyopG99EI/odoh/7 q4gRpFHy0dOIM297938JIBBHBcD78CFbfvf07W93G0wUrq2dTx3s/HvIPGtzLZstd3o1 0o38gSiA0G/ub5QWlizF6x8ZBB4Mjk5IYnKOjdmY+CrV6eLCyJcvu9df0wkkH2KLxFcK 8ANQNpvOUCSGyJJ2nPM8/7U8C/dYqgIrx9w4xXUpSQevSj4AaaOk5X7Lwv2iaxMrGYbB r9owR5Bk4A78F/GnLwq9qRo6Iu88Esp5Zi7PoM+TS10LNfadSFhlRgs0xW0WVtAl2eyY eFcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RusE2PCg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id y8-20020a056a00180800b004ce1abe2187si419292pfa.330.2022.03.02.15.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 15:11:03 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=RusE2PCg; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 677CE12BF69; Wed, 2 Mar 2022 14:51:38 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243040AbiCBWFT (ORCPT + 99 others); Wed, 2 Mar 2022 17:05:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238838AbiCBWFS (ORCPT ); Wed, 2 Mar 2022 17:05:18 -0500 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A23CDC992D; Wed, 2 Mar 2022 14:04:34 -0800 (PST) Received: by mail-pf1-x436.google.com with SMTP id u16so3081038pfg.12; Wed, 02 Mar 2022 14:04:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vBbzqL5wzXDyYewKK9YMLC34hfMZMISsP5DKji4BCmA=; b=RusE2PCgcFMfdKKim3gWHJLEn0607dTkVampVLsN1xn9JkifVakSEZTZ4Fh+iJqm4T FoyEwSCoemDQDoEkLVvfiYETQXXn1I2d0mKG/futFc2g8P5EZDHmncUZex3ff7VH8IRi tJoui5HpHjfqVlj9zlKpTRTF58kQoBd1rqujKbKgNGYo92y1wnhxOVHZfLzBTBuESso3 bz4wQrMQ1TkSOZU6sReOVKiuoTeu8oC1pUwoYn1kKiremw8PhZ0PEp2NQRXstNLOi0DK aH3l5OYhubb7SjTGZhXCP1bdSDO0Pnz9rPALQgNapYJXhP+RXbpjCpn89oqWQLx8JgiB Vwew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vBbzqL5wzXDyYewKK9YMLC34hfMZMISsP5DKji4BCmA=; b=FZIQtEKQwZnnAP10o9WHGlwYAW9WOYiCgw6Z5/mUnl6iDoRJsRUMcD+5pnmTCpP/kF VzwxUhrByW5s+cCw4sNr4fjbPhlEls7URkPHrLBAW9yx9rEhq25qyJTmysl5pnVtPqr3 ksREFP3fKjJq194WConehnIKYAndPHZVYdtNyXwjsHcqFvJZUBZaD9GACG+IhAm5OAqH WACkHQsAtPA1SK1WYqX/9zcu7dGWd8IIvpKBU8BJj3X0GZt/5fZ4aArDeXXSmcL4Kbay ZqxsSwuqw2t9dGsFuy//b4U7fwGocXq/t/JGA8jeqjegQWYtyyBkfv/nlOuRbd8J66O0 HJZA== X-Gm-Message-State: AOAM533pY2lRfssbFaZz0xTRtI3VaKsyWYEto19Uvc/R5b4uZLEhnpK0 CGt7mHuxJhplF8qNvxXoBE8= X-Received: by 2002:a63:5d0a:0:b0:377:1ad7:5be1 with SMTP id r10-20020a635d0a000000b003771ad75be1mr23721319pgb.576.1646258673997; Wed, 02 Mar 2022 14:04:33 -0800 (PST) Received: from google.com ([2620:15c:202:201:f1fc:2949:1f18:b6ff]) by smtp.gmail.com with ESMTPSA id k7-20020a6555c7000000b0034e101ca75csm130304pgs.6.2022.03.02.14.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 14:04:33 -0800 (PST) Date: Wed, 2 Mar 2022 14:04:30 -0800 From: Dmitry Torokhov To: William Mahon Cc: LKML , William Mahon , Benjamin Tissoires , Jiri Kosina , linux-input@vger.kernel.org Subject: Re: [PATCH v3] HID: Add mapping for KEY_DICTATE Message-ID: References: <20220218215531.1.I5dbf50eb1a7a6734ee727bda4a8573358c6d3ec0@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220218215531.1.I5dbf50eb1a7a6734ee727bda4a8573358c6d3ec0@changeid> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi William, On Fri, Feb 18, 2022 at 09:59:08PM +0000, William Mahon wrote: > Numerous keyboards are adding dictate keys which allows for text > messages to be dictated by a microphone. > > This patch adds a new key definition KEY_DICTATE and maps 0x0c/0x0d8 > usage code to this new keycode. Additionally hid-debug is adjusted to > recognize this new usage code as well. > > Signed-off-by: William Mahon Was about to apply but scripts are complaining about difference between from and signed-of-by addresses. Could you please make them match? Thanks. -- Dmitry