Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <a549f23857b327131c621dbc9a029a91401967c8.camel@trillion01.com>
Subject: Re: [PATCH v4 2/2] io_uring: Add support for napi_busy_poll
From:   Olivier Langlois <olivier@trillion01.com>
To:     Hao Xu <haoxu@linux.alibaba.com>, Jens Axboe <axboe@kernel.dk>,
        Pavel Begunkov <asml.silence@gmail.com>
Cc:     io-uring <io-uring@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Date:   Wed, 02 Mar 2022 17:03:58 -0500
In-Reply-To: <81a915d3-cf5f-a884-4649-704a5cf26835@linux.alibaba.com>
References: <cover.1646142288.git.olivier@trillion01.com>
         <aa38a667ef28cce54c08212fdfa1e2b3747ad3ec.1646142288.git.olivier@trillion01.com>
         <29bad95d-06f8-ea7c-29fe-81e52823c90a@linux.alibaba.com>
         <4f01857ca757ab4f0995420e6b1a6e3668a40da5.camel@trillion01.com>
         <4af380e8-796b-2dd6-4ebc-e40e7fa51ce1@linux.alibaba.com>
         <81a915d3-cf5f-a884-4649-704a5cf26835@linux.alibaba.com>
Organization: Trillion01 Inc
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.42.4 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 2022-03-02 at 14:38 +0800, Hao Xu wrote:
> > > 
> > > 
> > > If that is what you suggest, what would this info do for the
> > > caller?
> > > 
> > > IMHO, it wouldn't help in any way...
> > 
> > Hmm, I'm not sure, you're probably right based on that ENOMEM here 
> > shouldn't
> > 
> > fail the arm poll, but we wanna do it, we can do something like
> > what 
> > we do for
> ???????????????????????????? ^---but if we wanna do it
My position is that being able to perform busy poll is a nice to have
feature if the necessary resources are available. If not the request
will still be handled correctly so nothing special should be done in
case of mem alloc problem.

but fair enough, lets wait for Jens and Pavel to chime him if they
would like to see something to be done here.

Beside that, all I need to know is if napi_list needs to be protected
in __io_sq_thread with regards to io worket threads to start working on
a v5.

I'll look into this question too...