Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 2 Mar 2022 12:59:22 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Iouri Tarassov <iourit@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, spronovo@microsoft.com,
        spronovo@linux.microsoft.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 08/30] drivers: hv: dxgkrnl: Creation of dxgcontext
 objects
Message-ID: <20220302125922.xigz7wg6w2y7rufp@liuwe-devbox-debian-v2>
References: <719fe06b7cbe9ac12fa4a729e810e3383ab421c1.1646163378.git.iourit@linux.microsoft.com>
 <aabd5033766fe4751a5042e7a8c3ce82c2e83c17.1646163378.git.iourit@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aabd5033766fe4751a5042e7a8c3ce82c2e83c17.1646163378.git.iourit@linux.microsoft.com>
Precedence: bulk

On Tue, Mar 01, 2022 at 11:45:55AM -0800, Iouri Tarassov wrote:
[...]
> +static int
> +dxgk_create_context_virtual(struct dxgprocess *process, void *__user inargs)
> +{
> +	struct d3dkmt_createcontextvirtual args;
> +	int ret;
> +	struct dxgadapter *adapter = NULL;
> +	struct dxgdevice *device = NULL;
> +	struct dxgcontext *context = NULL;
> +	struct d3dkmthandle host_context_handle = {};
> +	bool device_lock_acquired = false;
> +
> +	pr_debug("ioctl: %s", __func__);
> +
> +	ret = copy_from_user(&args, inargs, sizeof(args));
> +	if (ret) {
> +		pr_err("%s failed to copy input args", __func__);
> +		ret = -EINVAL;

This should be -EFAULT. This goes for other copy_from_user calls too. You can also
drop the pr_err above.

Thanks,
Wei.