Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <d67e43a5-a654-e622-bab8-d2f55a7013f3@csgroup.eu>
Date:   Wed, 2 Mar 2022 17:23:38 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [Reoprt] Some compile warning on ppc dts
Content-Language: fr-FR
To:     "chenjun (AM)" <chenjun102@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        Rob Herring <robh+dt@kernel.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc:     "Xiangrui (Euler)" <rui.xiang@huawei.com>
References: <CE1E7D7EFA066443B6454A6A5063B50220CCBBE4@dggeml509-mbx.china.huawei.com>
From:   Christophe Leroy <christophe.leroy@csgroup.eu>
In-Reply-To: <CE1E7D7EFA066443B6454A6A5063B50220CCBBE4@dggeml509-mbx.china.huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Le 01/03/2021 à 03:16, chenjun (AM) a écrit :
> Hi
> 
> After run the following commands
> make distclean
> make allmodconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make oldconfig ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> make -j64 ARCH=powerpc CROSS_COMPILE=powerpc64-linux-gnu-
> 
> I get some warning:
> arch/powerpc/boot/dts/mpc5200b.dtsi:267.20-280.4: Warning (pci_bridge):
> /pci@f0000d00: missing ranges for PCI bridg
> e (or not a bridge)
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (pci_device_bus_num): Failed
> prerequisite 'pci_bridge'
> arch/powerpc/boot/dts/mpc5200b.dtsi:182.18-186.5: Warning
> (spi_bus_bridge): /soc5200@f0000000/psc@2000: node name f
> or SPI buses should be 'spi'
>     also defined at arch/powerpc/boot/dts/o2d.dtsi:32.12-43.5
> arch/powerpc/boot/dts/o2dnt2.dtb: Warning (spi_bus_reg): Failed
> prerequisite 'spi_bus_bridge'
> ...
> 
> For the problem about "node name for SPI buses should be 'spi'":
> Rename the psc@2000 to spi@2000 in arch/powerpc/boot/dts/o2d.dtsi can
> fix it.
> diff --git a/arch/powerpc/boot/dts/o2d.dtsi b/arch/powerpc/boot/dts/o2d.dtsi
> index 6661955a2be4..cd3dc70cd72e 100644
> --- a/arch/powerpc/boot/dts/o2d.dtsi
> +++ b/arch/powerpc/boot/dts/o2d.dtsi
> @@ -29,7 +29,7 @@ rtc@800 {
>    >------>------->-------status = "disabled";
>    >------>-------};
> -
> ->------>-------psc@2000 {>----->-------// PSC1
> +>------>-------spi@2000 {>----->-------// PSC1
>    >------>------->-------compatible =
> "fsl,mpc5200b-psc-spi","fsl,mpc5200-psc-spi";
>    >------>------->-------#address-cells = <1>;
>    >------>------->-------#size-cells = <0>;
> ---
> 
> For the problem about "missing ranges for PCI bridge (or not a bridge)":
> Ranges should be add in arch/powerpc/boot/dts/mpc5200b.dtsi.
>   >-------pci: pci@f0000d00 {
>   >------->-------#interrupt-cells = <1>;
>   >------->-------#size-cells = <2>;
>   >------->-------#address-cells = <3>;
>   >------->-------device_type = "pci";
>   >------->-------compatible = "fsl,mpc5200b-pci","fsl,mpc5200-pci";
>   >------->-------reg = <0xf0000d00 0x100>;
>   >------->-------// interrupt-map-mask = need to add
>   >------->-------// interrupt-map = need to add
>   >------->-------clock-frequency = <0>; // From boot loader
>   >------->-------interrupts = <2 8 0 2 9 0 2 10 0>;
>   >------->-------bus-range = <0 0>;
>   >------->-------// ranges = need to add
>   >-------};
> I think the ranges should be add by someone who knows the mpc5200 better.
> 


This patch has garbage instead of tabs, it doesn't apply