Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp297002pxm; Wed, 2 Mar 2022 15:44:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3Y0VeLkeUhcHBb+MjJPj/XJcPnsClQ3FTPcptS3W+2paz9uS2S5jfiagrH9u5jldBDrS5 X-Received: by 2002:a17:90b:4c4c:b0:1be:ebe8:c81b with SMTP id np12-20020a17090b4c4c00b001beebe8c81bmr2291204pjb.88.1646264685230; Wed, 02 Mar 2022 15:44:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646264685; cv=none; d=google.com; s=arc-20160816; b=YbMV8acTrT3O4y+BkBCUogG4Gn0dO76DN2WIX3CFZom6XsLloEgUlia0apfyESXZU+ 0c+PZ7hy3zUJHwG+MzKUOBYBvI9mTBE4uYqKGVIMynsiHpfzR6kPw19ffEoCY9eGgxew NJ0dY/YnTmGi5A+2rsNufGUCEg/MwRHf1Vc6wzKw+LZqIY1Lz1Mjqy99qYTHQRO+Kl3h wyKvpUcrRB4ZuhyoPi3TTgSqV84sdbeHVcmsNM799wXp6l84gdpFP3QNMo3JYDB50iNP 1OhwQd1WX6/OUkC1gUEllAm+YtQwxyhp0Bzn4F3HHrkcY62/RdHzchmmgNICoATS/0uK Ghtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=xe0bz/wfBKpHDoWdE0b7mxkKA4QR4gK0yFNZRZQWrNk=; b=Tmm2/ninWL/+NEoGZ41yBEdxjaVpilSIRFnYAswne3rH04cmiyFkU5+yDIL3kCuaVU HqaxuDwzih/MoScScjLprBIM/KJ0QtmwJSPFvra2rm5eLCjo++t+uZZwuAsJ5uIKS7T9 Impu5qSJudyRjwkIdVekhX+CPGfSDjQqtuJlz655fWubCASWLfNwIfNVQ+P98WvtlxU1 ykZbnxL5hBe3A8pqCnppv9goiyN+qe84vMDqvlUDCMZ75kgUc2AHtgtJqn9LkvWZEWfZ NbVTF8nUSzeathw8Q2FSk2wOo9dsfw8sRtpQHNeL1wMb9TEc7VIKyu4EN0ieNWJ4tRGj hHIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id h6-20020a170902f70600b0015136cc2f7asi438880plo.513.2022.03.02.15.44.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 15:44:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A74C1F2101; Wed, 2 Mar 2022 15:09:39 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244624AbiCBSfh (ORCPT + 99 others); Wed, 2 Mar 2022 13:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244615AbiCBSfg (ORCPT ); Wed, 2 Mar 2022 13:35:36 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 90AE4CA305 for ; Wed, 2 Mar 2022 10:34:52 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 46E371424; Wed, 2 Mar 2022 10:34:52 -0800 (PST) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B53193F73D; Wed, 2 Mar 2022 10:34:46 -0800 (PST) From: Dietmar Eggemann To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Daniel Bristot de Oliveira Cc: Vincent Guittot , Mel Gorman , Ben Segall , Luca Abeni , linux-kernel@vger.kernel.org Subject: [PATCH 1/6] sched/deadline: Remove unused def_dl_bandwidth Date: Wed, 2 Mar 2022 19:34:28 +0100 Message-Id: <20220302183433.333029-2-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220302183433.333029-1-dietmar.eggemann@arm.com> References: <20220302183433.333029-1-dietmar.eggemann@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 1724813d9f2c ("sched/deadline: Remove the sysctl_sched_dl knobs") the default deadline bandwidth control structure has no purpose. Remove it. Signed-off-by: Dietmar Eggemann --- kernel/sched/core.c | 1 - kernel/sched/deadline.c | 7 ------- kernel/sched/sched.h | 1 - 3 files changed, 9 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 3aafc15da24a..d342c4c779f7 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -9420,7 +9420,6 @@ void __init sched_init(void) #endif /* CONFIG_CPUMASK_OFFSTACK */ init_rt_bandwidth(&def_rt_bandwidth, global_rt_period(), global_rt_runtime()); - init_dl_bandwidth(&def_dl_bandwidth, global_rt_period(), global_rt_runtime()); #ifdef CONFIG_SMP init_defrootdomain(); diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 62f0cf842277..ed4251fa87c7 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -18,8 +18,6 @@ #include "sched.h" #include "pelt.h" -struct dl_bandwidth def_dl_bandwidth; - static inline struct task_struct *dl_task_of(struct sched_dl_entity *dl_se) { return container_of(dl_se, struct task_struct, dl); @@ -423,12 +421,10 @@ void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime) void init_dl_bw(struct dl_bw *dl_b) { raw_spin_lock_init(&dl_b->lock); - raw_spin_lock(&def_dl_bandwidth.dl_runtime_lock); if (global_rt_runtime() == RUNTIME_INF) dl_b->bw = -1; else dl_b->bw = to_ratio(global_rt_period(), global_rt_runtime()); - raw_spin_unlock(&def_dl_bandwidth.dl_runtime_lock); dl_b->total_bw = 0; } @@ -2731,9 +2727,6 @@ void sched_dl_do_global(void) int cpu; unsigned long flags; - def_dl_bandwidth.dl_period = global_rt_period(); - def_dl_bandwidth.dl_runtime = global_rt_runtime(); - if (global_rt_runtime() != RUNTIME_INF) new_bw = to_ratio(global_rt_period(), global_rt_runtime()); diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 3da5718cd641..a8b8516b8452 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2333,7 +2333,6 @@ extern void resched_cpu(int cpu); extern struct rt_bandwidth def_rt_bandwidth; extern void init_rt_bandwidth(struct rt_bandwidth *rt_b, u64 period, u64 runtime); -extern struct dl_bandwidth def_dl_bandwidth; extern void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime); extern void init_dl_task_timer(struct sched_dl_entity *dl_se); extern void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se); -- 2.25.1