Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0130200c-bbb1-9d7f-e177-6ffbc60db405@suse.de>
Date:   Wed, 2 Mar 2022 18:29:15 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH] md: bcache: check the return value of mempool_alloc() in
 bch_btree_node_read_done()
Content-Language: en-US
To:     Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
        kent.overstreet@gmail.com
References: <20220225082804.19793-1-baijiaju1990@gmail.com>
From:   Coly Li <colyli@suse.de>
In-Reply-To: <20220225082804.19793-1-baijiaju1990@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/25/22 4:28 PM, Jia-Ju Bai wrote:
> The function mempool_alloc() in bch_btree_node_read_done() can fail, so
> its return value should be checked.
>
> Fixes: d19936a26658 ("bcache: convert to bioset_init()/mempool_init()")
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>   drivers/md/bcache/btree.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
> index 88c573eeb598..fb8b7dd6bcc2 100644
> --- a/drivers/md/bcache/btree.c
> +++ b/drivers/md/bcache/btree.c
> @@ -157,6 +157,8 @@ void bch_btree_node_read_done(struct btree *b)
>   	 * See the comment arount cache_set->fill_iter.
>   	 */
>   	iter = mempool_alloc(&b->c->fill_iter, GFP_NOIO);
> +	if (!iter)
> +		return;


This is unnecessary, mempool_alloc() doesn't return NULL in this condition.


Coly Li


>   	iter->size = b->c->cache->sb.bucket_size / b->c->cache->sb.block_size;
>   	iter->used = 0;
>