Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp305322pxm; Wed, 2 Mar 2022 15:57:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxRU7NdVQhfDOd4dKsNqAqma3D6oNUisxBAbrAHBWr+waSIi4whAMHB3sfDU9WkH3RUIXMD X-Received: by 2002:a17:902:8548:b0:14e:e968:9703 with SMTP id d8-20020a170902854800b0014ee9689703mr32482621plo.148.1646265423813; Wed, 02 Mar 2022 15:57:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646265423; cv=none; d=google.com; s=arc-20160816; b=A2/D44+NXGtq/k/bvdipdXubLpb5a69x00YKPah1W38d81/1hMNZZS6RLykAMkr9Ye TCNKafP9XwgNEZq2UnFiaKsl9gjBoZXWUgO/vqSzdJcaVW63FlqAD5Ix4CQg1r+tKl6H /mGRoRnFHACW0a6cZOPuSuqq4SEzBaqX7XT1XjdtRuYocCdRaYWHYtVA3b1lbeA6ahln X+6RovEchNFSTEMbNm2ypOdCGYtjSinL9LFGADvPKoT3DK+2Tj3SDJdHgXPQ09gg44/j 9d01Ar212ZvN0KZLr9Zovuv/svcLPFOIg6piYl6XmPBxX4ML6cz68dCynOYUl0RyDEux J2zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AgNYZtZNAmOKXj24WWg1pA/uw9HzH1g2htzJ4XQkn9o=; b=0IQRfnCi5lxGVE0oK/CrHCFKaKDqD5BwpxGMezQCOSNCjwD5QUMdbhGzHfxKz5/QOx rHwYDfmWx0HzdZWFwgenxMSiQnbRNmtl0K73Yr1YsZkEowgrtkO8/+prcQ+hhkF2odX/ AemMtc1N1z3sVmy/FLOOPosI8PBMsoR5R7u+eXSATJCrBmo69NiHiCXuhPouoIcCSM8W ieaVElgxCS8R+LYhIqb2OfGUUJG6sXY8MzkLUMRIWr9fS+TytwzCKVEpWgGIucCXuJsU 2BcdYobZexE1FrX5CQan0vbcL7PMd6omkkwQDCJjIfdQCFrcpvRhtL20KwNJt12UdrY5 SxAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IDc4H3+9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id q16-20020a17090311d000b001517777221bsi562183plh.256.2022.03.02.15.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 15:57:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=IDc4H3+9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 8613119140D; Wed, 2 Mar 2022 15:17:10 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235930AbiCAQAz (ORCPT + 99 others); Tue, 1 Mar 2022 11:00:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbiCAQAv (ORCPT ); Tue, 1 Mar 2022 11:00:51 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862878BE01; Tue, 1 Mar 2022 08:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=AgNYZtZNAmOKXj24WWg1pA/uw9HzH1g2htzJ4XQkn9o=; b=IDc4H3+9TDjIlSZLD3ksJ1bXSE ILWdAWoZzkZ7Wss1bNGA0cTq2wtYDNTN3i2lG+sM/5d53qKWBP1R4SyyVTrovdx+EvZq1v3r7MX26 Lfq6ZjGIAWcsIsaxMK28DtBoku1+Z4nlyCJM8oe7CDG78MiavMchFxabARMrj12dmBtBIW1q6dgJu iE1pqGXiH/F4K9yq89OfwSSQc9VG1pAgq0b+egaXFwbWTfytbbXDE6T1pkzyafqTtl+jxv6x4A8rx zTsPoAzVPD5G4nIjAcZ3XPa9Kark+YpzP72W/oIXVNdo6zM7eGA0UZCsv76Nk9ZIVv33BZAxVbxUO piUBXRPg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP4uu-00HSOc-Sy; Tue, 01 Mar 2022 16:00:00 +0000 Date: Tue, 1 Mar 2022 08:00:00 -0800 From: Luis Chamberlain To: Christophe Leroy Cc: Aaron Tomlin , "pmladek@suse.com" , "cl@linux.com" , "mbenes@suse.cz" , "akpm@linux-foundation.org" , "jeyu@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-modules@vger.kernel.org" , "void@manifault.com" , "atomlin@atomlin.com" , "allen.lkml@gmail.com" , "joe@perches.com" , "msuchanek@suse.de" , "oleksandr@natalenko.name" , "jason.wessel@windriver.com" , "daniel.thompson@linaro.org" Subject: Re: [PATCH v9 00/14] module: core code clean up Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <6b6e02be-2d0a-31df-8375-baf79714d5b7@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6b6e02be-2d0a-31df-8375-baf79714d5b7@csgroup.eu> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 01, 2022 at 07:07:30AM +0000, Christophe Leroy wrote: > Hi Luis, > > Le 01/03/2022 ? 01:21, Luis Chamberlain a ?crit?: > > On Mon, Feb 28, 2022 at 11:43:08PM +0000, Aaron Tomlin wrote: > >> Hi Luis, > >> > >> As per your suggestion [1], this is an attempt to refactor and split > >> optional code out of core module support code into separate components. > >> This version is based on Linus' commit 7993e65fdd0f ("Merge tag > >> 'mtd/fixes-for-5.17-rc5' of > >> git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). > >> > >> Petr, > >> > >> I decided to use preempt_disable() instead to remain consistent with the > >> rest of the file. Unfortunately, I did not make time to boot test etc. > > > > Aaron, thanks so much for doing this! > > > > Since no boot tests are performed yet, I just pushed this to modules-testing > > for now, after we get some boot test results I'll push to modules-next. > > > > We should run kmod tests as well. > > > > > My Kconfig patch and my two series still cleanly apply on v9. I don't > need to rebase/resend them. > > > boot test is OK for me with Aaron's v9. Great thanks yes, I intend on applying them as soon as I get some test confirmations on modules-testing. It's all about testing now. Luis