Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <1cc1eb98-fe46-4563-16d3-ac00b630ecd3@suse.cz>
Date:   Wed, 2 Mar 2022 17:31:53 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH 5/5] slab, documentation: add description of debugfs files
 for SLUB caches
Content-Language: en-US
To:     Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc:     David Rientjes <rientjes@google.com>,
        Christoph Lameter <cl@linux.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        Pekka Enberg <penberg@kernel.org>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        patches@lists.linux.dev, linux-kernel@vger.kernel.org,
        Oliver Glitta <glittao@gmail.com>,
        Faiyaz Mohammed <faiyazm@codeaurora.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Randy Dunlap <rdunlap@infradead.org>, linux-doc@vger.kernel.org
References: <20220225180318.20594-1-vbabka@suse.cz>
 <20220225180318.20594-6-vbabka@suse.cz>
 <Yhr01naZNIa2SxEd@ip-172-31-19-208.ap-northeast-1.compute.internal>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <Yhr01naZNIa2SxEd@ip-172-31-19-208.ap-northeast-1.compute.internal>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/27/22 04:49, Hyeonggon Yoo wrote:
> I think it's not traces of "currently free objects"
> because index bit of free objects are set in obj_map bitmap?

Hm right, thanks.

> It's weird but it's traces of allocated objects that have been freed at
> least once (or <not available>)
> 
> I think we can fix the code or doc?

For now I'll fix the doc. Not clear to me myself what's the best usecase for
free_traces file. For alloc_traces it's clearly debugging memory leaks.
Freeing traces are most useful when a bug is detected and they are dumped in
dmesg. The debugfs file might be just for a rough idea where freeing usually
happens.

> Please tell me if I'm missing something :)
> 
>> +    Information in the output:
>> +    Number of objects, freeing function, minimal/average/maximal jiffies since free,
>> +    pid range of the freeing processes, cpu mask of freeing cpus, and stack trace.
>> +
>> +    Example:::
>> +
>> +    51 acpi_ut_update_ref_count+0x6a6/0x782 age=236886/237027/237772 pid=1 cpus=1
>> +	kfree+0x2db/0x420
>> +	acpi_ut_update_ref_count+0x6a6/0x782
>> +	acpi_ut_update_object_reference+0x1ad/0x234
>> +	acpi_ut_remove_reference+0x7d/0x84
>> +	acpi_rs_get_prt_method_data+0x97/0xd6
>> +	acpi_get_irq_routing_table+0x82/0xc4
>> +	acpi_pci_irq_find_prt_entry+0x8e/0x2e0
>> +	acpi_pci_irq_lookup+0x3a/0x1e0
>> +	acpi_pci_irq_enable+0x77/0x240
>> +	pcibios_enable_device+0x39/0x40
>> +	do_pci_enable_device.part.0+0x5d/0xe0
>> +	pci_enable_device_flags+0xfc/0x120
>> +	pci_enable_device+0x13/0x20
>> +	virtio_pci_probe+0x9e/0x170
>> +	local_pci_probe+0x48/0x80
>> +	pci_device_probe+0x105/0x1c0
>> +
> 
> Everything else looks nice!
> 
>>  Christoph Lameter, May 30, 2007
>>  Sergey Senozhatsky, October 23, 2015
>> -- 
>> 2.35.1
>> 
>> 
>