Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 2 Mar 2022 22:22:37 +0100
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Peter Rosin <peda@axentia.se>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that
 is not active
Message-ID: <Yh/gHSaRNs9Z8La2@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Peter Rosin <peda@axentia.se>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <eca2bf56-7abd-55c0-a423-dce47c38fd66@axentia.se>
 <Yh/e4OzQ/hYSb+dg@ninjato>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="jepbhLwGEDWuNCcE"
Content-Disposition: inline
In-Reply-To: <Yh/e4OzQ/hYSb+dg@ninjato>
Precedence: bulk


--jepbhLwGEDWuNCcE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 02, 2022 at 10:17:20PM +0100, Wolfram Sang wrote:
>=20
> > Attempting to rollback the activation of the current master when
> > the current master has not been activated is bad. priv->cur_chan
>=20
> But the master is activated?
>=20
> 259         /* switch to first parent as active master */
> 260         i2c_demux_activate_master(priv, 0);
>=20
> Or am I missing something? :)

But _this_ code is affected by the problem you describe, or?

237                 if (!adap_np) {
238                         dev_err(&pdev->dev, "can't get phandle for pare=
nt %d\n", i);
239                         err =3D -ENOENT;
240                         goto err_rollback;
241                 }


--jepbhLwGEDWuNCcE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIf4B0ACgkQFA3kzBSg
KbZK3g/5AeBNwiDpQudH0ZbIc5TMhKbBsoyIbxK1jJHIxDFPY03TN9vnLHzzKG0R
POEMO5fIluTgrKSBuRg0n0osCGXCo6oznf7/Ni6xqZkUdIG9Q/TJNG4lZ3U7EvEB
ftzMkHTngywmLqohz+u0nIg0EPXvXJca3ONQZyoSNjf6c8Km1+X+5dXvvwhpBRpS
cp9mDdM7Mnb8DSCMcmKGFOpc14Lfq5Fna5jC29C9ajqWgrvgpTWiUMCarEuGpiug
Y8Q6V7i1aHkFozZW4RZqjvj4UDXXkktmvhKkih12VYcGGJMLM9jiDvCT7bF4Sf/S
QREGU3ce5HxB1LeIwLY+OM4jR5PSOQj1DljvmceI0jm3E0aK6oitXug59OzP07zs
05iAxLA95Q6VvwX05H5ecNlra1k8Q9VlzGnnu6lgUYd9t90DXCedeDSryjzLL4Tb
tMKeip+XxNpaHo5So+RgwCE9+uynKB3VEzqtMCOFe6+XTuH9OV3K69m3wKbC1tzE
js+9aWXuhohRVr0ccNceRoU9iFIOGqosrHGj7Pp/MCT50vtKQiPL50ZHP4G7fss+
Jzm8SUoaFJmonQJSgVglRECkvUs5fPgws8SScsD+dA3H/KkiM0YVTQf+/jHJvInf
LqcHydfykflEfLAew50sZLnaBvMuL7NbUY0CiR793urZvDWlS4k=
=cnxv
-----END PGP SIGNATURE-----

--jepbhLwGEDWuNCcE--