Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 2 Mar 2022 16:59:34 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     David Hildenbrand <david@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Rientjes <rientjes@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Nadav Amit <namit@vmware.com>, Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Donald Dutile <ddutile@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>,
        Liang Zhang <zhangliang5@huawei.com>,
        Pedro Gomes <pedrodemargomes@gmail.com>,
        Oded Gabbay <oded.gabbay@gmail.com>, linux-mm@kvack.org
Subject: Re: [PATCH RFC 12/13] mm/gup: trigger FAULT_FLAG_UNSHARE when
 R/O-pinning a possibly shared anonymous page
Message-ID: <20220302205934.GV219866@nvidia.com>
References: <20220224122614.94921-1-david@redhat.com>
 <20220224122614.94921-13-david@redhat.com>
 <20220302165559.GU219866@nvidia.com>
 <fb895ba3-9d7e-7421-d5c6-f5e7a2d1231a@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <fb895ba3-9d7e-7421-d5c6-f5e7a2d1231a@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ca1FU/B/Lc5Nf7EjE9dhmp92kzbe1qv+d4X1RZoBjfB1Cq1LM9TgccgOq/pi?=
 =?us-ascii?Q?YQSP5yIgOtKIuuNpNMTjfuOj1fRYFnSUBIfjG28Hf03bsEV+PJ5QhrGwRiVm?=
 =?us-ascii?Q?aZ3hOVpObvC4R/AxECCHFB9/Ocipgo1RaLARLBv/5WsK4O2L61FYqbQ4Y+jv?=
 =?us-ascii?Q?2e9nrC1bqj2wQJSz9ClGwSlbqW3SeQ3/Zlkk7T0p5ffLFxsPBXbfuJ8FlFS7?=
 =?us-ascii?Q?2G9DYxQzalzbTP48jzlggsT3H8RiOM1tULBi0jrqLsY/vIsGAkNcJibdLRbD?=
 =?us-ascii?Q?iHknK9TDv1vXBFVLPHetzItI9TKlZ6oYhqALNkEu8/qrrQYSM8Cb112FSUOA?=
 =?us-ascii?Q?z2VX5b8uGtOpk8VRISvTxuN6j8mokApCO1AoKQQfvkL+DRQMIhkQkCTEFMAs?=
 =?us-ascii?Q?v/ryuyGge4LRLhrehsk0RQQxQ8RELeO43V1jQqAvA9GHcbQM37I/+O5s+40K?=
 =?us-ascii?Q?qMIjJq4Oxieo8NxhuqL038qMbax2amIZb+P8yqYi/EiWstV3vhVW4EP+KkXd?=
 =?us-ascii?Q?lU3R1xAopLlGID8/wDLcAT32LdN72cmskP2Vd+YDqnqQQfMXvwTR/b8TIUg6?=
 =?us-ascii?Q?ImR9bmdHrnh04lXIFE84WGHGSmRnvkHXPgAHda7WYBOJOnfkd8J5YNV47q5J?=
 =?us-ascii?Q?lah4T0MJOKMsfjXmZi7XtbL0KCoDjvykIfrt0uxqDFu3j5eZlQn4oCDU51nQ?=
 =?us-ascii?Q?OWb4viD1wysGp3vGU6BRaA3um6KtMEioV4pR3oRYvbr8a7/OqYZ9F6BUiA5g?=
 =?us-ascii?Q?WSZrphGORRHaDVoqmpixDcvZWIxu51wi9iqLjw1q3tbT7GqRXURFIz3wV2jS?=
 =?us-ascii?Q?kntFJ+BfXoIrxC5NqwLtJbhhtDgdWw2rASB2GQwq/cpurBPV7N79a1bPDiPd?=
 =?us-ascii?Q?B0mJVYl7m+4v5vKC4O0Ffqk/YKz18+1/VKTasczwDsbcMlXEOP4V/LHWl5WU?=
 =?us-ascii?Q?qFcFvi+BtIUCh13toxtqVdI4Y1+x8/1uMvnjou9xLz28h0w6AceYwE4sgRrA?=
 =?us-ascii?Q?wQKydD9sAgl9jFvIn+riEQphZ9tsrfvhpVLJa9SUjhXPEy2avOG0+EUSEWUz?=
 =?us-ascii?Q?o28R6QcZUvsthzRwmHRKuw+tgen0uN1QAkPpHEepFDhzenGeCp4G+0OuGF2j?=
 =?us-ascii?Q?xN7v0/GZoq0TbrrOFJHLwXWrb3ftXZOOZ85GXLNKYl1bPXId0KLSG1Psm7lK?=
 =?us-ascii?Q?gUor8BppgQlHtGZINNfpQTKzcn0DJ8iIvr8neMJFVEpNLFRF6GFSYxYOs3ny?=
 =?us-ascii?Q?18uEUlSP9qdRhc1shZ9ZLCfnpX9ut/f0N5P3eGzTfa0ptqjLjFwljjm6gbvC?=
 =?us-ascii?Q?+5Tqs093zsZpxfqcmycxP/d0I6eAhliPKeBWsneBZJJ11d9R78+qP7YWFcK8?=
 =?us-ascii?Q?Xg2rcWKqP2sUPSXxDmgSZ8rXgcjmKFPjdU+ixr5h8XoTMZN4jD4dLul7hplk?=
 =?us-ascii?Q?T2M3AnMes+zxlChexUmiAkUp2q3ywz6/oR1yng0wY6iQ8Eq4ZL1obWXd2gVj?=
 =?us-ascii?Q?8lW5UWU/NcERu4Sjg46mGqGEcqgwKsNFpZ+9/hXnvwwoZmn4nUr/AkPXN0kM?=
 =?us-ascii?Q?VOPdIQbfrl1ssVQQPD4=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ee75e29-82b1-48c9-7f68-08d9fc8f8f9d
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 20:59:37.2278
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nOqEtwt4CtwqMyrA5hZNJDQ/HZ+oJVHPpCvn/UI7QgnNWVmgJ/RZJRDykgCuyGqa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4952
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 02, 2022 at 09:38:09PM +0100, David Hildenbrand wrote:

> (a) I want a R/O pin to observe file modifications.
> (b) I want the R/O pin to *not* observe file modifications but observe
>     my (eventual? if any) private modifications,

A scenario I know that motivated this is fairly straightfoward:

   static char data[] = {};

   ibv_reg_mr(data, READ_ONLY)
   data[0] = 1
   .. go touch data via DMA ..

We want to reliably observe the '1'

What is happening under the covers is that 'data' is placed in the
.data segment and becomes a file backed MAP_PRIVATE page. The write
COWs that page

It would work OK if it was in .bss instead

I think the FOLL_FORCE is there because otherwise the trick doesn't
work on true RO pages and the API becomes broken.

Jason