Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp324066pxm; Wed, 2 Mar 2022 16:23:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmdGIxZJcJLAhRWlkxEE8biK6FHdf7plrlfjdXDtnQQ5s17nWYzhxibPGKp01gsVsK5by+ X-Received: by 2002:a05:6a00:c90:b0:4bd:22a:bb1d with SMTP id a16-20020a056a000c9000b004bd022abb1dmr35274807pfv.32.1646267036279; Wed, 02 Mar 2022 16:23:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646267036; cv=none; d=google.com; s=arc-20160816; b=EorUe4mWGG4o1s40lXkFUKGv4klc/4guac+QEPysPLhVbOHOuJN/aBk2E9bU4MFI4+ B1X65LMSn9rRPjenhp6QGWLIjQNtChQCFjXI6A2s8MCNSoBMjceQ50kGLeU317DZttRy Ur6tSH8WKTnG1OOZbqfltwmSMPccTJ/PlTE4ALjLIztjRyNCWFMwiyJL/ZU68q1fKUXR gWkTVKSI9GdpDAx9EvwRUgJ2hxHditoLWOk2CAZBRc2/si4vLnNmWRqSQY3Bf8/+wfgI RwzWBsdyMu2v+BhKHxo/h0Ywmw91oRsq7DigGeY9MtXMtXelEANXy5X2RfW4Dzcif5+k 32NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/UBq7VhXSkUQgcE7NfUzvw3QY0luGPb1C3v9SO56euQ=; b=bFcHpuGO1atFggymANtHnV6xK5GVFqSylFTk9i2hZJxI7dBIveJnJ3D4slrE1n8gz4 PFZ66ylmr8ftrNApVcSlAXbQhCMFJxPrR3+FtNpVeBDXeeD97XYiz8LEVELNM8f24Tg5 TyLa8brBc65ckA874cqcSlmngaBdcnLZh5pIiLjmijr3/h7VgpAgS0lOhazUIPqIuJyF JZhmAQACIlXIEYgSsDMQqmjBdZ4LGbAzCQUlPJV5TPWR/8cr5Xm2iuNiRp/Fbwo/7Gwe Sn7qNW3hW7HHxZKGxgMsxZBEVnUuO/ty9r0QnWAMfxn/dv4Zl/1c5O/HOr+o64u5XQwU /m8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=2jHzGkuk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id j16-20020a632310000000b003762e08d474si483079pgj.628.2022.03.02.16.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 16:23:56 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@sang-engineering.com header.s=k1 header.b=2jHzGkuk; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 30A901F9826; Wed, 2 Mar 2022 15:36:28 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238714AbiCBVSN (ORCPT + 99 others); Wed, 2 Mar 2022 16:18:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245319AbiCBVSI (ORCPT ); Wed, 2 Mar 2022 16:18:08 -0500 Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EA6510C5 for ; Wed, 2 Mar 2022 13:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=sang-engineering.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=k1; bh=R1HfuEPNnV2HPbjXGZzn4hbxUBS3 nO9gTHPMAuFzR70=; b=2jHzGkukwQicy9w/hkGqZeAPZ32G9Yk5EgrYO5MmIKcu zYInjr1bU9aY1kA5yg81GRvW0KYcJJ25c6jadwDi4WuoDHPJuGUqxHC7YI3/s/XE SRSP2b9n7JbLzfpJ2IuUIdBtNaOAa35C5leNaTmTQ4s0uDuvhQWX8bz81Aff3Bw= Received: (qmail 257907 invoked from network); 2 Mar 2022 22:17:21 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 2 Mar 2022 22:17:21 +0100 X-UD-Smtp-Session: l3s3148p1@Su2bzkLZ/sMgAQnoAGk1AHiBA1wHs4oK Date: Wed, 2 Mar 2022 22:17:20 +0100 From: Wolfram Sang To: Peter Rosin Cc: "linux-i2c@vger.kernel.org" , Christophe JAILLET , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that is not active Message-ID: Mail-Followup-To: Wolfram Sang , Peter Rosin , "linux-i2c@vger.kernel.org" , Christophe JAILLET , "linux-kernel@vger.kernel.org" References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fI53YHIyjI418Sfe" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fI53YHIyjI418Sfe Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > Attempting to rollback the activation of the current master when > the current master has not been activated is bad. priv->cur_chan But the master is activated? 259 /* switch to first parent as active master */ 260 i2c_demux_activate_master(priv, 0); Or am I missing something? :) --fI53YHIyjI418Sfe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIf3uAACgkQFA3kzBSg Kbaw7xAApyMoXoMmWz5Rcb06GYQ681jFXgF4RUYPrh0AecZKvjqeBrT4ZgAcdEnr 2jMcuB2d/ZgXfhi+hOVBmx6y6sSXR2ONlki9SosC1gYnGV+DCkbHQlbV3SjZcqTn KrrbQAvoSzQZHlu9EpkH6RiAUiG1O/EQroZ54bJXfrZelPiWbZX5MVYKg2RSD38r Le+h30U0YNim1vl2l28lxwg4gr6SSgadp2kJagBO+ySXm6iBLG7z/npHIedDOM8s BzXmnDq+0guQ4ex7Gi05MLPTwZ7oFcj8wlTWmG2EKJjbpTdoSZE7AFys22tCeMz6 VPaR7i1YVS8pa/aXfJh7VqX4Xi/JUdP/iqjqy8cpSKEkatl9qk0I+C/8VdAuGi4i XwbUBLtNVe07looAJzWA0aWffbXwTN2cle4kIOVnDBgaASfC29+7tLrx0vcScVKt b6YeCfBqGqSBsqsSUGKxz6j1fxLKx+xUaKl/UurIwiccg39K/6ELGjaISXKaQFdG zcob1LWTQeBDxIx62lP3yFz24u3epXlSwMUZJREFZTTBK30SzealBcDQotJ/BRcn XYXPl7cJ9glh7aqloYddbMfLz67JBKz0Zcx37jKWpqH1fW5FGCd4bvbCXcvED93U fZiyh0WYMCV2J9viIynaN5QzsUWGOy/KThIVmiET9QqJuS4bjGs= =m2zY -----END PGP SIGNATURE----- --fI53YHIyjI418Sfe--