Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp325833pxm; Wed, 2 Mar 2022 16:26:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJxgdKlrzr7oT7YiPYxvlo5OGqJkREw3nkcQloLoPK7JlNQfyw/pEAOFkTvpzYR24kHokz44 X-Received: by 2002:a17:902:9a4c:b0:14d:b0c0:1f7a with SMTP id x12-20020a1709029a4c00b0014db0c01f7amr32723591plv.57.1646267196553; Wed, 02 Mar 2022 16:26:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646267196; cv=none; d=google.com; s=arc-20160816; b=aRRy6TlNSGiiLO4NPUth2pDZpWEbFYEo99JPuJdGfSlVSgN3ueM0T/6QyJUMNasGSe 4aNlbWnKVuSdqiDanQifBu60gbw6oKxOHHXzn3t2t/rsw1B8DA2sr2oW+FSnoo4Srlht msuxP+4Olzd4yRx04wiiUkw7veaS54KjfN6LqbC9PROdLYPGQWfwf4loMu4KdSd1/iao yQFDuKpA4cwLLXYW8TgBVX1glGak3G11joiZPn+5DWciiSGMG7fDdnIOKZvy5GeCtsIl U7pAiOwJYdRoKH6X7fvwd1O/3Re3sXAbLDhVUjtJ/ORpifp7QDsh/KGYsDpQMgq6j/5r aiWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=ERFJv3npFgK0v8bM0StvQKz0Y7eEGNf4mHalQvDgZU0=; b=uFj+/EwdAQGkMzl6xw78L4+Z11fUr66eVaPySQSmZbTgqUj+4wC/cO3AIxo7jMIrzE 5GKPOgCCZTsr6+accg1ZVoIqd+mZXRZo3dWO/Zf5ZjpOtNB+/AatwkYQ0oHqGWvgC/FH rO7+PXcfQ3fI5xnwlr2WUYZc9a7onWzdOQ2cqIDTet9Pomd3ARNpweQrcL+n0CpjZdgE S+yt1g+xBMw6LgD8I5yn77YsXHe8Y0UWrrXV/K84n6G6CW0jao1pnC/H6dBnJzevzKIq GKjZq5C5sZCc45mwl5uLFjLY44wlO8vm+UoIxW4sHfGYAGQTRmJA8JLNcZaLuQrcIcOA QElw== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id p12-20020a63e64c000000b00372ed68ade4si501404pgj.436.2022.03.02.16.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 16:26:36 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 41DC71567BF; Wed, 2 Mar 2022 15:38:22 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243094AbiCBSf6 (ORCPT + 99 others); Wed, 2 Mar 2022 13:35:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241828AbiCBSfw (ORCPT ); Wed, 2 Mar 2022 13:35:52 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53579D8355 for ; Wed, 2 Mar 2022 10:35:07 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E34501516; Wed, 2 Mar 2022 10:35:06 -0800 (PST) Received: from localhost.localdomain (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 563333F73D; Wed, 2 Mar 2022 10:35:04 -0800 (PST) From: Dietmar Eggemann To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Daniel Bristot de Oliveira Cc: Vincent Guittot , Mel Gorman , Ben Segall , Luca Abeni , linux-kernel@vger.kernel.org Subject: [PATCH 6/6] sched/deadline,rt: Remove unused parameter from pick_next_[rt|dl]_entity() Date: Wed, 2 Mar 2022 19:34:33 +0100 Message-Id: <20220302183433.333029-7-dietmar.eggemann@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220302183433.333029-1-dietmar.eggemann@arm.com> References: <20220302183433.333029-1-dietmar.eggemann@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The `struct rq *rq` parameter isn't used. Remove it. Signed-off-by: Dietmar Eggemann --- kernel/sched/deadline.c | 5 ++--- kernel/sched/rt.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 93fcef57dd59..11cdc6d0c45f 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -1961,8 +1961,7 @@ static void set_next_task_dl(struct rq *rq, struct task_struct *p, bool first) deadline_queue_push_tasks(rq); } -static struct sched_dl_entity *pick_next_dl_entity(struct rq *rq, - struct dl_rq *dl_rq) +static struct sched_dl_entity *pick_next_dl_entity(struct dl_rq *dl_rq) { struct rb_node *left = rb_first_cached(&dl_rq->root); @@ -1981,7 +1980,7 @@ static struct task_struct *pick_task_dl(struct rq *rq) if (!sched_dl_runnable(rq)) return NULL; - dl_se = pick_next_dl_entity(rq, dl_rq); + dl_se = pick_next_dl_entity(dl_rq); BUG_ON(!dl_se); p = dl_task_of(dl_se); diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index b62e7652464b..67039e5d359b 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1719,8 +1719,7 @@ static inline void set_next_task_rt(struct rq *rq, struct task_struct *p, bool f rt_queue_push_tasks(rq); } -static struct sched_rt_entity *pick_next_rt_entity(struct rq *rq, - struct rt_rq *rt_rq) +static struct sched_rt_entity *pick_next_rt_entity(struct rt_rq *rt_rq) { struct rt_prio_array *array = &rt_rq->active; struct sched_rt_entity *next = NULL; @@ -1742,7 +1741,7 @@ static struct task_struct *_pick_next_task_rt(struct rq *rq) struct rt_rq *rt_rq = &rq->rt; do { - rt_se = pick_next_rt_entity(rq, rt_rq); + rt_se = pick_next_rt_entity(rt_rq); BUG_ON(!rt_se); rt_rq = group_rt_rq(rt_se); } while (rt_rq); -- 2.25.1