Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220223160708.88100-1-mark@yotsuba.nl> <303dc74a-4d63-70a2-9891-af3e3d8baf26@redhat.com>
 <CAJZ5v0gVN_nsB5eqfWzyG3+LyvAmOJKsVbA4_sOiAV+RnjG64w@mail.gmail.com>
In-Reply-To: <CAJZ5v0gVN_nsB5eqfWzyG3+LyvAmOJKsVbA4_sOiAV+RnjG64w@mail.gmail.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 2 Mar 2022 20:42:43 +0100
Message-ID: <CAJZ5v0gPxZ_m=7bqgo54kb1Kx5ut_KZ2iOeWo2ak0AFJq7rpjw@mail.gmail.com>
Subject: Re: [PATCH] x86/acpi: Work around broken XSDT on SEGA AALE board
To:     Mark Cilissen <mark@yotsuba.nl>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        "the arch/x86 maintainers" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 1, 2022 at 8:34 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Feb 24, 2022 at 9:41 AM Hans de Goede <hdegoede@redhat.com> wrote:
> >
> > Hi Mark,
> >
> > On 2/23/22 17:07, Mark Cilissen wrote:
> > > On this board the ACPI RSDP structure points to both a RSDT and an XSDT,
> > > but the XSDT points to a truncated FADT. This causes all sorts of trouble
> > > and usually a complete failure to boot after the following error occurs:
> > >
> > >   ACPI Error: Unsupported address space: 0x20 (*/hwregs-*)
> > >   ACPI Error: AE_SUPPORT, Unable to initialize fixed events (*/evevent-*)
> > >   ACPI: Unable to start ACPI Interpreter
> > >
> > > This leaves the ACPI implementation in such a broken state that subsequent
> > > kernel subsystem initialisations go wrong, resulting in among others
> > > mismapped PCI memory, SATA and USB enumeration failures, and freezes.
> > >
> > > As this is an older embedded platform that will likely never see any BIOS
> > > updates to address this issue and its default shipping OS only complies to
> > > ACPI 1.0, work around this by forcing `acpi=rsdt`. This patch, applied on
> > > top of Linux 5.10.102, was confirmed on real hardware to fix the issue.
> > >
> > > Signed-off-by: Mark Cilissen <mark@yotsuba.nl>
> > > Cc: stable@vger.kernel.org
> >
> > Wow, you got it working, cool!
> >
> > The patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Applied as 5.18 material, thanks!

And dropped due to a problem introduced by it.

Also please note that the x86 mailing list address originally used in
the CC list was incorrect.