Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 2 Mar 2022 15:47:48 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     kernel test robot <yujie.liu@intel.com>, kbuild-all@lists.01.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Arunachalam Santhanam <Arunachalam.Santhanam@in.bosch.com>,
        linux-can <linux-can@vger.kernel.org>
Subject: Re: drivers/net/can/usb/etas_es58x/es58x_fd.c:174:8: warning:
 Uninitialized variable: rx_event_msg [uninitvar]
Message-ID: <20220302144748.tidd2zq2xfdqvoyl@pengutronix.de>
References: <202203021333.mMJpWPzx-lkp@intel.com>
 <5f13b914-e309-49ee-4f98-c81780c478b9@intel.com>
 <20220302103219.kvpfhc6qz42t3pvv@pengutronix.de>
 <CAMZ6Rq+HR=j2mD97etTgSapOix96P=pK70bTr9HeJu2Mjkn3+g@mail.gmail.com>
 <20220302130423.ddd2ulldffpo5lb2@pengutronix.de>
 <CAMZ6Rq+J0CH_HvK1ax=VcWKqih+B_0Nfoc9jZMiq7OtuXL06hw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="goiohfcs56kly6pg"
Content-Disposition: inline
In-Reply-To: <CAMZ6Rq+J0CH_HvK1ax=VcWKqih+B_0Nfoc9jZMiq7OtuXL06hw@mail.gmail.com>
Precedence: bulk


--goiohfcs56kly6pg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 02.03.2022 23:42:53, Vincent MAILHOL wrote:
> On Wed. 2 Mar 2022 at 22:04, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
> > I was thinking of this:
> >
> > | void *foo =3D bar->baz;
> > |
> > | if (!bar)
> > |         return;
> > |
> > | printf("%p", foo);
> >
> > There were/are compilers that optimize the bar NULL pointer check away,
> > because bar has already been de-referenced.
>=20
> Sorry, I do not get your example. If bar is NULL,
> | void *foo =3D bar->baz;
> would segfault and thus the check is not reached.

ACK

> If bar is not NULL, the check succeeds.
>=20
> In both cases, the return statement of the if branch is never
> executed making this some dead code. So I do not see why this is
> an issue if the compiler removes it.

IIRC in some cases the code was shuffled around by the compiler and the
NULL pointer check was done....and with a new compiler version it
stopped working :)

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--goiohfcs56kly6pg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmIfg5IACgkQrX5LkNig
010y+Qf/f5JuMksYTwROvq+dWt29bgQ22vMgbkBu52JhjCv7Vfihplg8sqODqJBl
mYYesKRehXh2xUVDy8n+HEtXQvSsbNiA6CscidS1jHaG09yOPOm+/3ulylEz5vU6
VCnfbHb2I2zgYG7Bcoh82lz9VCGog8B4dRc+3IywXEv05P95MCt9ACl+lmOIB0p4
UiCQ9Vii0ohNBElAJ7X1TYLR7KDQGW80bMHsQCq9l6l+wCKU9iXxKwdPh9W7x0Nq
xTZBQEqigDHwJKI20U6CzOReGHEN+99KXSBSLF2iOzBSbR18bRihhiDSkILD0esf
dY2rB+NgzjysaST27/FGUKiGdg4DXA==
=MAE0
-----END PGP SIGNATURE-----

--goiohfcs56kly6pg--