Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
MIME-Version: 1.0
References: <20220302173114.927476-1-clg@kaod.org> <20220302173114.927476-3-clg@kaod.org>
In-Reply-To: <20220302173114.927476-3-clg@kaod.org>
From:   Joel Stanley <joel@jms.id.au>
Date:   Wed, 2 Mar 2022 22:18:00 +0000
Message-ID: <CACPK8XdqYJeRkGN3j0qKfSnbYHgAsogKhv7e1PGTY+MBy=N=Rg@mail.gmail.com>
Subject: Re: [PATCH v2 02/10] ARM: dts: aspeed: Adjust "reg" property of
 FMC/SPI controllers
To:     =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>,
        Rob Herring <robh+dt@kernel.org>
Cc:     linux-spi@vger.kernel.org,
        linux-mtd <linux-mtd@lists.infradead.org>,
        Mark Brown <broonie@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
        devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 2 Mar 2022 at 17:32, C=C3=A9dric Le Goater <clg@kaod.org> wrote:
>
> This is compatible with the current driver and addresses issues when
> running 'make dt_binding_check'.

Hey Rob, why does the checking rule complain about this style of reg proper=
ty?

>
> Cc: Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>
> Signed-off-by: C=C3=A9dric Le Goater <clg@kaod.org>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++----
>  arch/arm/boot/dts/aspeed-g5.dtsi | 9 +++------
>  arch/arm/boot/dts/aspeed-g6.dtsi | 9 +++------
>  3 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-=
g4.dtsi
> index f14dace34c5a..9ae67e83cf60 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -54,8 +54,7 @@ ahb {
>                 ranges;
>
>                 fmc: spi@1e620000 {
> -                       reg =3D < 0x1e620000 0x94
> -                               0x20000000 0x10000000 >;
> +                       reg =3D <0x1e620000 0x94>, <0x20000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2400-fmc";
> @@ -91,8 +90,7 @@ flash@4 {
>                 };
>
>                 spi: spi@1e630000 {
> -                       reg =3D < 0x1e630000 0x18
> -                               0x30000000 0x10000000 >;
> +                       reg =3D <0x1e630000 0x18>, <0x30000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2400-spi";
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-=
g5.dtsi
> index 7495f93c5069..c3e0a8e13c8a 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -55,8 +55,7 @@ ahb {
>                 ranges;
>
>                 fmc: spi@1e620000 {
> -                       reg =3D < 0x1e620000 0xc4
> -                               0x20000000 0x10000000 >;
> +                       reg =3D <0x1e620000 0xc4>, <0x20000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2500-fmc";
> @@ -84,8 +83,7 @@ flash@2 {
>                 };
>
>                 spi1: spi@1e630000 {
> -                       reg =3D < 0x1e630000 0xc4
> -                               0x30000000 0x08000000 >;
> +                       reg =3D <0x1e630000 0xc4>, <0x30000000 0x08000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2500-spi";
> @@ -106,8 +104,7 @@ flash@1 {
>                 };
>
>                 spi2: spi@1e631000 {
> -                       reg =3D < 0x1e631000 0xc4
> -                               0x38000000 0x08000000 >;
> +                       reg =3D <0x1e631000 0xc4>, <0x38000000 0x08000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2500-spi";
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-=
g6.dtsi
> index c32e87fad4dc..1ad05dde19d2 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -95,8 +95,7 @@ gic: interrupt-controller@40461000 {
>                         };
>
>                 fmc: spi@1e620000 {
> -                       reg =3D < 0x1e620000 0xc4
> -                               0x20000000 0x10000000 >;
> +                       reg =3D <0x1e620000 0xc4>, <0x20000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2600-fmc";
> @@ -124,8 +123,7 @@ flash@2 {
>                 };
>
>                 spi1: spi@1e630000 {
> -                       reg =3D < 0x1e630000 0xc4
> -                               0x30000000 0x10000000 >;
> +                       reg =3D <0x1e630000 0xc4>, <0x30000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2600-spi";
> @@ -146,8 +144,7 @@ flash@1 {
>                 };
>
>                 spi2: spi@1e631000 {
> -                       reg =3D < 0x1e631000 0xc4
> -                               0x50000000 0x10000000 >;
> +                       reg =3D <0x1e631000 0xc4>, <0x50000000 0x10000000=
>;
>                         #address-cells =3D <1>;
>                         #size-cells =3D <0>;
>                         compatible =3D "aspeed,ast2600-spi";
> --
> 2.34.1
>