Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp329149pxm; Wed, 2 Mar 2022 16:31:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJyUxTKdvh0C+ATYfswgjo6fH7a8E5ku6wkwYYtUgqhVkZZfpVNV2EQwc8eiXicdG20u78A4 X-Received: by 2002:a63:d63:0:b0:36c:670d:b6c9 with SMTP id 35-20020a630d63000000b0036c670db6c9mr27800889pgn.343.1646267514622; Wed, 02 Mar 2022 16:31:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646267514; cv=none; d=google.com; s=arc-20160816; b=QJLdDiYWlyiXhA0oJpH/w2mJ7EXxjQHx/0bpQ1AgAVJG3DldpKeyjCKEIdMUF570VQ PrblpbgfCSPne6iGTR0B7nBXMqdzxBx56DEkKFgJcsj9Y05poR9WyKIzbxeZoBGmzXFg VN+0yTaRxDGkHNAiPl7arjkPxlRkiwZ8w5a+ZXPSiJMkgqZ7FVkQKgb0BrQCPTy6qRDe qDphaG6NkqXaOrFpbVTW1iKqxdp46x8yJy60eI9dpgUsiL7y8YbW/bPYBOWvQdQ9n3zZ pD1HvWYYB/mdTUzXhsmaH1duA+PFqIGTfEHTuCByVMDdI+DgOZDpuadWZGQZ1LLShDyj e7ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gPWvCaxGBJWGx4myf/JEcCQ3Al2OzB7SzAz/d83LDNA=; b=eZR4SH+YIEYFmSa2xUWtx40FiMrE3AUl2CkvDUHxXZdFk6w8HnMGnBg+ksqbonoAV1 6W3O4/+qiYXKuEuV+3EXRC5TxCEsNwiVpRg6ogBiCAWpACleKb1T5Ou7syQ1ibkPWGGd EoMh74s366ZjWZfOwjKDYQ8SQX9IyMu9OUVxh89B5S5b6/FI/lLFJ4qhcHFIi0MbNzfA FN6uoHTXdeiaSUweMuSgUp4RJ/oQpVMqB/GoY2TQ7KLkPPzDVRAuKlNRUOzBMOTCglkq wQ9e3fsNmPBqxMZftHgGS4kouY0h59onQBKdoK1hbcMUaS1J/Fy8BqF9i0ZEuPzGTf4F r5Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id m22-20020a656a16000000b00372b111bf20si657735pgu.19.2022.03.02.16.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 16:31:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A795022F95E; Wed, 2 Mar 2022 15:42:18 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231210AbiCBW2p (ORCPT + 99 others); Wed, 2 Mar 2022 17:28:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229831AbiCBW2o (ORCPT ); Wed, 2 Mar 2022 17:28:44 -0500 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF96E6D90; Wed, 2 Mar 2022 14:27:59 -0800 (PST) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1nPXRj-0005os-MI; Thu, 03 Mar 2022 09:27:48 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 03 Mar 2022 10:27:47 +1200 Date: Thu, 3 Mar 2022 10:27:47 +1200 From: Herbert Xu To: Greg KH Cc: Giovanni Cabiddu , Linus Torvalds , Kyle Sanderson , Dave Chinner , qat-linux@intel.com, Linux-Kernal , linux-xfs , Linux Crypto Mailing List , device-mapper development Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 03:56:36PM +0100, Greg KH wrote: > > > If not, then these are the patches that should be backported: > > 7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags > > 2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS > > fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY > > b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY > > cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY > > Herbert, correct me if I'm wrong here. > > These need to be manually backported as they do not apply cleanly. Can > you provide such a set? Or should I just disable a specific driver here > instead which would be easier overall? I think the safest thing is to disable qat in stable (possibly only when DM_CRYPT is enabled/modular). The patches in question while good may have too wide an effect for the stable kernel series. Giovanni, could you send Greg a Kconfig patch to do that? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt