Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp329193pxm; Wed, 2 Mar 2022 16:31:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7VpaozFyMnS8zhYtLQV5WRKgggrDFcRYviw1T4fDkXd5zc4O2q+j0y1BAf9BVOH4Z2C3K X-Received: by 2002:a17:90b:4b0e:b0:1bf:749:952 with SMTP id lx14-20020a17090b4b0e00b001bf07490952mr2508930pjb.68.1646267518137; Wed, 02 Mar 2022 16:31:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646267518; cv=none; d=google.com; s=arc-20160816; b=cp3s/n55HJcsm+nVQalyPKB+cQDfOVC77+WBd4r8nAbdWHWnD6WZGmkpMWWkZ9mR+y qMmlyi1+uH3NpOLWPAtGS3lI/GdJBG3TwZAdSY4Sg/hn00INtvw8J9K62PRvNsL5ncmI nRw/XapueVqIs458jdpdeVSrQmwIIWhjZgV2gWkT+YNzcnzAtmlPzjJXUzTsAHyFU41b a55HWUCG2HllnL7VduX4y6DSNHyq+ovgh0uQ8V74E2ZmYycFLd2j41Qn4cBApOqPXAF7 6leDDgrhXbEDhux5A6b0F5PR4HiKAogzbJOq58NGUei8HTxyQf9PpdSrOmC+DUsHdTeY EE7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=v1SczNr2OUEGHMSVwtsfX7qgBkDv42hjsq6+9DG+f3s=; b=YSEWE9kVOggjVjNXYFMnb7RvpSvI4dzzxJy5w0DIBacINUs1mqz2Z17lCIKDEocuhn eC6YZ9JmTSTfgTd542ByIVQefNBuebKSYdswsFmDtDj1i+KbB3/7fxwo5qB5uHuJ2rZd XmCzl9tLseB5lpqW1HypJVkAJxUdt7p6PasGUiZuaqBU0GY3Gs1adTdxA9Pwpn42ZUrT rXB8wLB5/lzObehRZMDHPUcp7DeiRDM2eewNsV7lzIEY3L1HuSfifd7vAVPT7VAnQqeU 0Nn9qNOYL+ixRjg8YMcu5RIYZBHbfjk4ma3eG+t/e1zIEJAGAMrXb8B9n6+cVdpO7b6A w4lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=K4L+ARRy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id h191-20020a6383c8000000b00373d6e7e2desi506331pge.472.2022.03.02.16.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 16:31:58 -0800 (PST) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=K4L+ARRy; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7BF2722E8DF; Wed, 2 Mar 2022 15:42:06 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231297AbiCBWZR (ORCPT + 99 others); Wed, 2 Mar 2022 17:25:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229660AbiCBWZP (ORCPT ); Wed, 2 Mar 2022 17:25:15 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0299E4D04; Wed, 2 Mar 2022 14:24:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v1SczNr2OUEGHMSVwtsfX7qgBkDv42hjsq6+9DG+f3s=; b=K4L+ARRy0jjeoDRYDxLSYJyoA2 GPcd7AXGzjeySWNoJCkpTkgzq/BcZSkM1VAI+s1hk3pbUirP4FcDNLazxlZp0p4HWddoBCUtU+rPH Lk8utauxZusyL/AMGYlqusRpCJXYfAsw4nq5e2ve/M/lF6nsDPie3aQr7uztNZz+PZ7p0/zkpv+Qb rV/ZlJaltn6m2SvZxxttuIgux6NkihrWtbzqJ7y3Yr1lTp9RNc5/k7PIlrWe0uR3iuuG18dFicjO+ slTEuQmb+GxHMszCRSkLstTE1WanMGs0nqATH4zJQhg2N+CTXnQnqQ0V3ljY3M/gQYKO/wraHAmv1 iobOtIEw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPXOS-004Y56-Lv; Wed, 02 Mar 2022 22:24:24 +0000 Date: Wed, 2 Mar 2022 14:24:24 -0800 From: Luis Chamberlain To: Aaron Tomlin Cc: pmladek@suse.com, christophe.leroy@csgroup.eu, cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, void@manifault.com, allen.lkml@gmail.com, joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name, jason.wessel@windriver.com, daniel.thompson@linaro.org, atomlin@atomlin.com Subject: Re: [PATCH v9 10/14] module: kallsyms: Fix suspicious rcu usage Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> <20220228234322.2073104-11-atomlin@redhat.com> <20220301165229.5pwxyhxonbw5za3i@ava.usersys.com> <20220302170202.lsz2mqmll6gshuwr@ava.usersys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220302170202.lsz2mqmll6gshuwr@ava.usersys.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 05:02:02PM +0000, Aaron Tomlin wrote: > On Tue 2022-03-01 16:52 +0000, Aaron Tomlin wrote: > > Petr, > > > > Any concerns? > > > > Unfortunately, I didn't make enough time to test. > > Petr, > > $ sudo ./test-livepatch.sh > [sudo] password for atomlin: > TEST: basic function patching ... ok > TEST: multiple livepatches ... ok > TEST: atomic replace livepatch ... ok > > - dmesg output excerpt Since you're going to send a v10 can you also add the livepatch to MAINTAINERS? :) Likewise if you see other files which can use help in maintenance review, let's go for that. We're in no rush for the merge window as we'll be skiping the next merge window. So all this just needs to be thought well and tested well. Luis