Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220302173114.927476-1-clg@kaod.org> <20220302173114.927476-11-clg@kaod.org>
 <CACPK8XeDBCMCEO4=w7qUQxsYiFUDKPAuBhXW5Sr6=UHM_GRsWA@mail.gmail.com>
In-Reply-To: <CACPK8XeDBCMCEO4=w7qUQxsYiFUDKPAuBhXW5Sr6=UHM_GRsWA@mail.gmail.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Wed, 2 Mar 2022 22:48:58 +0000
Message-ID: <CACPK8Xd6VJLuWsvSjYrQ-y=yS+yR7vjdWECfsd2W9_J7e09K-A@mail.gmail.com>
Subject: Re: [PATCH v2 10/10] ARM: dts: aspeed: Enable Dual SPI RX transfers
To:     =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>
Cc:     linux-spi@vger.kernel.org,
        linux-mtd <linux-mtd@lists.infradead.org>,
        Mark Brown <broonie@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Pratyush Yadav <p.yadav@ti.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Andrew Jeffery <andrew@aj.id.au>,
        Chin-Ting Kuo <chin-ting_kuo@aspeedtech.com>,
        devicetree <devicetree@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 2 Mar 2022 at 22:45, Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 2 Mar 2022 at 17:31, C=C3=A9dric Le Goater <clg@kaod.org> wrote:
> >
> > All these controllers support at least Dual SPI. Update the DTs.
> >
> > Reviewed-by: Joel Stanley <joel@jms.id.au>
> > Signed-off-by: C=C3=A9dric Le Goater <clg@kaod.org>
>
> Thanks. I'll apply this to the aspeed tree now.
>
> Did you also have a patch to add a second flash chip to the AST2400 FMC?

That was a reference to the discussion on the openbmc list with Tao. I
was mistaken; the flash chips are there, but they lack the
spi-max-frequency property.

>
> > ---
> >  arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++
> >  arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
> >  arch/arm/boot/dts/aspeed-g6.dtsi | 8 ++++++++
> >  3 files changed, 21 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspee=
d-g4.dtsi
> > index 9ae67e83cf60..31e6569db97e 100644
> > --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> > @@ -64,27 +64,32 @@ fmc: spi@1e620000 {
> >                         flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> > +                               spi-rx-bus-width =3D <2>;
> >                                 spi-max-frequency =3D <50000000>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@2 {
> >                                 reg =3D < 2 >;
> >                                 compatible =3D "jedec,spi-nor";
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@3 {
> >                                 reg =3D < 3 >;
> >                                 compatible =3D "jedec,spi-nor";
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@4 {
> >                                 reg =3D < 4 >;
> >                                 compatible =3D "jedec,spi-nor";
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > @@ -100,6 +105,7 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspee=
d-g5.dtsi
> > index c3e0a8e13c8a..29bf017899b6 100644
> > --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> > @@ -66,18 +66,21 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@2 {
> >                                 reg =3D < 2 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > @@ -93,12 +96,14 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > @@ -114,12 +119,14 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspee=
d-g6.dtsi
> > index 1ad05dde19d2..ce93c56a21a7 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -106,18 +106,21 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@2 {
> >                                 reg =3D < 2 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > @@ -133,12 +136,14 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > @@ -154,18 +159,21 @@ flash@0 {
> >                                 reg =3D < 0 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@1 {
> >                                 reg =3D < 1 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                         flash@2 {
> >                                 reg =3D < 2 >;
> >                                 compatible =3D "jedec,spi-nor";
> >                                 spi-max-frequency =3D <50000000>;
> > +                               spi-rx-bus-width =3D <2>;
> >                                 status =3D "disabled";
> >                         };
> >                 };
> > --
> > 2.34.1
> >