Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <c916d9a9-fa9f-104e-8078-083d96f74343@axentia.se>
Date:   Wed, 2 Mar 2022 23:45:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] i2c: mux: demux-pinctrl: do not deactivate a master that
 is not active
Content-Language: en-US
To:     Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <eca2bf56-7abd-55c0-a423-dce47c38fd66@axentia.se>
 <Yh/e4OzQ/hYSb+dg@ninjato> <Yh/gHSaRNs9Z8La2@ninjato>
From:   Peter Rosin <peda@axentia.se>
Organization: Axentia Technologies AB
In-Reply-To: <Yh/gHSaRNs9Z8La2@ninjato>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWlMbys1cG5YdXJmZzBJSFUwM1FDMm13TjI1M2EvZjYrSkI1RFdsNnZtY0Z3?=
 =?utf-8?B?TWwwelI4SUJZeWYxR09BRnZmRXJpUHVLa2d6Z00rWVZMZ203dkdhOXVKZXZn?=
 =?utf-8?B?Q3IwNklmRzdqTkdLV2hFcDJtYlB1MzlIbHJPOFRGUUdKMDM5RnlUSUxXNHFS?=
 =?utf-8?B?dzJLT283U2NnVHIzWG4vMHZDdjE4Z3gxS0FvcnRqSkZMUDBsTUQxVzdVSkxv?=
 =?utf-8?B?OTJZYzByTTBGVHFnQ21UalJjZXB1MENBMC9kZTRxbXY0SGQ5VjZFOHhCcjZQ?=
 =?utf-8?B?b1paQnVmZHc5MjA5Z1BQUXZxS3p6Z2dUMk5qbGp2R1NicWtwRTRRcTRyY0Er?=
 =?utf-8?B?KzVuWFM0MTZqY2NnNmFHUitGNjRLM2lWL0VRdTJyZWhZQmRHMmZxQjBPdkNI?=
 =?utf-8?B?b1VUMkd3YW5JOEFaT2VhRVVYdk96a1J0aUloYWFSWmdURE5OVjlNZWFpejhG?=
 =?utf-8?B?RTZZS1VrUTIyeHJEYlVqZW5USlViUVA1eEhwb0hlRTJHdkdaNkoyUUZneUxO?=
 =?utf-8?B?eS9XeDhWV1AvS29FZTA0aDczN20zZ1hsRG1WNkc4aUsvMzZxSzJDTUJrTDI0?=
 =?utf-8?B?eHF4dE5ocEV5anNXaCs2a3dYSm9SNkEzTE9FQmpLdzdwc2xRSVhpQjArME1G?=
 =?utf-8?B?SFdlNmViR0xCeS8rNm96YW5QTERvd3V0Q0xoY3owZERRK0VBMGhMUEdsTE5X?=
 =?utf-8?B?Z1dzaE5jOGNNcW1nSFZrUWtqVFN1bVBQMk9QS3B6Qkl1YXhnZXZuNDhmY1lB?=
 =?utf-8?B?ZEVnVk9Ya2M3a2s1ZkxjVWlWWENUMEFrdE9IN2EvTEtkWDgwaFFjdmkvMUQ5?=
 =?utf-8?B?QjJxNjJ1ZVJhWjVKMXZkSEdQdHRCSWxPMWVGaUhqdUo5eU5ma1EyUXd5VnRB?=
 =?utf-8?B?ZEZWUEZTNFFqVVVIcSsrZnN3OEZ6ZXFrOXNhVllLMG82RVdGaWhjRDRSQStN?=
 =?utf-8?B?YzBzNnRCRE4zNmlaUTljcW1uK05TV1dtVDJPNm5salNIRDI1RGxlV3VsZjZV?=
 =?utf-8?B?aEVscnJQYVdjTDROTkswLzJjZEdWdm5xbTB1UE1FdnJCcHp6ODNqMmEyamk3?=
 =?utf-8?B?dWliNkI5UWtvS29rQ2dvMTF3eWFPb2gxUkZZbVlLOEJjdXNmdHFXWkdhNEls?=
 =?utf-8?B?NXRUYUJqUlBwOTRBREZ4eVFXR0pmS0hSUlhRTm9naHNHRnNWbXpndnJ4elV6?=
 =?utf-8?B?cFlGWVdia3kzMmt6SjgwTVV1OFJhSkIvalZZcHRNalhuYkNoanp1WnVreWZT?=
 =?utf-8?B?Tm4wS3BjS3pxR1ZpM1dpT3Fld0h1RVY1elFYOEQ5U0U4SlEzUThOb3VnMVpX?=
 =?utf-8?B?eE8xUVEzZHJHWjU4YzlEUE9iRzVjNzlqNVlJc3hOYWk5Qm1RVS84Q3FzajJM?=
 =?utf-8?B?ZXZ4T0hLY1FMRGFDeEVhdjRicnRCUDVyMzBNVWhUMGNKQVlXOWt3MDRJUmtq?=
 =?utf-8?B?ZVRVK2xEbk9Icnp6UU5mOVJudjFubUsrMnlMbWEySGx4Unp1dnNLMHRGWjly?=
 =?utf-8?B?MDZrZWdRY09ya3JMK0dEcFJWNFcrWk9CQkZJN01haDQ0ZWZRZ3dQMXpPd0dD?=
 =?utf-8?B?VkVReDY4WTJGcVRTZVhGTzc2MmdQTUtrT25HeWRYamI3d2VLN0JZRDFQVUJX?=
 =?utf-8?B?WnR5QS9Nazl6QVh3Qit5b1l2NWExNDZkWU00bUx1OHk5WXZINktZZHE0VkxV?=
 =?utf-8?B?eUF3R0pvZXRvaVFYTmd1OGRpRUhVZEx6VXhoRy8ydEU0YWs1ZW43aExVMUd6?=
 =?utf-8?B?WktuZmtqQUpleUVQeEllZmMwZHEvbkpYeFZlVXRDMXg2cEpkNjkrZEF1M3lG?=
 =?utf-8?B?bnV5MSt2V1h0SmFweWpEc0MzRVdyZFlCNHVGVzFPbngrb2c5ZEU0SHdzYjRk?=
 =?utf-8?B?bGNzR2ppcjU4OHVwSkpDMEhXVERQMFlvSVVIQUtiN2xBYldGdmd5OGdpZW9a?=
 =?utf-8?B?VlpHWEgwRGFYUExqazlGZUZOb0N0NWh5ODB6S0s3OFpLamJsa2NHUGlnOEh1?=
 =?utf-8?B?N1BLK2NTWkNOR1RBSGR2RlB3aXJpMGZNS1JDTzlIY2NFTEJzNGdlUUVBSzZW?=
 =?utf-8?B?akdkcHF4TEVmMTZXN3VVYXdYQnYrdU53UzhrdnMrbzNDdmZXVjN5UEsydDlM?=
 =?utf-8?Q?P2ig=3D?=
X-OriginatorOrg: axentia.se
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f04baf2-e81c-41ef-8cbf-08d9fc9e6d10
X-MS-Exchange-CrossTenant-AuthSource: AM0PR02MB4436.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 22:46:01.8687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dIBqVc/Th25f9/94dbW5lNmbeSQ0khyPBnOx4sNgd9LbpO+H+RMRZ177og2qnABR
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB6109
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-03-02 22:22, Wolfram Sang wrote:
> On Wed, Mar 02, 2022 at 10:17:20PM +0100, Wolfram Sang wrote:
>>
>>> Attempting to rollback the activation of the current master when
>>> the current master has not been activated is bad. priv->cur_chan
>>
>> But the master is activated?
>>
>> 259         /* switch to first parent as active master */
>> 260         i2c_demux_activate_master(priv, 0);
>>
>> Or am I missing something? :)
> 
> But _this_ code is affected by the problem you describe, or?
> 
> 237                 if (!adap_np) {
> 238                         dev_err(&pdev->dev, "can't get phandle for parent %d\n", i);
> 239                         err = -ENOENT;
> 240                         goto err_rollback;
> 241                 }
> 

Yes. That is the error path that, if taken, results in the faulty
deactivation. Sorry for not spelling it out...

Cheers,
Peter