Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932650AbXBSUwG (ORCPT ); Mon, 19 Feb 2007 15:52:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932652AbXBSUwG (ORCPT ); Mon, 19 Feb 2007 15:52:06 -0500 Received: from caramon.arm.linux.org.uk ([217.147.92.249]:4581 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932650AbXBSUwE (ORCPT ); Mon, 19 Feb 2007 15:52:04 -0500 Date: Mon, 19 Feb 2007 20:51:53 +0000 From: Russell King To: "Michael K. Edwards" Cc: Jose Goncalves , Frederik Deweerdt , akpm@linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: Serial related oops Message-ID: <20070219205153.GH27370@flint.arm.linux.org.uk> Mail-Followup-To: "Michael K. Edwards" , Jose Goncalves , Frederik Deweerdt , akpm@linux-foundation.org, linux-kernel@vger.kernel.org References: <20070220132909.GD566@slug> <20070219134539.GA27370@flint.arm.linux.org.uk> <20070220142442.GF566@slug> <20070219143520.GB27370@flint.arm.linux.org.uk> <20070220144814.GJ566@slug> <20070219150508.GD27370@flint.arm.linux.org.uk> <45D9D073.7020701@inov.pt> <20070219164200.GF27370@flint.arm.linux.org.uk> <45D9E46C.4030408@inov.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 25 On Mon, Feb 19, 2007 at 12:37:00PM -0800, Michael K. Edwards wrote: > What we've seen on our embedded ARM is that enabling an interrupt that > is shared between multiple UARTs, at a stage when you have not set up > all the data structures touched by the ISR and softirq, can have > horrible consequences, including soft lockups and fandangos on core. Incorrect. We have: 1. registered an interrupt handler at this point. 2. disabled interrupts (we're under the spin lock) So, no interrupt will be seen by the CPU since the interrupt is masked. The test is intentionally designed to be safe from the interrupt generation point of view. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/