Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <20220226123755.85213-1-masahiroy@kernel.org> <boris.20220302145825@codesynthesis.com>
In-Reply-To: <boris.20220302145825@codesynthesis.com>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 3 Mar 2022 09:01:22 +0900
Message-ID: <CAK7LNAS8GO=XzzaVze8y7142Os6J_htBNVV+6kwiXjSxWfnPDw@mail.gmail.com>
Subject: Re: [PATCH] kconfig: change .config format to use =n instead of "is
 not set"
To:     Boris Kolpackov <boris@codesynthesis.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 2, 2022 at 10:17 PM Boris Kolpackov <boris@codesynthesis.com> wrote:
>
> Masahiro Yamada <masahiroy@kernel.org> writes:
>
> > With this commit, Kconfig will output disable options in a more natural
> > form, "CONFIG_FOO=n".
>
> While I agree with the overall direction, I was wondering how this
> relates to string and int/hex options. It appears that they either
> have a value or are not written to the .config at all, for example,
> if the option is disabled via the `depends on` attribute. At first
> I thought this would be inconsistent (i.e., =n for bool and omitted
> for string), but it appears a disabled bool option is also omitted.
> Hopefully the fact that sometimes a false bool option is =n and
> sometimes it's omitted won't surprise anyone.


Options with unmet 'depends on' are all omitted in the .config
It is consistent for all types.


>
> Reviewed-by: Boris Kolpackov <boris@codesynthesis.com>


--
Best Regards
Masahiro Yamada