Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <bacae45c-9f8e-456b-1036-7f68e1e4374d@oracle.com>
Date:   Wed, 2 Mar 2022 19:20:38 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.6.1
Subject: Re: [PATCH v4 2/2] xen: delay xen_hvm_init_time_ops() if kdump is
 boot on vcpu>=32
Content-Language: en-US
To:     Dongli Zhang <dongli.zhang@oracle.com>,
        xen-devel@lists.xenproject.org, x86@kernel.org
Cc:     linux-kernel@vger.kernel.org, jgross@suse.com,
        sstabellini@kernel.org, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, joe.jin@oracle.com
References: <20220302164032.14569-1-dongli.zhang@oracle.com>
 <20220302164032.14569-3-dongli.zhang@oracle.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220302164032.14569-3-dongli.zhang@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkE5UVRaQ0lqdjY4VVE0K3pVeXVtZDM3dkhWQ3VzR1E3cU9Xb1RCWHpaendn?=
 =?utf-8?B?cS9mYmtwdHFTSmtnK2NNbUN4ZzhEbDRtNGM3R1NrUWFPUUtRU2dhR3JSWTlL?=
 =?utf-8?B?Y2RrYTR5WURabm1wbVlVUGZteU1rQkxYQzBudGROdUJaU243L3BBUGhrQkdD?=
 =?utf-8?B?R0t0czIvaWV6VkVPZzBQVVZ6MkRQbVZhUTVHNU9lVlpNWHlnZ3FpV0wwR2RC?=
 =?utf-8?B?TzFTNXFQcU1BOHhZc0JRbHUyMjZkakg4a3g0anNHWGVxNDE2S01VS20yOUEy?=
 =?utf-8?B?VWh3UVo4R1BaeHdlSTJkR3dwV1pmb09CUHlEaFhlcmcxQjhtOHZLaytkYmVt?=
 =?utf-8?B?TTA3NEFCZHUvRWxtWW54MmRRa0FuYWZXTmdKVWJvZ3JmNkwxSjR2ZU1MQTc4?=
 =?utf-8?B?dmt2UlVKSUdBdENvdjJGZk5TeFFQWG16RGtqSEdPUmU0ZHhGSHd3STVrNXE2?=
 =?utf-8?B?TG1FeW93aUFuellHdE9IMk15SHVWY2k1Q3RYR3pMT2gxc3huNlVqK0JWZDNX?=
 =?utf-8?B?MHhqSmtEU1BCbVlXbithUVNCTjFJS1pFZHFLdnFVSm1oSXpUOFdLaVQ5RDl0?=
 =?utf-8?B?bFV0aVFpWFI1OG1Ka0VmVEpBSTFCaXZpcWEvcEI0OHlJblh1bHZpMzBsNXFQ?=
 =?utf-8?B?a1QrRnUzOWhJWUhCdmhvTkliZG0zU1dXVFhzVFVFWnhGZnhSNEp6TS9QQkdu?=
 =?utf-8?B?V1NxejhxYTA1ZC9SbDlITXV2MEluZVdnMjhod09YRnY3N3NZR3d0R3h3a1BG?=
 =?utf-8?B?S0pndTk2WmUraGdNaUJQY0QwTmMvUEJQUE1kek9jS2F2NEdlTEtlMkd3c2hr?=
 =?utf-8?B?V3B1VE42NjB3MStYT0h4dGlNMTdBaDVBdiszQ0pqR1lRdFliaFQ4TThXUTZB?=
 =?utf-8?B?R1BtZDlFY1R4SkRMQ1NQcTNRVHFuSnZLbC93REF3QWlvbExMUGZNWHk5WGlD?=
 =?utf-8?B?a3JKRHZRRXpBTUlaa014eTB0ZGVuc2x3TkRyYm9paXJ3c0VaTkpYTmZEbGh2?=
 =?utf-8?B?N2Q1bnpyWGRESnV0cFphb21zcTdJZnB6Y3FNd1IzMmM3Z3poaTAwRVVPWi9t?=
 =?utf-8?B?bDZXWkdKTGx3bjZpUlI4Q0pLNy9mVEY5c0VPcXpHRHRGMDczME9qcFRYdTJz?=
 =?utf-8?B?ZmlLMVB1cndGUGVmTjk1dDhvZVdsMU53dTA3bjBYOFFDYVJHSWhaYkZFcXVT?=
 =?utf-8?B?T2x3ZXU4dnBqSmE4MlZ2MzE3T2tPak1nc1JwbkFvWHBVeElUcWVLOEY2VzVS?=
 =?utf-8?B?V04ySWJodHFVQm5HU1AvWEZlblMzdzB6OFRxOHpjeWpaYzROZXB5cE04eTJz?=
 =?utf-8?B?cW92aW45Vnd4WVpCZUlEdytWY0ZmeGMwdXBua2Q5MjQzc3BKVXBwQ3d3c1Y1?=
 =?utf-8?B?cmJSdUNUR2w0ZHp6a2xxRVVJcm5YbFBkMkQxS1BFTG9NWXZNR0RqZUtNampz?=
 =?utf-8?B?Vk9OajhoSHNyb1ZqTzZFNThibksvSEFZMkZaWjB6bUZVL3RlcnhxdWpsTE9S?=
 =?utf-8?B?UkozcGhXY0crWWdHWmQ2Zy95S3pFNnN4eC9xcGxFRmJldU8rbDhtd0FQWGZj?=
 =?utf-8?B?UU5ySFRpQTJrQUluamN6bkRyc2tMNVFkVmZuYXh5OUlDaVJNbVpkVEhBMDRn?=
 =?utf-8?B?V09yT0llaTFVNXFRN1dYSWc2RDgyeCtIemVFYTZGa3AyWGllMVpheERqR0o5?=
 =?utf-8?B?T1dzRG83QkNXYTIrWklaQVRoVHRGRlJWNm5ySkh4QThFanZwNnhhaUE1bmd5?=
 =?utf-8?B?TSsvRCtBalVhdjBUK1R4Z3l5VkJ3dkJuYWJoajhyWThndDFqVVcvMjdtUkl6?=
 =?utf-8?B?MzF6cGEyc2pva0lpdzlPdHIvdHhLeldZU1I2SlgyZWg0bEpiYmIzdzZzSjN1?=
 =?utf-8?B?TXcwbW5xcW9ScldpTFdzbjBTMkxuRTk4RjVaZFFWcTRFVFlXa0NCSi9hQjBq?=
 =?utf-8?B?ckFxVHR1empkelBOMXFFbnNpcjhsZUZ3d0NHYW8xeGhYbTZvQmVSNVV2ZXhp?=
 =?utf-8?B?clUwYmlOTWFNajdPNnc4bmxGa3o0QmNLSmU1QXUrdVptd0g1eDhJbTBscHp5?=
 =?utf-8?B?YkNjNUxlUk40RkIvZlhUbVpYVWN5eVFXOXkrbFZZTWpxSFltYWRxSGpsUmRv?=
 =?utf-8?B?KzVxZDBpYU55cS83eE5IeVpmcWVqeWdmL2NJb2hzRE10RmptbVVOMi9weGRz?=
 =?utf-8?B?YkZaaysrblE1MHdnSnRXN1pNUFhidHNZbndhcDJZb3cvRFBNc0MycTdyNzhH?=
 =?utf-8?B?Z1crYnNJU3FkYzdZUWk2UDUxK2dRPT0=?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d98bc3ed-e527-4c71-c59a-08d9fcaba80f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 00:20:43.9942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hWCjmova3d4zTuCrrEKG9VfCssDqhkx5x71FMioIHZ7XFIkbbTh4yFrpnuIfbLWAIwsae42I+G9YMOQctCniaHeGLkY+FDjuRgWxIfhCgY8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4225
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 mlxscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000
 definitions=main-2203030000
X-Proofpoint-GUID: AqtJ6_hgO6k6EjG8lvbXH9wk7Kf5d7O5
X-Proofpoint-ORIG-GUID: AqtJ6_hgO6k6EjG8lvbXH9wk7Kf5d7O5
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/2/22 11:40 AM, Dongli Zhang wrote:
>   void __init xen_hvm_init_time_ops(void)
>   {
> +	static bool hvm_time_initialized;
> +
> +	if (hvm_time_initialized)
> +		return;
> +
>   	/*
>   	 * vector callback is needed otherwise we cannot receive interrupts
>   	 * on cpu > 0 and at this point we don't know how many cpus are
>   	 * available.
>   	 */
>   	if (!xen_have_vector_callback)
> -		return;
> +		goto exit;


Why not just return? Do we expect the value of xen_have_vector_callback to change?


-boris


>   
>   	if (!xen_feature(XENFEAT_hvm_safe_pvclock)) {
>   		pr_info("Xen doesn't support pvclock on HVM, disable pv timer");
> +		goto exit;
> +	}
> +
> +	/*
> +	 * Only MAX_VIRT_CPUS 'vcpu_info' are embedded inside 'shared_info'.
> +	 * The __this_cpu_read(xen_vcpu) is still NULL when Xen HVM guest
> +	 * boots on vcpu >= MAX_VIRT_CPUS (e.g., kexec), To access
> +	 * __this_cpu_read(xen_vcpu) via xen_clocksource_read() will panic.
> +	 *
> +	 * The xen_hvm_init_time_ops() should be called again later after
> +	 * __this_cpu_read(xen_vcpu) is available.
> +	 */
> +	if (!__this_cpu_read(xen_vcpu)) {
> +		pr_info("Delay xen_init_time_common() as kernel is running on vcpu=%d\n",
> +			xen_vcpu_nr(0));
>   		return;
>   	}
>   
> @@ -577,6 +597,9 @@ void __init xen_hvm_init_time_ops(void)
>   	x86_cpuinit.setup_percpu_clockev = xen_hvm_setup_cpu_clockevents;
>   
>   	x86_platform.set_wallclock = xen_set_wallclock;
> +
> +exit:
> +	hvm_time_initialized = true;
>   }
>   #endif
>