Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <e0ecfbdf-2d9e-4e2e-f538-fab115eaf4da@oracle.com>
Date:   Wed, 2 Mar 2022 16:25:24 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 1/3] mm: hugetlb: disable freeing vmemmap pages when
 struct page crosses page boundaries
Content-Language: en-US
To:     Muchun Song <songmuchun@bytedance.com>, corbet@lwn.net,
        akpm@linux-foundation.org, mcgrof@kernel.org,
        keescook@chromium.org, yzaikin@google.com
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, duanxiongchun@bytedance.com, smuchun@gmail.com
References: <20220302083758.32528-1-songmuchun@bytedance.com>
 <20220302083758.32528-2-songmuchun@bytedance.com>
From:   Mike Kravetz <mike.kravetz@oracle.com>
In-Reply-To: <20220302083758.32528-2-songmuchun@bytedance.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3FUdU0zOU4zRGE4S251UTVIUk5nUXlwdE1UYld4U053OElEMUV2Ti9oREQy?=
 =?utf-8?B?VURwQ3hXNE5yc0FLeGw5c0xVOS9kRWIwdG8vMEtRTnduZi9aMkF6VmQxcFhs?=
 =?utf-8?B?YjlpcFFCcjhkWlhldU9QWWlWUllBcjN2cTJjVnNxSUpjMXpaUU5GQkdCeVZT?=
 =?utf-8?B?WUtwV3dqd3ErRGorV0FvaDg0NWtPbWF5eTNhb2dUNWxuTHBSakNma1BzQXpj?=
 =?utf-8?B?dkIweXNtUHBhYzFPWTU4WlZVSWhvd1FLTDRKY05LcThSOEx5SjFacVNrdWsy?=
 =?utf-8?B?OFhXeW5ramthMEh6T1lFV2o2dEtNYlY3UkIyL0dQeCtRc2xodWVFbnUrK1Jx?=
 =?utf-8?B?Ulpmb3FLeWxxK3RXSkpVeTVPdG5abk9Sb3ZZdHZ0a253SUlDN0hHQWQveEtz?=
 =?utf-8?B?SFhCVVlpaS9qcmpYRituSFV5YW5mbWtzQXIwM3JZQ1BnamRIbGtVSFdYRjl5?=
 =?utf-8?B?NnlqVWIzZmdIcExEa243bW1yVk13REloODJCU1FxVUdGWEhXazBPdlkwMjlT?=
 =?utf-8?B?cXY0T0lNVUw3azMyS0pSSzY3bHZRdkFnbUEzMys4NEZhQ2NBWVdyUmJUN1Jk?=
 =?utf-8?B?S1VjckYvTXVvSzRydm0waERkQXZPV2hoUEJITkFyUTN2c2h3ZnZZa0RzbUtH?=
 =?utf-8?B?MU5udUVKUUxXc0RXUGhFcU9UV0ZEOUhpNjgzNG1KV1hTeFg2dmF0dWNTb2h5?=
 =?utf-8?B?eEhOejlaOVVZM2pEWlU3UzNaWkVRUkpZUEhtOTRaamVyeWRhcTl1bUZ5UzZw?=
 =?utf-8?B?U2cyU0Qxa1ljaDhzL3RWVWdkcTI1WlFmaWtrbUVXZVk4aEVVV00xbVZ6WXNQ?=
 =?utf-8?B?b1UrNFpVdUgwamhDNXlPL1crOEIyWTZHdkNEb0k3a3BvMG5vbnNNdkx5ZE5V?=
 =?utf-8?B?bzRYZzNlZ3B1M3ZJcTYwUmEwVmJjYTdYb25lNkhIRDBEL2E2Vm1PRjRYRVBB?=
 =?utf-8?B?d01lcTFuRDFFN0kxNjJkR1F0ai9rOGJCWFRidzlramZVbDhGUnE5SU5xTVFx?=
 =?utf-8?B?TGtndkV5WFhxMW44endPQ0ttWWtaejhsN21yQW50eUZyREZqT0pFT0xhR1pQ?=
 =?utf-8?B?SmpNSG81OGpZbEp0WXE2NUR6cDMwR0FBMnpJNk5WSU0xdmNlcWxvRS9WdWla?=
 =?utf-8?B?YmJETFJPUnVtblhFN3lndVYvQWhnOTlJRjNUclU1eS9CaHh1eWFzeDhKK1JH?=
 =?utf-8?B?UUpvNEhnaFNLMlJQcDZiQVVBall2Vmo5bVUxUHNQcTRHT0dGSWh2TGp4Qnl0?=
 =?utf-8?B?NlVvbGY0aWJrd1g4N1J6OHJoaXVVLzBrcHJmMW9mRjZ4VWtsbi9VK2V2NU1G?=
 =?utf-8?B?QzB0VWpQS2NFYVNZcGwvYSttejRIaVBzZjdPT3RFWEZWZWpETHFCeWtNU1Vx?=
 =?utf-8?B?TWFwN3ZRYVRGUnRHK2tGbGM2RnBlQ096SUE3b2Q4ZzBza3A4NGxjR29ITVdm?=
 =?utf-8?B?OUFGUlVmZkhiTURLalBZdDBnTmRGRjhWRjE0NXZhaThzc0ZhWjRjYjIzYjJC?=
 =?utf-8?B?dmVKMlJ4dVJhS2hObTJQMTZoNGxXb2szQUIrWTlENGNuVUxDRzFoM3N1cjM3?=
 =?utf-8?B?Y1NIVUNnUURxOEZXaXc1TDFrSzNaS2xmZFZkNWoycGdkaW5PK1NSMEtLa1lM?=
 =?utf-8?B?NzBSZmcydy9rUnI5TlM5Q1o3WTdBWWhFTzdObi9GelVteTcweWYxNm9LTG9O?=
 =?utf-8?B?VGNaYko1c0xiRGxHSEhMSitVek5xRlJHNjhrN084dmc1bEZRSWJScnJpN3VX?=
 =?utf-8?B?TWFaUHNDdXhuK2xhZlViMUZhUWdOak9MRkhWclR0MnJHWnlpNG5zNU0vQUpD?=
 =?utf-8?B?SEtCWC90R1RNdTRPWC8yMHpXTTN0YUphSU03VCtEMW5DR3ZFVmlRMGVhU3hy?=
 =?utf-8?B?bFZxZUNRRzBaUXJzd3VXMTYwR1pGbm1CZjVQZHVBUllXSUVnQ2Y5QnZxdGwr?=
 =?utf-8?B?UkdFRjQwTzRuRDc4enAzSytZOWtJWlJ0OTQ1MGhQU2pHR1YxUmZWMXExcmFD?=
 =?utf-8?B?UStKSWl6dmI5eG1TaGZCTHF3VWhXV3N3eDFUdHJ4ZzRlbE93RVRCY1E4Z2hH?=
 =?utf-8?B?V0ljd21xU1h4b1JGZVRiK0Y3c2lXVElGQnhwTlFtSC8xZE5iWGdkQkxUVkNE?=
 =?utf-8?B?RFRZNzRIVk0wSWtGQTJiY0V1dnZ6ckRjTnEyMFFmcGlENXBSdDIzNExMRWdD?=
 =?utf-8?Q?MgGGODs0UGIUwRdlWhc6OgY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15279707-a7d0-4f74-3773-08d9fcac51f2
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 00:25:29.3100
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xp0Hx4xV68saUGPDOALxbeirzU4jJ54vjJN/izlAtGqaE5XdmYDNIoXWZq09CPFvI7/X9kJJuiT+2ZVuEBwJDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2265
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10274 signatures=686787
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2203030000
X-Proofpoint-GUID: jrJia7rU9kEPbmxZvpEKzFkD7iclYLap
X-Proofpoint-ORIG-GUID: jrJia7rU9kEPbmxZvpEKzFkD7iclYLap
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/2/22 00:37, Muchun Song wrote:
> If CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON is enabled and the size
> of "struct page" is not power of two, we cannot optimize vmemmap pages
> of HugeTLB pages. We should disable this feature in this case.

I'll let you reply to the question from Luis, but IIUC there is no issue
today as "struct page" is certainly a power of two.  This is more future
looking.  Correct?

> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index b3118dba0518..836d1117f08b 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -121,6 +121,17 @@ void __init hugetlb_vmemmap_init(struct hstate *h)
>  	if (!hugetlb_free_vmemmap_enabled())
>  		return;
>  
> +	if (IS_ENABLED(CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON) &&
> +	    !is_power_of_2(sizeof(struct page))) {
> +		/*
> +		 * The hugetlb_free_vmemmap_enabled_key can be enabled when
> +		 * CONFIG_HUGETLB_PAGE_FREE_VMEMMAP_DEFAULT_ON. It should
> +		 * be disabled if "struct page" crosses page boundaries.
> +		 */
> +		static_branch_disable(&hugetlb_free_vmemmap_enabled_key);

Should we possibly print a warning here as in the routine early_hugetlb_free_vmemmap_param?  This is called once per hstate, so
perhaps pr_warn_once.

-- 
Mike Kravetz

> +		return;
> +	}
> +
>  	vmemmap_pages = (nr_pages * sizeof(struct page)) >> PAGE_SHIFT;
>  	/*
>  	 * The head page is not to be freed to buddy allocator, the other tail