Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <1646203686-30397-1-git-send-email-baihaowen88@gmail.com> <f519c59e-fdf0-14e8-8cce-c6c2d19cff8b@gmail.com>
In-Reply-To: <f519c59e-fdf0-14e8-8cce-c6c2d19cff8b@gmail.com>
From:   lotte bai <baihaowen88@gmail.com>
Date:   Thu, 3 Mar 2022 09:38:10 +0800
Message-ID: <CAFo17Pj2oi1fdgc=ypKZj+J0H8A4uettkk=trzq--9qe_8QYaQ@mail.gmail.com>
Subject: Re: [PATCH v2] net: marvell: Use min() instead of doing it manually
To:     Heiner Kallweit <hkallweit1@gmail.com>
Cc:     sebastian.hesselbarth@gmail.com, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Yes, I have compiled at local, either unsigned and U is pass.  Thank
you for your kindly reminder.

Heiner Kallweit <hkallweit1@gmail.com> =E4=BA=8E2022=E5=B9=B43=E6=9C=882=E6=
=97=A5=E5=91=A8=E4=B8=89 19:06=E5=86=99=E9=81=93=EF=BC=9A
>
> On 02.03.2022 07:48, Haowen Bai wrote:
> > Fix following coccicheck warning:
> > drivers/net/ethernet/marvell/mv643xx_eth.c:1664:35-36: WARNING opportun=
ity for min()
> >
> > Signed-off-by: Haowen Bai <baihaowen88@gmail.com>
> > ---
> >  drivers/net/ethernet/marvell/mv643xx_eth.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c b/drivers/net/e=
thernet/marvell/mv643xx_eth.c
> > index 143ca8b..e3e79cf 100644
> > --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
> > +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
> > @@ -1661,7 +1661,7 @@ mv643xx_eth_set_ringparam(struct net_device *dev,=
 struct ethtool_ringparam *er,
> >       if (er->rx_mini_pending || er->rx_jumbo_pending)
> >               return -EINVAL;
> >
> > -     mp->rx_ring_size =3D er->rx_pending < 4096 ? er->rx_pending : 409=
6;
> > +     mp->rx_ring_size =3D min(er->rx_pending, (unsigned)4096);
>
> Don't just use unsigned w/o int. Why not simply marking the constant as u=
nsigned: 4096U ?
> And again: You should at least compile-test it.
>
> >       mp->tx_ring_size =3D clamp_t(unsigned int, er->tx_pending,
> >                                  MV643XX_MAX_SKB_DESCS * 2, 4096);
> >       if (mp->tx_ring_size !=3D er->tx_pending)
>