Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <0a159b65-cb80-c8eb-7ad1-24b83813531f@nvidia.com>
Date:   Wed, 2 Mar 2022 17:47:15 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH RFC 12/13] mm/gup: trigger FAULT_FLAG_UNSHARE when
 R/O-pinning a possibly shared anonymous page
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Jason Gunthorpe <jgg@nvidia.com>
Cc:     linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hughd@google.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        David Rientjes <rientjes@google.com>,
        Shakeel Butt <shakeelb@google.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Yang Shi <shy828301@gmail.com>,
        "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
        Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>, Jann Horn <jannh@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Nadav Amit <namit@vmware.com>, Rik van Riel <riel@surriel.com>,
        Roman Gushchin <guro@fb.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Peter Xu <peterx@redhat.com>,
        Donald Dutile <ddutile@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Oleg Nesterov <oleg@redhat.com>, Jan Kara <jack@suse.cz>,
        Liang Zhang <zhangliang5@huawei.com>,
        Pedro Gomes <pedrodemargomes@gmail.com>,
        Oded Gabbay <oded.gabbay@gmail.com>, linux-mm@kvack.org
References: <20220224122614.94921-1-david@redhat.com>
 <20220224122614.94921-13-david@redhat.com>
 <20220302165559.GU219866@nvidia.com>
 <fb895ba3-9d7e-7421-d5c6-f5e7a2d1231a@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <fb895ba3-9d7e-7421-d5c6-f5e7a2d1231a@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGVJRFZJcE9UQ3ZocFhGaGFkTWY1dGpxL1pmbEdIaDRWM1lFd29yWGF5b1RH?=
 =?utf-8?B?UGIramtMdFYvaVhQaFdoS1FHVWN0UnlvYi84bnlVbndFZElsS3A4eHIxU0Jt?=
 =?utf-8?B?cGpHRStYU0szVGloZWNzSEgwcURlRmNlWnYzY01PVmR5Z21WZDF6bUhabEJ2?=
 =?utf-8?B?ekw1WTR4dEZIdUo1ejdyWWtvQkl2UCtvNjgyYjd3Y3Z4Q2h2Nk90VjVXUmsr?=
 =?utf-8?B?bjJlY2thUlVPQkQ5bWkxa2FOL3U1ZWxWM0xHOWZvclpNdFhoN1lMOTd4aEMv?=
 =?utf-8?B?T2JpNGQxYTdvRldOeEdzdEVEeFZmZDc0VTQvdTB4dWRMSXR3ZVpiWGo5Q29q?=
 =?utf-8?B?dk5TWUxRWTNmenc3Wk53YURvN01SL1pHaC9JZk5ia0E0elh1aEZrQ2ZIbnlC?=
 =?utf-8?B?c29UZ0ppdFBiSmdycmgwM0MxMGo2VWNhMUNzekc3M2V0MWtCS09hR2pQb25v?=
 =?utf-8?B?R3lIZWdUYUVnVmRpTTQ0S3lUdXNDenBGSEN5K3E3bUxxdWdXRWFyVTRNczFR?=
 =?utf-8?B?UWU1WUxuVG1tMmh5YWZQaThRclpCc3UwKzBPMTh0MzNvSGFzMUR2L2FQWkg4?=
 =?utf-8?B?UUlDdjA2alpRUlNLcmRIWnpxVkN6WG0yRWhDaklXeHhvSU5WV0V4Z291MlR2?=
 =?utf-8?B?ZU1uVDc0NTdEbHJ0V2VhaU1xQ1FBeTZna2prM09UYVV5QUczeVFpcmxXQ1FT?=
 =?utf-8?B?UmtDc2UvaHNZdTBRV0xHUWJWTDlLdDBxQjBWSkd4S1BFcE9ySWJjSHlYdVhn?=
 =?utf-8?B?OC90MGw5L2V2WE1xaTBOeDZZV2l2blF5aTJxNHlWR0EwVVRJalpuaXIyU1Za?=
 =?utf-8?B?cytZdEUwdjFhYy9pdkZlaVpLZkI1TmdraHBXaCtEMUpFV21tTlBOa05UbUlM?=
 =?utf-8?B?VTl0SHF4OGg5NXFXV0J2cmE0Q0I1TEFlQ0F0Mk1iVGQ1N3BXaGNsQzE0NkRz?=
 =?utf-8?B?THF3OTZOS3R4TG5ZY0h2ZG9JRkNzYzUwOFVzRWlpamxvUjA2MUwzZEhDNDlJ?=
 =?utf-8?B?MEIzTFhsSG1zaCsvbzdqWHBoTVR4UllZNEpZNGFad0w4YnhlT2F5ME5kU2N6?=
 =?utf-8?B?NC80UDBQYU1vMENzSlpSeDUxbUNiWnJCd2xaWlQrS1V1UE1lcFNKOSs0Uk92?=
 =?utf-8?B?ZTQyK2NFd0t1c0JCUzF1SmZrb1BUTXUvWVNVcEJsWHVPV25FeGNpVGd2Z0lW?=
 =?utf-8?B?WGU1TytQSWYyblhrUTQ0MkVabzhJMDA2aitKMWI4UXQxWjVwdmltRklPZTVq?=
 =?utf-8?B?T2JmeE4wa2hnZWlnaStYMkd2aE5lWnljM3Vndk9DcjZ2cUxSSW41S0wxRHdO?=
 =?utf-8?B?WXJJZXVoSEVDL1ZSUWtTdWtPQXJyUFpxZ1AySGdJYUdJUE02cDBvY0hLV05l?=
 =?utf-8?B?TmU3dThVR1gyazFJY3l1QXZnZno4MDJ4WDBGVWxSdUFBV21ZRmVBQy92clZy?=
 =?utf-8?B?b3BWWkJlRnp6NG41c215OU1GWUZuM0J3K1o2YUlrSzhCamtxS2J4QUV0MmJV?=
 =?utf-8?B?UmJxN1h1ZWZGdWFnamg2ZVBlQVFpWGZ4L1BtbWN0ZUMxeGZxT2R1RDNlWURm?=
 =?utf-8?B?ODVTYytacFM2RGorZTl0VHNKWVArSXJPUFVjZVBKakJBZjBrbnNHckJIR09n?=
 =?utf-8?B?eWpSd2U3aG9pUEdiV3JrSFIvTHhkNHdEaFZSVG9QT3JoaVN5MXBmOUduaDgx?=
 =?utf-8?B?bW5yTGI5QzBPMXA1Q21CK3ordzNtYlY2UmNyc0c3dmplZ2RPcy93Um0xTnd3?=
 =?utf-8?B?bFdtaTVPa1IraVluRjl0UVYyNCtSdUVvVVBqSmRkejl4OWNTd0dHTXFPd1Zy?=
 =?utf-8?B?emdaOGVpdHZEMEFDS25DdXlWTzB4RzR0blY0dmNNQmt5N1RuTThoSTlQMEFw?=
 =?utf-8?B?K3JDSDRWZ25JV0ZCWHMwR21MeUNuWjJqanlQV0xxNGNPYmx4dTNlM09OSXBD?=
 =?utf-8?B?b1NZcGxUd3B5Y3IvRjhqZmFjbWw1RnVRR1ZOenhpUjNBWFBLSnJGemJPRVdV?=
 =?utf-8?B?QnJkRzZ4Q0dMcnFqZkZVai9GUmEyM25GUnkvd3VSdkVJYlhRaFkzMHRpVXpv?=
 =?utf-8?B?czVPckJveW1oZU5FQ2grSFIzSlRxVnNTQmUvaFlwWE1Odm1TaXNvdDZwSTBl?=
 =?utf-8?B?RHYxcFVKSW1LTzdIR2wvR2VTRUgrWmt1OEhzTEMvaUFiTlV0RjI2ZlNwN2pj?=
 =?utf-8?Q?tdb6jS7akkwn/FnAeUhVVU0=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a5413cc-6084-41eb-4cc3-08d9fcb7bf9a
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 01:47:17.5285
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hr6Kc5vsnrMWnAzltsgl/hDARTgkQFi5nI3ygPAIEh58E/RTgYW/OPwbG7R3JJZR34f4G5wSpMMTuQ48xkBbcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3829
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/2/22 12:38, David Hildenbrand wrote:
...
> BUT, once we actually write to the private mapping via the page table,
> the GUP pin would go out of sync with the now-anonymous page mapped into
> the page table. However, I'm having a hard time answering what's
> actually expected?
> 
> It's really hard to tell what the user wants with MAP_PRIVATE file
> mappings and stumbles over a !anon page (no modifications so far):
> 
> (a) I want a R/O pin to observe file modifications.
> (b) I want the R/O pin to *not* observe file modifications but observe
>      my (eventual? if any) private modifications,
> 

On this aspect, I think it is easier than trying to discern user
intentions. Because it is less a question of what the user wants, and
more a question of how mmap(2) is specified. And the man page clearly
indicates that the user has no right to expect to see file
modifications. Here's the excerpt:

"MAP_PRIVATE
	
Create  a private copy-on-write mapping.  Updates to the mapping are not
visible to other processes mapping the same file, and are not carried
through to the underlying file.  It is unspecified whether changes  made
to the file after the mmap() call are visible in the mapped region.
"

> Of course, if we already wrote to that page and now have an anon page,
> it's easy: we are already no longer following file changes.

Yes, and in fact, I've always thought that the way this was written
means that it should be treated as a snapshot of the file contents,
and no longer reliably connected in either direction to the page(s).


thanks,
-- 
John Hubbard
NVIDIA