Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <855de2f6-8223-d271-86b6-edb36cfdebb6@intel.com>
Date:   Wed, 2 Mar 2022 18:04:22 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [RFC 03/10] platform/x86/intel/ifs: Add driver for In-Field Scan
Content-Language: en-US
To:     "Williams, Dan J" <dan.j.williams@intel.com>,
        "hdegoede@redhat.com" <hdegoede@redhat.com>,
        "markgross@kernel.org" <markgross@kernel.org>
CC:     "corbet@lwn.net" <corbet@lwn.net>,
        "Raj, Ashok" <ashok.raj@intel.com>,
        "Luck, Tony" <tony.luck@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "Shankar, Ravi V" <ravi.v.shankar@intel.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "platform-driver-x86@vger.kernel.org" 
        <platform-driver-x86@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "hpa@zytor.com" <hpa@zytor.com>, "bp@alien8.de" <bp@alien8.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>
References: <20220301195457.21152-1-jithu.joseph@intel.com>
 <20220301195457.21152-4-jithu.joseph@intel.com>
 <f0e958c612ac4dab30ba458a08a7681e1114668f.camel@intel.com>
From:   "Joseph, Jithu" <jithu.joseph@intel.com>
In-Reply-To: <f0e958c612ac4dab30ba458a08a7681e1114668f.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1BERm5MSExKTnFJMitVNW1NMmpSU09TbTZJcllLVk5UdE5GaGhZSWFqZ2dy?=
 =?utf-8?B?U1Vab1pWazFkeTI1YkMyR1ZXR1FCZkNWMitKR0tLOG9uc0ZuengraG9jTWhU?=
 =?utf-8?B?OWlYM2h4Q0hncko0SlcyRm5NTVlIWVZaK1BXQXQ3SU5KMllLL09WRHp1VUEv?=
 =?utf-8?B?dmRTSmtxUzFINlQ5QlFvaXpPVURYTXpyNTFEaWx0d0dFWkVrVmpTTS8rU2ph?=
 =?utf-8?B?VzFJQlpmZ0ZQZ0lVQTQ0UmpvRmNyYVR6Rk5pQjJrcW5nRlIwSW9sRVpIZExn?=
 =?utf-8?B?aWhpcUJyWnFMQUZIdkxNRHIzcFRKR1EvQng1RXhlL1ZFR0NxVFd6ZlcxNU4z?=
 =?utf-8?B?Vnl2OEVGaWU0WHFBSVF2dE9oTkpTbXMxMHpLQTE2UVZFaVBPaXNhLys2eitG?=
 =?utf-8?B?eEFoLzNpcE1HUFdKSFdRZ1BncTB2Mm8rRUlpUUIzUHd1dXZqMkdpUDFnd0Ja?=
 =?utf-8?B?RzZVZElJUU9zZ1VTV2dYZW5VR2ZvZGdlNzJUMkdDekdyZS9FMDFseE10K29Z?=
 =?utf-8?B?cHFKMUM0NkJZbnFQMzkxMmg4cEUrcVRwT0I5UmNPQzFlVnVpSFJQSWZobEl0?=
 =?utf-8?B?c3hDeEFTMGttRjJEWEpQWXFUblhWQXdJV2ZkMHFuVGpZaDlaMUhSY3J0c01i?=
 =?utf-8?B?TjB4bGhMUEwzOC9rT0k2Rm5HMzRzQkRSY3U4M3c5WWozbkk2MnF4czlicnZj?=
 =?utf-8?B?QVMyNUs0ZDZPL0FkVitJNWxIaG9sZFRXL0s3bjRJZUlZRkV6RmJNVG9vUEpD?=
 =?utf-8?B?REdJdlFaTGZuNGFFWU1Bb0wvQ1JpQ1R3Skh4WFFydTRUeXlDVkpIUFRaaXdj?=
 =?utf-8?B?WDZuZTd2d0ljNXU4THd4bzJNbGtWaXowTXFjc1kzWFluRm1DSUY0cjBYWEpV?=
 =?utf-8?B?L0pDU2tXUWJ0am9sWkhBOVdGUjZRNDRIVUpTMVcxQURCRDBLMmRuYVJ6dHZP?=
 =?utf-8?B?L1NVU1dYRHVsUnlFNnZITlNEN3NzVzMxL1dsczB4dWQ1QmMvQTRHMm1vYmVk?=
 =?utf-8?B?SDQ5emZOSklWRGlZZFJmem1xMU4xMWxKbFBzZU13THlkQkMzaWNpanBWVFVW?=
 =?utf-8?B?a1RFZGlnSVMwNU8xdmFWNjBTN3NSWGVJcWYrVzgyaENXTlZkWTVYWVlQNCtl?=
 =?utf-8?B?eTZyeXdpOVNUQlN5RXVlMzZPQTdtM3FNQVJjYnVlSzlobUFmSXhTb0dHSzgw?=
 =?utf-8?B?ZWFMVE8rRGR0eG1IQnV4anlNTFRHSkVsMVBFTTFUazFrQkU4ZEJxQ0NBajhV?=
 =?utf-8?B?cWVKMi95QWVjU1ZQeFZSYXZBQWc0emtMUldTbkMxbFpzQ0VrYTdmOEl2dy8y?=
 =?utf-8?B?RmwxWHEzK2ppUVU3c2ZRWnZKN3JBcGZEbXB4bjlHNU1JTzYwQlU0aWRrMTRk?=
 =?utf-8?B?NUxuUnNzUi82ZURBSjFqbTFNSEtLYkt4ZDNqYUE0UnZ3cmZ5N1d6Z2lyVUtj?=
 =?utf-8?B?RENUTHVOZjhCVDd4RDRRaURnSGdYdEtZQTVJZzd5N08ycGo1b2hCY3htcjl5?=
 =?utf-8?B?dWdiUml3LzJ4WkFwMzFwTCt0UHQzZHFWYVg2TSt2bExVNHNkc2NVUG45VStN?=
 =?utf-8?B?cHdaQ1pPV1A2SkxhWXpPRTdvUHhwOFdZeGFjU2ZoQzlhQ3hSSVhLMTJEZWhV?=
 =?utf-8?B?V0hJV0VwNHErR1JnUmNlZVFaY0h6UkIwQmFrQitkY21aUXB5ZkJSUUZYTFZw?=
 =?utf-8?B?K2I1R3VsQTVmVEx3SWhkMjhqb29sNEJHTExMWEYvV0U1VXIyYVZzZk8veVd6?=
 =?utf-8?B?V1Bhd250cGJaeFh3MnJSN01ySFlMR0hiWUI0ZnBSdUwwREdTbHVpcGIxR0Y3?=
 =?utf-8?B?NjZoY25qQmtndHN4UW9sb0YxRHd6MmEvbGtyblZheTZ2ampDN3VkVmVjaGpR?=
 =?utf-8?B?QjY4K2o0VjhHRDhXdUtsNlhremg5THU5YXdUR3JJZ2FVOCtUMVhkZUsvdzl6?=
 =?utf-8?B?aHJkY3VzMXEwRlcySFBXektBUzBOeStzcVpDWXhVR1ZVRVBRc1Ftai91L2xQ?=
 =?utf-8?B?NXUvekdCNHlBQ1hPNGl3L3dnNDVUaVEyblRPWlpBNWF2WkxZUUNFMVhHNDhZ?=
 =?utf-8?B?RDNsU3BvNU5NQnhFMEwzeVJsVVpwZURLOHdEVFpackV0VG9FemdpS3A2ZmZU?=
 =?utf-8?B?bS9wcmtHZVR5bTBSM3lQMGNONjB2Nms0M2djUzVHNG42R3dnU3p3YjdaaUVV?=
 =?utf-8?Q?ksbWb3nOKwDRpVJv5TrQAZI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 902ccb44-8b3e-4578-8c6f-08d9fcba24e9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3768.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2022 02:04:26.4444
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hJXonAnaUtm94iPakqJKZ0ZoFV+tS8QWc7KP/fu0OF9K2+94NNEgtLSbSEXRpzveVA8OUYM65Mx35tgP2xdmEg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1720
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/2/2022 3:24 PM, Williams, Dan J wrote:

> 
> I don't see any need to include author info in source files, that's
> what 'git blame' is for.

Noted. Will remove it then


>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_INFO(name, "ifs");
>> +MODULE_DESCRIPTION("ifs");
> 
> Just omit MODULE_INFO and MODULE_DESCRIPTION if nothing of importance
> needs to be added.

Will try to be more informative and descriptive 

> 
>> +module_init(ifs_init);
>> +module_exit(ifs_exit);
>> diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
>> new file mode 100644
>> index 000000000000..f3f924fced06
>> --- /dev/null
>> +++ b/drivers/platform/x86/intel/ifs/ifs.h
>> @@ -0,0 +1,14 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/* Copyright(c) 2021 Intel Corporation.
>> + *
>> + * Author: Jithu Joseph <jithu.joseph@intel.com>
>> + */
>> +
>> +#ifndef _IFS_H_
>> +#define _IFS_H_
>> +
>> +/* These bits are in the IA32_CORE_CAPABILITIES MSR */
>> +#define MSR_IA32_CORE_CAPS_INTEGRITY_BIT       2
>> +#define MSR_IA32_CORE_CAPS_INTEGRITY           BIT(MSR_IA32_CORE_CAPS_INTEGRITY_BIT)
> 
> Is this header going to grow any more definitions? Otherwise these 2
> lines can just move into the source file.

Subsequent patches adds more definitions to this header.


Jithu