Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp391175pxm; Wed, 2 Mar 2022 18:09:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxCJgqsG/WEd84Ja9DYZfUql9Ha0xSTj50k80ql69SIuoEnIfxO/a+suV2/dthjVsabJn9L X-Received: by 2002:a17:90b:4a08:b0:1be:f8ab:2ab6 with SMTP id kk8-20020a17090b4a0800b001bef8ab2ab6mr2822873pjb.186.1646273343574; Wed, 02 Mar 2022 18:09:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646273343; cv=none; d=google.com; s=arc-20160816; b=FwWPd7j3pyp/SjeSN+dCiQ+ezXdG0DDPegVEkGRGpBX6+wxGRlA3HGTSPcyA5oKUjF n0SO43gI7LunT50jEnIHSNl+xQ3ovaGmmHJhbcpIMDyoDxEbuvikTzvKAloyskt//1xs JZF6iNbtsqnplJCUhGg5bhOicOpmZBRHbDi/Y3WHb4nO6BExBBBkz9Xw/UCt+8WHhLqz Jtv3Tpd0pfwlW8vmm6B0lp3lLrx4xgrwZw6lsoGalJkn2NCf/37Ca6it6rpR7rHzi3nL LAX5U+qR9eJOTrjx0q6XKyt0b4NYguWaEEusu7vstaDAwNsbZxr79JRSEVXKs9Lzvo4M bouQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=6Bi6MgNfx0noWQRcTXp4jBUI52iaiXwA09JU/CX3lOc=; b=fFT2+xTJyLlOdu09aZ2xqS//phcGAxJ/sYzm8HV7X/+s9kQDGZ0pcRybcdCM1zzjTe kXLxyCG7wB3oTVzZx6jeh1TLpCdlOggeDqPB04ly45mjRknGwQFQ0YicP6/KxBrJ88De 6TxZE+7NNULTCGMiGG+XETyLF59VF6uSqZID8G+d/lNbQUP91KH96h8e1Wl1zlYQ5hcB WaTSNrsWyzU8vMmiru04ghDgqbD3LC5K7k4L7yX0VUTE2a/SSi26Kdenhao1iFkuFMny jvXdILozsd3tPkgfci2ZGvV5hJ0qOgUkhtgjXIqs1Z0bCPF/LF8X/WJEcrRo2v+oqdb/ Meug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gnuweeb.org header.s=default header.b=UIH3FdIH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnuweeb.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t2-20020a17090a950200b001b8b4ebe253si6743139pjo.151.2022.03.02.18.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 18:09:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gnuweeb.org header.s=default header.b=UIH3FdIH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnuweeb.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AFEC62DAB5; Wed, 2 Mar 2022 18:07:25 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231660AbiCCCIH (ORCPT + 99 others); Wed, 2 Mar 2022 21:08:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231646AbiCCCIG (ORCPT ); Wed, 2 Mar 2022 21:08:06 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8955C13F93; Wed, 2 Mar 2022 18:07:22 -0800 (PST) Received: from [192.168.43.69] (unknown [182.2.41.243]) by gnuweeb.org (Postfix) with ESMTPSA id 332EA7E216; Thu, 3 Mar 2022 02:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1646273241; bh=6hdPeUDTpFCH5tm6GIDzeefZQ1DijYbUe34dlL4yiHc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UIH3FdIHhEtHk9207mgmSkpczcVJySwwhRd+ngT+WnK2kIMqnXD+y1/jr1F7gCnOI Oytv61vKSH1RjRiybyD9OcV+fXo992onmw6sDyNjdO5v/4FBiBI3SCdRzJcsZhVvLs GqQzJXlA1qa8vPLNHn9VYvzGX0EOGde+wd4MB2KB5AnfLJBZx+Ue1NwZgJlk3VDLMf +CGFGCi6A2gjPDAJyGhUDIWNwZbxgJyLXh4rMia+u4hw1rtEaDCWWBTKp+NsblZxgk Q8OXX7WXFf/recNzBhiPcnCYbycBihpDoTwZX7VNTRBkDj3J6TBM0xQFitYIb9/xLC kyje9KbfxM6Tg== Message-ID: <49313736-61f8-d001-0fe4-b6166c859585@gnuweeb.org> Date: Thu, 3 Mar 2022 09:07:12 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v4 2/2] x86/mce/amd: Fix memory leak when `threshold_create_bank()` fails Content-Language: en-US To: Alviro Iskandar Setiawan , Yazen Ghannam Cc: Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Tony Luck , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, gwml@vger.gnuweeb.org, x86@kernel.org, stable@vger.kernel.org, Alviro Iskandar Setiawan , Jiri Hladky , Greg Kroah-Hartman References: <20220301094608.118879-1-ammarfaizi2@gnuweeb.org> <20220301094608.118879-3-ammarfaizi2@gnuweeb.org> <4371a592-6686-c535-4daf-993dedb43cd4@gnuweeb.org> <109a10da-d1d1-c47a-2f04-31796457f6ff@gnuweeb.org> <20220303015826.4176416-1-alviro.iskandar@gnuweeb.org> From: Ammar Faizi In-Reply-To: <20220303015826.4176416-1-alviro.iskandar@gnuweeb.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/3/22 8:58 AM, Alviro Iskandar Setiawan wrote: > hi sir, i think this can be improved again, we can avoid calling > this_cpu_read(mce_num_banks) twice if we pass the numbanks as an > argument, plz review the changes below OK, nice improvement. I will fold this in... -- Ammar Faizi